Update OF thermal properties for cooling-{min,max}-level
Subsystems (2)
cover Update OF thermal properties for cooling-{min,max}-level
Hi,
The device tree properties regarding the specification and usage of states for cooling devices suffer from inconsistency in the bindings as well as the usage.
The two patches here update the bindings to be consistent without breaking existing support for the device trees already in upstream.
Thanks,
Punit
Punit Agrawal (2):
of: thermal: Fix inconsitency between cooling-*-state and
cooling-*-level
of: thermal: Mark cooling-*-level properties optional
.../devicetree/bindings/thermal/thermal.txt | 27 +++++++++++----------- 1 file changed, 14 insertions(+), 13 deletions(-)
Signature · 1 line
2.5.0
PATCH 1/2 of: thermal: Fix inconsitency between cooling-*-state and cooling-*-level
The device trees in the kernel as well as the binding description in Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt use the cooling-{min,max}-level property.
Fix the inconsistency with the binding description in Documentation/devicetree/bindings/thermal/thermal.txt by changing cooling-*-state properties to cooling-*-level.
--- Documentation/devicetree/bindings/thermal/thermal.txt | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
Documentation/devicetree/bindings/thermal/thermal.txt +7 -7
@@ -55,16 +55,16 @@ of heat dissipation). For example a fan's cooling states correspond to the different fan speeds possible. Cooling states are referred to by single unsigned integers, where larger numbers mean greater heat dissipation. The precise set of cooling states associated with a device -(as referred to be the cooling-min-state and cooling-max-state +(as referred to by the cooling-min-level and cooling-max-level properties) should be defined in a particular device's binding. For more examples of cooling devices, refer to the example sections below. Required properties: -- cooling-min-state: An integer indicating the smallest +- cooling-min-level: An integer indicating the smallest Type: unsigned cooling state accepted. Typically 0. Size: one cell -- cooling-max-state: An integer indicating the largest +- cooling-max-level: An integer indicating the largest Type: unsigned cooling state accepted. Size: one cell
@@ -225,8 +225,8 @@ cpus { 396000 950000 198000 850000 >; - cooling-min-state = <0>; - cooling-max-state = <3>; + cooling-min-level = <0>; + cooling-max-level = <3>; #cooling-cells = <2>; /* min followed by max */ }; ...
@@ -240,8 +240,8 @@ cpus { */ fan0: fan@0x48 { ... - cooling-min-state = <0>; - cooling-max-state = <9>; + cooling-min-level = <0>; + cooling-max-level = <9>; #cooling-cells = <2>; /* min followed by max */ }; };
Signature · 1 line
2.5.0
Re: [PATCH 1/2] of: thermal: Fix inconsitency between cooling-*-state and cooling-*-level
Quoted 8 lines · Punit Agrawal
The device trees in the kernel as well as the binding description in
Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txtuse the cooling-{min,max}-level property.Fix the inconsistency with the binding description in
Documentation/devicetree/bindings/thermal/thermal.txtby changing cooling-*-state properties to cooling-*-level.
Quoted 6 lines
Signed-off-by Punit Agrawal <[email protected]>Cc Eduardo Valentin <[email protected]>Cc Rob Herring <[email protected]>Cc Mark Rutland <[email protected]>Cc Ian Campbell <[email protected]>Cc Kumar Gala <[email protected]>
Both patches applied. Thanks.
Rob
Quoted 53 lines
--- Documentation/devicetree/bindings/thermal/thermal.txt | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)Documentation/devicetree/bindings/thermal/thermal.txt +7
-8@@ -55,16 +55,16 @@ of heat dissipation). For example a fan's cooling states correspond to the different fan speeds possible. Cooling states are referred to by single unsigned integers, where larger numbers mean greater heat dissipation. The precise set of cooling states associated with a device -(as referred to be the cooling-min-state and cooling-max-state +(as referred to by the cooling-min-level and cooling-max-level properties) should be defined in a particular device's binding. For more examples of cooling devices, refer to the example sections below. Required properties: -- cooling-min-state: An integer indicating the smallest +- cooling-min-level: An integer indicating the smallest Type: unsigned cooling state accepted. Typically 0. Size: one cell -- cooling-max-state: An integer indicating the largest +- cooling-max-level: An integer indicating the largest Type: unsigned cooling state accepted. Size: one cell@@ -225,8 +225,8 @@ cpus { 396000 950000 198000 850000 >; - cooling-min-state = <0>; - cooling-max-state = <3>; + cooling-min-level = <0>; + cooling-max-level = <3>; #cooling-cells = <2>; /* min followed by max */ };@@ -240,8 +240,8 @@ cpus { */ fan0: fan@0x48 { - cooling-min-state = <0>; - cooling-max-state = <9>; + cooling-min-level = <0>; + cooling-max-level = <9>; #cooling-cells = <2>; /* min followed by max */ }; }; --2.5.0
Re: [PATCH 1/2] of: thermal: Fix inconsitency between cooling-*-state and cooling-*-level
Hi Rob,
Quoted 9 lines · Rob Herring
Quoted 8 lines · Punit Agrawal
The device trees in the kernel as well as the binding description in
Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txtuse the cooling-{min,max}-level property.Fix the inconsistency with the binding description in
Documentation/devicetree/bindings/thermal/thermal.txtby changing cooling-*-state properties to cooling-*-level.
Quoted 8 lines
Quoted 6 lines
Signed-off-by Punit Agrawal <[email protected]>Cc Eduardo Valentin <[email protected]>Cc Rob Herring <[email protected]>Cc Mark Rutland <[email protected]>Cc Ian Campbell <[email protected]>Cc Kumar Gala <[email protected]>Both patches applied. Thanks.
I see the patches in v4.3-rc3 now. Thanks for picking up these fixes.
Cheers,
Punit
Quoted 60 lines
Rob
Quoted 51 lines
--- Documentation/devicetree/bindings/thermal/thermal.txt | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)Documentation/devicetree/bindings/thermal/thermal.txt +7
-8@@ -55,16 +55,16 @@ of heat dissipation). For example a fan's cooling states correspond to the different fan speeds possible. Cooling states are referred to by single unsigned integers, where larger numbers mean greater heat dissipation. The precise set of cooling states associated with a device -(as referred to be the cooling-min-state and cooling-max-state +(as referred to by the cooling-min-level and cooling-max-level properties) should be defined in a particular device's binding. For more examples of cooling devices, refer to the example sections below. Required properties: -- cooling-min-state: An integer indicating the smallest +- cooling-min-level: An integer indicating the smallest Type: unsigned cooling state accepted. Typically 0. Size: one cell -- cooling-max-state: An integer indicating the largest +- cooling-max-level: An integer indicating the largest Type: unsigned cooling state accepted. Size: one cell@@ -225,8 +225,8 @@ cpus { 396000 950000 198000 850000 >; - cooling-min-state = <0>; - cooling-max-state = <3>; + cooling-min-level = <0>; + cooling-max-level = <3>; #cooling-cells = <2>; /* min followed by max */ };@@ -240,8 +240,8 @@ cpus { */ fan0: fan@0x48 { - cooling-min-state = <0>; - cooling-max-state = <9>; + cooling-min-level = <0>; + cooling-max-level = <9>; #cooling-cells = <2>; /* min followed by max */ }; }; --Quoted 2 lines
2.5.0
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 1441711013-11220-1-git-send-email-punit.agrawal-5wv7dgnIgG8@public.gmane.org
PATCH 2/2 of: thermal: Mark cooling-*-level properties optional
The cooling-{min,max}-level properties are marked as optional in Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt and the usage in various device tree matches this, i.e., some cooling device in the device trees provide these properties while others do not.
Make the bindings in Documentation/devicetree/bindings/thermal/thermal.txt consistent with the cpufreq-dt bindings by marking the cooling-*-level properties as optional.
--- Documentation/devicetree/bindings/thermal/thermal.txt | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-)
Documentation/devicetree/bindings/thermal/thermal.txt +9 -8
@@ -60,14 +60,6 @@ properties) should be defined in a particular device's binding. For more examples of cooling devices, refer to the example sections below. Required properties: -- cooling-min-level: An integer indicating the smallest - Type: unsigned cooling state accepted. Typically 0. - Size: one cell - -- cooling-max-level: An integer indicating the largest - Type: unsigned cooling state accepted. - Size: one cell - - #cooling-cells: Used to provide cooling device specific information Type: unsigned while referring to it. Must be at least 2, in order Size: one cell to specify minimum and maximum cooling state used
@@ -77,6 +69,15 @@ Required properties: See Cooling device maps section below for more details on how consumers refer to cooling devices. +Optional properties: +- cooling-min-level: An integer indicating the smallest + Type: unsigned cooling state accepted. Typically 0. + Size: one cell + +- cooling-max-level: An integer indicating the largest + Type: unsigned cooling state accepted. + Size: one cell + * Trip points The trip node is a node to describe a point in the temperature domain
Signature · 6 lines
2.5.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 9 lines · Punit Agrawal
Hi,
The device tree properties regarding the specification and usage of states for cooling devices suffer from inconsistency in the bindings as well as the usage.
The two patches here update the bindings to be consistent without breaking existing support for the device trees already in upstream.
Gentle reminder to request review of the below two patches!
Quoted 10 lines
Thanks,
PunitPunit Agrawal (2):
of: thermal: Fix inconsitency between cooling-*-state and
cooling-*-level
of: thermal: Mark cooling-*-level properties optional.../devicetree/bindings/thermal/thermal.txt | 27 +++++++++++----------- 1 file changed, 14 insertions(+), 13 deletions(-)
Quoted 9 lines · Punit Agrawal
Hi,
The device tree properties regarding the specification and usage of states for cooling devices suffer from inconsistency in the bindings as well as the usage.
The two patches here update the bindings to be consistent without breaking existing support for the device trees already in upstream.
Quoted 7 lines
Thanks,
PunitPunit Agrawal (2):
of: thermal: Fix inconsitency between cooling-*-state and
cooling-*-level
of: thermal: Mark cooling-*-level properties optional
Applied, thanks.
Rob
Quoted 4 lines
.../devicetree/bindings/thermal/thermal.txt | 27 +++++++++++----------- 1 file changed, 14 insertions(+), 13 deletions(-)