drm/i915: Remove one very outdated comment
Subsystems (2)
PATCH 1/1 drm/i915: Remove one very outdated comment
From: Tvrtko Ursulin <[email protected]>
Comment disagrees with the code which has changed a lot since it was documented.
Signed-off-by Tvrtko Ursulin <[email protected]>
--- drivers/gpu/drm/i915/i915_gem.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/gpu/drm/i915/i915_gem.c +0 -4
@@ -3230,10 +3230,6 @@ int i915_vma_unbind(struct i915_vma *vma) ret =i915_gem_object_wait_rendering (obj, false);if (ret)return ret; -/* Continue on if we fail due to EIO, the GPU is hung so we -* should be safe and we need to cleanup or else we might -* cause memory corruption through use-after-free. -*/ if (i915_is_ggtt (vma->vm) && vma->ggtt_view.type ==I915_GGTT_VIEW_NORMAL ) {
Signature · 6 lines
2.5.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 6 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Comment disagrees with the code which has changed a lot since it was documented.
Signed-off-by Tvrtko Ursulin <[email protected]>
Applied, with the commit citation added for the patch which made this comment obsolete. I tried finding the curb-EIO commit too, but that one might have stalled somewhere :(
-Daniel
Quoted 26 lines
--- drivers/gpu/drm/i915/i915_gem.c | 4 ---- 1 file changed, 4 deletions(-)drivers/gpu/drm/i915/i915_gem.c +0
-4@@ -3230,10 +3230,6 @@ int i915_vma_unbind(struct i915_vma *vma) ret =i915_gem_object_wait_rendering (obj, false);if (ret)return ret; -/* Continue on if we fail due to EIO, the GPU is hung so we -* should be safe and we need to cleanup or else we might -* cause memory corruption through use-after-free. -*/ if (i915_is_ggtt (vma->vm) && vma->ggtt_view.type ==I915_GGTT_VIEW_NORMAL ) {Signature · 6 lines
2.5.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx