Skip to contentSkip to conversation

package/host-gdb: fix autobuild failure

PATCH New Brendan Heading 3 participants 8 messages Sep 8, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/host-gdb: fix autobuild failure

Fixes :

http://autobuild.buildroot.net/results/dd5/dd50ed99abb2c8495def826866b184030953f90e/

.. and many others.

host-gdb is broken on all architectures at the moment, as it seems to require makeinfo during "make install" even if configure failed to detect it. Instead of trying to hack it, let's simply make gdb dependent on host-texinfo.

---
 package/gdb/gdb.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/gdb/gdb.mk +1 -1
index 338de20..efe195a 100644
@@ -40,7 +40,7 @@ endif
 # For the host variant, we really want to build with XML support,
 # which is needed to read XML descriptions of target architectures. We
 # also need ncurses.
-HOST_GDB_DEPENDENCIES = host-expat host-ncurses
+HOST_GDB_DEPENDENCIES = host-expat host-ncurses host-texinfo
 
 # Apply the Xtensa specific patches
 XTENSA_CORE_NAME = $(call qstrip, $(BR2_XTENSA_CORE_NAME))
Signature · 1 line
2.4.3
#1 lore raw

PATCH 1/1 package/host-gdb: fix autobuild failure

Quoted 10 lines · Brendan Heading

Fixes :

http://autobuild.buildroot.net/results/dd5/dd50ed99abb2c8495def826866b184030953f90e/

.. and many others.

host-gdb is broken on all architectures at the moment, as it seems to require makeinfo during "make install" even if configure failed to detect it. Instead of trying to hack it, let's simply make gdb dependent on host-texinfo.

Any idea why this is not needed for target gdb?

Regards,
Arnout

Quoted 20 lines
---
 package/gdb/gdb.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/gdb/gdb.mk +1 -1
index 338de20..efe195a 100644
@@ -40,7 +40,7 @@ endif
 # For the host variant, we really want to build with XML support,
 # which is needed to read XML descriptions of target architectures. We
 # also need ncurses.
-HOST_GDB_DEPENDENCIES = host-expat host-ncurses
+HOST_GDB_DEPENDENCIES = host-expat host-ncurses host-texinfo
 
 # Apply the Xtensa specific patches
 XTENSA_CORE_NAME = $(call qstrip, $(BR2_XTENSA_CORE_NAME))
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#2 lore raw

PATCH 1/1 package/host-gdb: fix autobuild failure

Quoted 6 lines
Quoted 4 lines

host-gdb is broken on all architectures at the moment, as it seems to require makeinfo during "make install" even if configure failed to detect it. Instead of trying to hack it, let's simply make gdb dependent on host-texinfo.

Any idea why this is not needed for target gdb?

Good point, I expect that it is - I will check and resubmit.

Brendan

#3 lore raw

PATCH 1/1 package/host-gdb: fix autobuild failure

In reply to Arnout Vandecappelle

Dear Arnout Vandecappelle,

Quoted 5 lines · Arnout Vandecappelle
Quoted 4 lines · Brendan Heading

Fixes :

http://autobuild.buildroot.net/results/dd5/dd50ed99abb2c8495def826866b184030953f90e/

Quoted 8 lines
Quoted 6 lines

.. and many others.

host-gdb is broken on all architectures at the moment, as it seems to require makeinfo during "make install" even if configure failed to detect it. Instead of trying to hack it, let's simply make gdb dependent on host-texinfo.

Any idea why this is not needed for target gdb?

It is needed for the target as well. You can build the target gdb without building the host gdb, in which case the host-texinfo package would not be installed and you would face the failure again.

Brendan, please, can you add the dependency for target gdb as well?

Regards,

Vincent.

Quoted 25 lines

Regards,
Arnout

Quoted 20 lines
---
 package/gdb/gdb.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/gdb/gdb.mk +1 -1
index 338de20..efe195a 100644
@@ -40,7 +40,7 @@ endif
 # For the host variant, we really want to build with XML support,
 # which is needed to read XML descriptions of target architectures. We
 # also need ncurses.
-HOST_GDB_DEPENDENCIES = host-expat host-ncurses
+HOST_GDB_DEPENDENCIES = host-expat host-ncurses host-texinfo
 
 # Apply the Xtensa specific patches
 XTENSA_CORE_NAME = $(call qstrip, $(BR2_XTENSA_CORE_NAME))
#4 lore raw

PATCH 1/1 package/host-gdb: fix autobuild failure

Quoted 5 lines

It is needed for the target as well. You can build the target gdb without building the host gdb, in which case the host-texinfo package would not be installed and you would face the failure again.

Brendan, please, can you add the dependency for target gdb as well?

I'm looking at it, but strangely, I'm not able to reproduce the same problem with target GDB - it appears to build just fine without the texinfo dependency.

Looking into why, and will submit an updated patch when I crack it. Probably a difference with the config, or there's a patch being added somewhere.

Brendan

#5 lore raw

PATCH 1/1 package/host-gdb: fix autobuild failure

Dear Brendan Heading,

Quoted 6 lines · Brendan Heading
Quoted 5 lines

It is needed for the target as well. You can build the target gdb without building the host gdb, in which case the host-texinfo package would not be installed and you would face the failure again.

Brendan, please, can you add the dependency for target gdb as well?

Quoted 7 lines

I'm looking at it, but strangely, I'm not able to reproduce the same problem with target GDB - it appears to build just fine without the texinfo dependency.

Looking into why, and will submit an updated patch when I crack it. Probably a difference with the config, or there's a patch being added somewhere.

Perhaps you trying to build the target gdb in the same buildroot tree where you have built the host gdb? (which will have makeinfo available because host-texinfo has been built).

Regards,

Vincent.

Quoted 2 lines

Brendan

#6 lore raw

PATCH 1/1 package/host-gdb: fix autobuild failure

Quoted 7 lines
Quoted 3 lines

Looking into why, and will submit an updated patch when I crack it. Probably a difference with the config, or there's a patch being added somewhere.

Perhaps you trying to build the target gdb in the same buildroot tree where you have built the host gdb? (which will have makeinfo available because host-texinfo has been built).

No, host-texinfo is not being built at all.

I found the cause - by default the full gdb is not built, only gdbserver. It seems that a gdbserver-only build does not trigger the documentation element of "make install" in gdb.

I need to make a better patch as there's already logic in the build to only depend on texinfo under certain circumstances - and I also need to test all the combinations (three different GDB versions are supported). Hopefully will send it through today.

regards

Brendan

#7 lore raw

PATCH 1/1 package/host-gdb: fix autobuild failure

Dear Brendan Heading,

Quoted 8 lines · Brendan Heading
Quoted 7 lines
Quoted 3 lines

Looking into why, and will submit an updated patch when I crack it. Probably a difference with the config, or there's a patch being added somewhere.

Perhaps you trying to build the target gdb in the same buildroot tree where you have built the host gdb? (which will have makeinfo available because host-texinfo has been built).

Quoted 5 lines

No, host-texinfo is not being built at all.

I found the cause - by default the full gdb is not built, only gdbserver. It seems that a gdbserver-only build does not trigger the documentation element of "make install" in gdb.

Indeed, I was reproducing the autobuild failure with the full gdb.

Quoted 4 lines

I need to make a better patch as there's already logic in the build to only depend on texinfo under certain circumstances - and I also need to test all the combinations (three different GDB versions are supported). Hopefully will send it through today.

When you do it, could you please use a better subject? "fix autobuild failure" doesn't give any information about what the patch does. "host-texinfo needed for full gdb" gives more information, for instance.

Regards,

Vincent.

Quoted 4 lines

regards

Brendan