writeback: account BDI's min_ratio for unregistered device
Subsystems (2)
PATCH RESEND 1/1 writeback: account BDI's min_ratio for unregistered device
Quoted 1 line
From
mm/page-writeback.c:
/* * bdi_min_ratio keeps the sum of the minimum dirty shares of all * registered backing devices, which, for obvious reasons, can not * exceed 100%. */ static unsigned int bdi_min_ratio;
But when a backing device is unregistered, the BDI's min_ratio is not subtracted from bdi_min_ratio. So the second attempt to set min_ratio in the following commands will fail.
# modprobe null_blk # echo 50 > /sys/block/nullb0/bdi/min_ratio # modprobe -r null_blk # modprobe null_blk # echo 50 > /sys/block/nullb0/bdi/min_ratio
Signed-off-by Akinobu Mita <[email protected]>
Acked-by Tejun Heo <[email protected]>
Cc Tejun Heo <[email protected]>
Cc Jens Axboe <[email protected]>
---
Resending with Tejun's ACK
mm/backing-dev.c | 1 + 1 file changed, 1 insertion(+)
mm/backing-dev.c +1 -0
@@ -849,6 +849,7 @@ void bdi_destroy(struct backing_dev_info *bdi) }wb_exit (&bdi->wb); +bdi_set_min_ratio (bdi,0 ); }EXPORT_SYMBOL (bdi_destroy);
Signature · 1 line
1.9.1