Skip to contentSkip to conversation

dpkg: put start-stop-daemon in its own package

PATCH In review Joe Slater 3 participants 4 messages Sep 8, 2015 – Sep 9, 2015

lore
Share & tools
lore

Joe Slater

author
#0 lore raw

cover dpkg: put start-stop-daemon in its own package

I thought I sent this a week or two ago, but maybe I didn't.

Joe Slater (1):
dpkg: put start-stop-daemon in its own package

 meta/recipes-devtools/dpkg/dpkg.inc |   20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 1/1 dpkg: put start-stop-daemon in its own package

Also make it update-alternatives compatible and move it to where busybox puts its version.

Make dpkg RDEPEND on dpkg-start-stop.

---
 meta/recipes-devtools/dpkg/dpkg.inc |   20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)
meta/recipes-devtools/dpkg/dpkg.inc +19 -1
index 6eec2cd..2d7cad0 100644
@@ -11,7 +11,7 @@ DEPENDS_class-native = "bzip2-replacement-native zlib-native virtual/update-alte
 RDEPENDS_${PN} = "${VIRTUAL-RUNTIME_update-alternatives} xz run-postinsts perl"
 RDEPENDS_${PN}_class-native = "xz-native"
 
-inherit autotools gettext perlnative pkgconfig systemd
+inherit autotools gettext perlnative pkgconfig systemd update-alternatives
 
 python () {
     if not bb.utils.contains('DISTRO_FEATURES', 'sysvinit', True, False, d):
@@ -43,6 +43,12 @@ do_configure () {
 }
 
 do_install_append () {
+	if [ -e ${D}${sbindir}/start-stop-daemon ]; then
+		mkdir -p ${D}${base_sbindir}
+		mv ${D}${sbindir}/start-stop-daemon ${D}${base_sbindir}/start-stop-daemon
+		rmdir --ignore-fail-on-non-empty ${D}${sbindir}
+	fi
+
 	if [ "${PN}" = "dpkg-native" ]; then
 		# update-alternatives doesn't have an offline mode
 		rm ${D}${bindir}/update-alternatives
@@ -67,6 +73,18 @@ PROV_class-native = ""
 
 PROVIDES += "${PROV}"
 
+# split out start-stop-daemon to its own package
+#
+PACKAGES =+ "${PN}-start-stop"
+FILES_${PN}-start-stop = "${base_sbindir}/start-stop-daemon.dpkg"
+
+ALTERNATIVE_PRIORITY="100"
+ALTERNATIVE_${PN}-start-stop = "start-stop-daemon"
+ALTERNATIVE_LINK_NAME[start-stop-daemon]="${base_sbindir}/start-stop-daemon"
+
+RDEPENDS_${PN} += "${PN}-start-stop"
+#
+
 PACKAGES =+ "update-alternatives-dpkg"
 FILES_update-alternatives-dpkg = "${bindir}/update-alternatives ${localstatedir}/lib/dpkg/alternatives ${sysconfdir}/alternatives"
 RPROVIDES_update-alternatives-dpkg += "update-alternatives"
Signature · 1 line
1.7.9.5
#2 lore raw

Hello Joe,

Quoted 6 lines · Joe Slater
meta/recipes-devtools/dpkg/dpkg.inc +2 -0
@@ -67,6 +73,18 @@ PROV_class-native = ""
 
 PROVIDES += "${PROV}"
 
+# split out start-stop-daemon to its own package
+#

meta/recipes-devtools/dpkg/dpkg.inc PROV_class-native = "" · line 87

Quoted 10 lines
meta/recipes-devtools/dpkg/dpkg.inc +10 -0
+PACKAGES =+ "${PN}-start-stop"
+FILES_${PN}-start-stop = "${base_sbindir}/start-stop-daemon.dpkg"
+
+ALTERNATIVE_PRIORITY="100"
+ALTERNATIVE_${PN}-start-stop = "start-stop-daemon"
+ALTERNATIVE_LINK_NAME[start-stop-daemon]="${base_sbindir}/start-stop-daemon"
+
+RDEPENDS_${PN} += "${PN}-start-stop"
+#
+

I think you should omit the comment, because it only describes the obvious.

How about using ${PN}-start-stop-daemon?

Regards,
Andreas

#3 lore raw

That's fine with me. I'll rename the package and eliminate the comment. Joe

Quoted 38 lines

-----Original Message-----
From: [email protected] [mailto:openembedded-core- [email protected]] On Behalf Of Andreas Oberritter
Sent: Tuesday, September 08, 2015 11:21 AM
To: [email protected]
Subject: Re: [OE-core] [oe-core][PATCH 1/1] dpkg: put start-stop-daemon in its own package

Hello Joe,

Quoted 6 lines · Joe Slater
meta/recipes-devtools/dpkg/dpkg.inc +2 -0
@@ -67,6 +73,18 @@ PROV_class-native = ""
 
 PROVIDES += "${PROV}"
 
+# split out start-stop-daemon to its own package
+#

meta/recipes-devtools/dpkg/dpkg.inc PROV_class-native = "" · line 87

Quoted 10 lines
meta/recipes-devtools/dpkg/dpkg.inc +10 -0
+PACKAGES =+ "${PN}-start-stop"
+FILES_${PN}-start-stop = "${base_sbindir}/start-stop-daemon.dpkg"
+
+ALTERNATIVE_PRIORITY="100"
+ALTERNATIVE_${PN}-start-stop = "start-stop-daemon"
+ALTERNATIVE_LINK_NAME[start-stop-daemon]="${base_sbindir}/start-stop-daemon"
+
+RDEPENDS_${PN} += "${PN}-start-stop"
+#
+

I think you should omit the comment, because it only describes the obvious.

How about using ${PN}-start-stop-daemon?

Regards,
Andreas
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core