Skip to contentSkip to conversation

net/mac80211/rate.c: fix wrong sizeof()

PATCH In review Sergei Trofimovich 2 participants 2 messages Sep 9, 2015 – Sep 10, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/mac80211/rate.c: fix wrong sizeof()

From: Sergei Trofimovich <[email protected]>

Noticed by gcc-5.2.0:

    net/mac80211/rate.c: In function 'rate_control_cap_mask':
    net/mac80211/rate.c:719:25: warning: 'sizeof' on array function parameter 'mcs_mask' will return size of 'u8 * {aka unsigned char *}' [-Wsizeof-array-argument]
       for (i = 0; i < sizeof(mcs_mask); i++)
                             ^
CC Lorenzo Bianconi <[email protected]>
CC Johannes Berg <[email protected]>
CC "David S. Miller" <davem-fT/PcQaiUtIeIZ0/[email protected]>
---
 net/mac80211/rate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/mac80211/rate.c +1 -1
index 9857693..9ce8883 100644
@@ -716,7 +716,7 @@ static bool rate_control_cap_mask(struct ieee80211_sub_if_data *sdata,
 
 		/* Filter out rates that the STA does not support */
 		*mask &= sta->supp_rates[sband->band];
-		for (i = 0; i < sizeof(mcs_mask); i++)
+		for (i = 0; i < IEEE80211_HT_MCS_MASK_LEN; i++)
 			mcs_mask[i] &= sta->ht_cap.mcs.rx_mask[i];
 
 		sta_vht_cap = sta->vht_cap.vht_mcs.rx_mcs_map;
Signature · 6 lines
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
maintainer
#1 lore raw
Quoted 11 lines · Sergei Trofimovich

From: Sergei Trofimovich <[email protected]>

Noticed by gcc-5.2.0:

    net/mac80211/rate.c: In function 'rate_control_cap_mask':
    net/mac80211/rate.c:719:25: warning: 'sizeof' on array function 
parameter 'mcs_mask' will return size of 'u8 * {aka unsigned char *}' 
[-Wsizeof-array-argument]
       for (i = 0; i < sizeof(mcs_mask); i++)
                             ^

We already merged a fix for this.

johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html