hvc_dcc: don't ignore errors during initialization
PATCH v3 1/2 hvc_dcc: don't ignore errors during initialization
hvc_instantiate() and hvc_alloc() return errors if they fail, so don't ignore them.
Signed-off-by Timur Tabi <[email protected]>
--- drivers/tty/hvc/hvc_dcc.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-)
drivers/tty/hvc/hvc_dcc.c +11 -4
@@ -70,20 +70,27 @@ static const struct hv_ops hvc_dcc_get_put_ops = {static int __init hvc_dcc_console_init (void ) { +int ret; +if (!hvc_dcc_check ())return -ENODEV ; -hvc_instantiate (0 ,0 , &hvc_dcc_get_put_ops); -return 0 ; +/* Returns -1 if error */ + ret =hvc_instantiate (0 ,0 , &hvc_dcc_get_put_ops); + +return ret <0 ? -ENODEV :0 ; }console_initcall (hvc_dcc_console_init);static int __init hvc_dcc_init (void ) { +struct hvc_struct *p; +if (!hvc_dcc_check ())return -ENODEV ; -hvc_alloc (0 ,0 , &hvc_dcc_get_put_ops,128 ); -return 0 ; + p =hvc_alloc (0 ,0 , &hvc_dcc_get_put_ops,128 ); + +return PTR_ERR_OR_ZERO (p); }device_initcall (hvc_dcc_init);
Signature · 3 lines
Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
PATCH v5 2/2 ARM64: TTY: hvc_dcc: Add support for ARM64 dcc
From: Abhimanyu Kapur <[email protected]>
Add support for debug communications channel based hvc console for arm64 cpus.
Signed-off-by Abhimanyu Kapur <[email protected]>
Signed-off-by Timur Tabi <[email protected]>
--- arch/arm64/include/asm/dcc.h | 55 ++++++++++++++++++++++++++++++++++++++++++++ drivers/tty/hvc/Kconfig | 2 +- 2 files changed, 56 insertions(+), 1 deletion(-) create mode 100644 arch/arm64/include/asm/dcc.h
arch/arm64/include/asm/dcc.h new file +55 -0
@@ -0,0 +1,55 @@ +/* Copyright (c) 2014-2015 The Linux Foundation. All rights reserved. +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License version 2 and +* only version 2 as published by the Free Software Foundation. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* A call to __dcc_getchar() or __dcc_putchar() is typically followed by +* a call to __dcc_getstatus(). We want to make sure that the CPU does +* not speculative read the DCC status before executing the read or write +* instruction. That's what the ISBs are for. +* +* The 'volatile' ensures that the compiler does not cache the status bits, +* and instead reads the DCC register every time. +*/ +#ifndef __ASM_DCC_H +#define __ASM_DCC_H + +#include <asm/barrier.h> + +static inline u32 __dcc_getstatus (void ) +{ +u32 ret; + + asmvolatile ("mrs %0, mdccsr_el0" :"=r" (ret)); + +return ret; +} + +static inline char __dcc_getchar (void ) +{ +char c; + + asmvolatile ("mrs %0, dbgdtrrx_el0" :"=r" (c)); +isb (); + +return c; +} + +static inline void __dcc_putchar (char c) +{ +/* +* The typecast is to make absolutely certain that 'c' is +* zero-extended. +*/ + asmvolatile ("msr dbgdtrtx_el0, %0" + : :"r" ((unsigned long )(unsigned char )c)); +isb (); +} + +#endif
drivers/tty/hvc/Kconfig +1 -1
@@ -81,7 +81,7 @@ config HVC_UDBG config HVC_DCC bool "ARM JTAG DCC console" - depends on ARM + depends on ARM || ARM64 select HVC_DRIVER help This console uses the JTAG DCC on ARM to create a console under the HVC
Signature · 3 lines
Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.