Skip to contentSkip to conversation

mx7dsabresd: Staticize when possible

PATCH New Fabio Estevam 2 participants 10 messages Sep 13, 2015 – Sep 20, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/5 mx7dsabresd: Staticize when possible

From: Fabio Estevam <[email protected]>

Make the internal symbols static when possible.

This prevents sparse build warnings.

---
 board/freescale/mx7dsabresd/mx7dsabresd.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
board/freescale/mx7dsabresd/mx7dsabresd.c +4 -4
index d163bee..6bd47df 100644
@@ -44,7 +44,7 @@ DECLARE_GLOBAL_DATA_PTR;
 #ifdef CONFIG_SYS_I2C_MXC
 #define PC MUX_PAD_CTRL(I2C_PAD_CTRL)
 /* I2C1 for PMIC */
-struct i2c_pads_info i2c_pad_info1 = {
+static struct i2c_pads_info i2c_pad_info1 = {
 	.scl = {
 		.i2c_mode = MX7D_PAD_I2C1_SCL__I2C1_SCL | PC,
 		.gpio_mode = MX7D_PAD_I2C1_SCL__GPIO4_IO8 | PC,
@@ -156,7 +156,7 @@ static enum qn_func qn_output[8] = {
 	qn_enable
 };
 
-void iox74lv_init(void)
+static void iox74lv_init(void)
 {
 	int i;
 
@@ -527,11 +527,11 @@ int checkboard(void)
 }
 
 #ifdef CONFIG_USB_EHCI_MX7
-iomux_v3_cfg_t const usb_otg1_pads[] = {
+static iomux_v3_cfg_t const usb_otg1_pads[] = {
 	MX7D_PAD_GPIO1_IO05__USB_OTG1_PWR | MUX_PAD_CTRL(NO_PAD_CTRL),
 };
 
-iomux_v3_cfg_t const usb_otg2_pads[] = {
+static iomux_v3_cfg_t const usb_otg2_pads[] = {
 	MX7D_PAD_UART3_CTS_B__USB_OTG2_PWR | MUX_PAD_CTRL(NO_PAD_CTRL),
 };
 
Signature · 1 line
1.9.1
#1 lore raw

PATCH 2/5 mx7dsabreasd: Remove dead code

From: Fabio Estevam <[email protected]>

iox74lv_set() is not used anywhere, so let's remove it.

---
 board/freescale/mx7dsabresd/mx7dsabresd.c | 38 -------------------------------
 1 file changed, 38 deletions(-)
board/freescale/mx7dsabresd/mx7dsabresd.c +0 -38
index 6bd47df..6c2fc98 100644
@@ -190,44 +190,6 @@ static void iox74lv_init(void)
 	gpio_direction_output(IOX_STCP, 1);
 };
 
-void iox74lv_set(int index)
-{
-	int i;
-	for (i = 7; i >= 0; i--) {
-		gpio_direction_output(IOX_SHCP, 0);
-
-		if (i == index)
-			gpio_direction_output(IOX_SDI, seq[qn_output[i]][0]);
-		else
-			gpio_direction_output(IOX_SDI, seq[qn_output[i]][1]);
-		udelay(500);
-		gpio_direction_output(IOX_SHCP, 1);
-		udelay(500);
-	}
-
-	gpio_direction_output(IOX_STCP, 0);
-	udelay(500);
-	/*
-	  * shift register will be output to pins
-	  */
-	gpio_direction_output(IOX_STCP, 1);
-
-	for (i = 7; i >= 0; i--) {
-		gpio_direction_output(IOX_SHCP, 0);
-		gpio_direction_output(IOX_SDI, seq[qn_output[i]][1]);
-		udelay(500);
-		gpio_direction_output(IOX_SHCP, 1);
-		udelay(500);
-	}
-
-	gpio_direction_output(IOX_STCP, 0);
-	udelay(500);
-	/*
-	  * shift register will be output to pins
-	  */
-	gpio_direction_output(IOX_STCP, 1);
-};
-
 #ifdef CONFIG_FEC_MXC
 static iomux_v3_cfg_t const fec1_pads[] = {
 	MX7D_PAD_ENET1_RGMII_RX_CTL__ENET1_RGMII_RX_CTL | MUX_PAD_CTRL(ENET_RX_PAD_CTRL),
Signature · 1 line
1.9.1
#2 lore raw

PATCH 2/5 mx7dsabreasd: Remove dead code

Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

iox74lv_set() is not used anywhere, so let's remove it.

---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#3 lore raw

PATCH 3/5 mx7dsabresd: Include USB header

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

Include <usb/ehci-fsl.h> in order to fix the following sparse warning:

board/freescale/mx7dsabresd/mx7dsabresd.c:538:5: warning: symbol 'board_ehci_hcd_init' was not declared. Should it be static?

---
 board/freescale/mx7dsabresd/mx7dsabresd.c | 1 +
 1 file changed, 1 insertion(+)
board/freescale/mx7dsabresd/mx7dsabresd.c +1 -0
index 6c2fc98..4c18b5a 100644
@@ -24,6 +24,7 @@
 #include <i2c.h>
 #include <asm/imx-common/mxc_i2c.h>
 #include <asm/arch/crm_regs.h>
+#include <usb/ehci-fsl.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 
Signature · 1 line
1.9.1
#4 lore raw

PATCH 3/5 mx7dsabresd: Include USB header

Quoted 8 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Include <usb/ehci-fsl.h> in order to fix the following sparse warning:

board/freescale/mx7dsabresd/mx7dsabresd.c:538:5: warning: symbol 'board_ehci_hcd_init' was not declared. Should it be static?

---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#5 lore raw

PATCH 4/5 mx7dsabresd: Remove get_board_rev()

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

get_board_rev() is not actually providing the board revision.

It just returns the CPU revision instead.

As the CPU revision is already printed on boot, there is no reason to have get_board_rev(), so let's remove it.

---
 board/freescale/mx7dsabresd/mx7dsabresd.c | 5 -----
 1 file changed, 5 deletions(-)
board/freescale/mx7dsabresd/mx7dsabresd.c +0 -5
index 4c18b5a..5c37df5 100644
@@ -477,11 +477,6 @@ int board_late_init(void)
 	return 0;
 }
 
-u32 get_board_rev(void)
-{
-	return get_cpu_rev();
-}
-
 int checkboard(void)
 {
 	puts("Board: i.MX7D SABRESD\n");
Signature · 1 line
1.9.1
#6 lore raw

PATCH 4/5 mx7dsabresd: Remove get_board_rev()

Quoted 11 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

get_board_rev() is not actually providing the board revision.

It just returns the CPU revision instead.

As the CPU revision is already printed on boot, there is no reason to have get_board_rev(), so let's remove it.

---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#7 lore raw

PATCH 5/5 mx7dsabresd: Remove unused config option

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

CONFIG_FEC_DMA_MINALIGN is not used anywhere, so let's remove it.

---
 include/configs/mx7dsabresd.h | 1 -
 1 file changed, 1 deletion(-)
include/configs/mx7dsabresd.h +0 -1
index ec6e0a6..2a736c4 100644
@@ -24,7 +24,6 @@
 
 #define CONFIG_PHYLIB
 #define CONFIG_PHY_BROADCOM
-#define CONFIG_FEC_DMA_MINALIGN		64
 /* ENET1 */
 #define IMX_FEC_BASE			ENET_IPS_BASE_ADDR
 
Signature · 1 line
1.9.1
#8 lore raw

PATCH 5/5 mx7dsabresd: Remove unused config option

Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

CONFIG_FEC_DMA_MINALIGN is not used anywhere, so let's remove it.

---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#9 lore raw

PATCH 1/5 mx7dsabresd: Staticize when possible

In reply to Fabio Estevam
Quoted 8 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Make the internal symbols static when possible.

This prevents sparse build warnings.

---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================