mtd: nand: sunxi: fix sunxi_nand_chips_cleanup()
Subsystems (4)
PATCH 1/1 mtd: nand: sunxi: fix sunxi_nand_chips_cleanup()
The sunxi_nand_chips_cleanup() function is missing a call to list_del() which generates a double free error.
--- drivers/mtd/nand/sunxi_nand.c | 1 + 1 file changed, 1 insertion(+)
drivers/mtd/nand/sunxi_nand.c +1 -0
@@ -1388,6 +1388,7 @@ static void sunxi_nand_chips_cleanup(struct sunxi_nfc *nfc) node);nand_release (&chip->mtd);sunxi_nand_ecc_cleanup (&chip->nand.ecc); +list_del (&chip->node); } }
Signature · 1 line
1.9.1
PATCH 1/1 mtd: nand: sunxi: fix sunxi_nand_chips_cleanup()
Quoted 3 lines · Boris Brezillon
The
sunxi_nand_chips_cleanup()function is missing a call tolist_del()
which generates a double free error.
Quoted 27 lines
Reported-by Priit Laes <[email protected]>Signed-off-by Boris Brezillon <[email protected]>Cc <[email protected]> # 3.19+Fixes 1fef62c1423b ("mtd: nand: add sunxi NAND flash controllersupport")
--- drivers/mtd/nand/sunxi_nand.c | 1 + 1 file changed, 1 insertion(+)drivers/mtd/nand/sunxi_nand.c +1
-0@@ -1388,6 +1388,7 @@ static void sunxi_nand_chips_cleanup(struct sunxi_nfc *nfc) node);nand_release (&chip->mtd);sunxi_nand_ecc_cleanup (&chip->nand.ecc); +list_del (&chip->node); } }Signature · 2 lines
-- 1.9.1
Brian Norris
AppliedPATCH 1/1 mtd: nand: sunxi: fix sunxi_nand_chips_cleanup()
In reply to Boris BrezillonQuoted 2 lines · Boris Brezillon
The
sunxi_nand_chips_cleanup()function is missing a call tolist_del()which generates a double free error.
And if you could manage to get past that...an infinite loop, no?
Quoted 4 lines
Reported-by Priit Laes <[email protected]>Signed-off-by Boris Brezillon <[email protected]>Cc <[email protected]> # 3.19+Fixes 1fef62c1423b ("mtd: nand: add sunxi NAND flash controller support")
Applied to linux-mtd.git, as this is a -stable fix.
Brian
PATCH 1/1 mtd: nand: sunxi: fix sunxi_nand_chips_cleanup()
Hi Brian,
Quoted 5 lines · On Mon, 21 Sep 2015 17:15:28 -0700 Brian Norris <[email protected]>…
Quoted 2 lines · Boris Brezillon
The
sunxi_nand_chips_cleanup()function is missing a call tolist_del()which generates a double free error.And if you could manage to get past that...an infinite loop, no?
Right, feel free to add it in the commit message.
Best Regards,
Boris
Signature · 3 lines
Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com