Skip to contentSkip to conversation

add python simple template module

PATCH New Steve Calfee 3 participants 6 messages Sep 13, 2015 – Sep 15, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 add python simple template module

---
 package/Config.in                            |  1 +
 package/python-pyratemp/Config.in            |  9 +++++++++
 package/python-pyratemp/python-pyratemp.hash |  4 ++++
 package/python-pyratemp/python-pyratemp.mk   | 14 ++++++++++++++
 4 files changed, 28 insertions(+)
 create mode 100644 package/python-pyratemp/Config.in
 create mode 100644 package/python-pyratemp/python-pyratemp.hash
 create mode 100644 package/python-pyratemp/python-pyratemp.mk
package/Config.in +1 -0
index 030477a..2784339 100644
@@ -643,6 +643,7 @@ menu "external python modules"
 	source "package/python-pyparsing/Config.in"
 	source "package/python-pypcap/Config.in"
 	source "package/python-pyqt/Config.in"
+	source "package/python-pyratemp/Config.in"
 	source "package/python-pyro/Config.in"
 	source "package/python-pyroute2/Config.in"
 	source "package/python-pysendfile/Config.in"
package/python-pyratemp/Config.in new file +9 -0
new file mode 100644
index 0000000..1e7309e
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_PYTHON_PYRATEMP
+	bool "python-pyratemp"
+	depends on BR2_PACKAGE_PYTHON
+	help
+	  python-pyratemp is a Python library for doing html templates.
+	  written entirely in Python, that is designed to be very easy to use
+	  and very like writing Python.
+
+	  https://pypi.python.org/pypi/pyratemp/
package/python-pyratemp/python-pyratemp.hash new file +4 -0
new file mode 100644
index 0000000..0abb9e0
@@ -0,0 +1,4 @@
+# From http://www.simple-is-better.org/template
+# Locally calculated:
+sha256 c45ed656ada482a02fe780495f37a695e7671accb04f918f7e7f18abf877bc71 pyratemp-0.3.2.tgz
+
package/python-pyratemp/python-pyratemp.mk new file +14 -0
new file mode 100644
index 0000000..4c78154
@@ -0,0 +1,14 @@
+################################################################################
+#
+# python-pyratemp
+#
+################################################################################
+
+PYTHON_PYRATEMP_VERSION = 0.3.2
+PYTHON_PYRATEMP_SOURCE = pyratemp-$(PYTHON_PYRATEMP_VERSION).tgz
+PYTHON_PYRATEMP_SITE = http://www.simple-is-better.org/template
+PYTHON_PYRATEMP_LICENSE = MIT
+PYTHON_PYRATEMP_LICENSE_FILES = LICENSE
+PYTHON_PYRATEMP_SETUP_TYPE = distutils
+
+$(eval $(python-package))
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 add python simple template module

Hi Steve,

Quoted 29 lines · Steve Calfee
---
 package/Config.in                            |  1 +
 package/python-pyratemp/Config.in            |  9 +++++++++
 package/python-pyratemp/python-pyratemp.hash |  4 ++++
 package/python-pyratemp/python-pyratemp.mk   | 14 ++++++++++++++
 4 files changed, 28 insertions(+)
 create mode 100644 package/python-pyratemp/Config.in
 create mode 100644 package/python-pyratemp/python-pyratemp.hash
 create mode 100644 package/python-pyratemp/python-pyratemp.mk
package/Config.in +1 -0
index 030477a..2784339 100644
@@ -643,6 +643,7 @@ menu "external python modules"
        source "package/python-pyparsing/Config.in"
        source "package/python-pypcap/Config.in"
        source "package/python-pyqt/Config.in"
+       source "package/python-pyratemp/Config.in"
        source "package/python-pyro/Config.in"
        source "package/python-pyroute2/Config.in"
        source "package/python-pysendfile/Config.in"
package/python-pyratemp/Config.in new file +0 -0
new file mode 100644
index 0000000..1e7309e

package/python-pyratemp/Config.in line 3

Quoted 3 lines
package/python-pyratemp/Config.in new file +3 -0
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_PYTHON_PYRATEMP
+       bool "python-pyratemp"
+       depends on BR2_PACKAGE_PYTHON

Project's website says, that this package is compatible with both Python 2 and 3, so no need to depend on BR2_PACKAGE_PYTHON. Just remove this line.

Yegor

Quoted 43 lines
package/python-pyratemp/Config.in new file +6 -0
+       help
+         python-pyratemp is a Python library for doing html templates.
+         written entirely in Python, that is designed to be very easy to use
+         and very like writing Python.
+
+         https://pypi.python.org/pypi/pyratemp/
package/python-pyratemp/python-pyratemp.hash new file +4 -0
new file mode 100644
index 0000000..0abb9e0
@@ -0,0 +1,4 @@
+# From http://www.simple-is-better.org/template
+# Locally calculated:
+sha256 c45ed656ada482a02fe780495f37a695e7671accb04f918f7e7f18abf877bc71 pyratemp-0.3.2.tgz
+
package/python-pyratemp/python-pyratemp.mk new file +14 -1
new file mode 100644
index 0000000..4c78154
@@ -0,0 +1,14 @@
+################################################################################
+#
+# python-pyratemp
+#
+################################################################################
+
+PYTHON_PYRATEMP_VERSION = 0.3.2
+PYTHON_PYRATEMP_SOURCE = pyratemp-$(PYTHON_PYRATEMP_VERSION).tgz
+PYTHON_PYRATEMP_SITE = http://www.simple-is-better.org/template
+PYTHON_PYRATEMP_LICENSE = MIT
+PYTHON_PYRATEMP_LICENSE_FILES = LICENSE
+PYTHON_PYRATEMP_SETUP_TYPE = distutils
+
+$(eval $(python-package))
--

1.9.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#2 lore raw

PATCH 1/1 add python simple template module

In reply to Steve Calfee

Dear Steve Calfee,

The title of the commit should be:

python-pyratemp: new package

package/python-pyratemp/python-pyratemp.hash line 2

Quoted 8 lines · Steve Calfee
package/python-pyratemp/python-pyratemp.hash new file +2 -0
new file mode 100644
index 0000000..0abb9e0
@@ -0,0 +1,4 @@
+# From http://www.simple-is-better.org/template
+# Locally calculated:

Having those two comments together do not make sense. Either the hash is provided by the official upstream website and you should write the first line, or the hash is not available from the upstream website, in which case you use a locally calculated hash.

package/python-pyratemp/python-pyratemp.hash line 4

Quoted 2 lines
package/python-pyratemp/python-pyratemp.hash new file +2 -0
+sha256 c45ed656ada482a02fe780495f37a695e7671accb04f918f7e7f18abf877bc71 pyratemp-0.3.2.tgz
+

Unneeded empty line.

Could you fix those minor issues, as well as Yegor's comment, and send a v2 version of this patch?

Thanks a lot!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 add python simple template module

Hi Thomas,

Quoted 23 lines · Thomas Petazzoni

Dear Steve Calfee,

The title of the commit should be:

python-pyratemp: new package

package/python-pyratemp/python-pyratemp.hash line 2

Quoted 8 lines · Steve Calfee
package/python-pyratemp/python-pyratemp.hash new file +2 -0
new file mode 100644
index 0000000..0abb9e0
@@ -0,0 +1,4 @@
+# From http://www.simple-is-better.org/template
+# Locally calculated:

Having those two comments together do not make sense. Either the hash is provided by the official upstream website and you should write the first line, or the hash is not available from the upstream website, in which case you use a locally calculated hash.

Quoted 5 lines

package/python-pyratemp/python-pyratemp.hash line 4

Quoted 2 lines
package/python-pyratemp/python-pyratemp.hash new file +2 -0
+sha256 c45ed656ada482a02fe780495f37a695e7671accb04f918f7e7f18abf877bc71 pyratemp-0.3.2.tgz
+

Unneeded empty line.

Thanks for the review.

I just rebuilt and found that the .hash file has to have an eol after that last line. So please reject the V2 version and I will send in another one tomorrow which will survive through a make clean.

Regards, Steve

#4 lore raw

PATCH 1/1 add python simple template module

Hi Steve,

Quoted 33 lines · Steve Calfee

Hi Thomas,

Quoted 23 lines · Thomas Petazzoni

Dear Steve Calfee,

The title of the commit should be:

python-pyratemp: new package

package/python-pyratemp/python-pyratemp.hash line 2

Quoted 8 lines · Steve Calfee
package/python-pyratemp/python-pyratemp.hash new file +2 -0
new file mode 100644
index 0000000..0abb9e0
@@ -0,0 +1,4 @@
+# From http://www.simple-is-better.org/template
+# Locally calculated:

Having those two comments together do not make sense. Either the hash is provided by the official upstream website and you should write the first line, or the hash is not available from the upstream website, in which case you use a locally calculated hash.

Quoted 5 lines

package/python-pyratemp/python-pyratemp.hash line 4

Quoted 2 lines
package/python-pyratemp/python-pyratemp.hash new file +2 -0
+sha256 c45ed656ada482a02fe780495f37a695e7671accb04f918f7e7f18abf877bc71 pyratemp-0.3.2.tgz
+

Unneeded empty line.

Quoted 5 lines

Thanks for the review.

I just rebuilt and found that the .hash file has to have an eol after that last line. So please reject the V2 version and I will send in another one tomorrow which will survive through a make clean.

while you are at it, please add both md5 and sha256 to the *.hash file. Your package is ony PyPi, that already provides MD5. In addition we add stronger sha256 checksum. Just take a look at tornado package:

http://git.buildroot.net/buildroot/tree/package/python-tornado/python-tornado.hash

Yegor

#5 lore raw

PATCH 1/1 add python simple template module

Hi Yegor,

Quoted 9 lines · Yegor Yefremov

Hi Steve,

Quoted 5 lines · Steve Calfee

Hi Thomas,

I just rebuilt and found that the .hash file has to have an eol after that last line. So please reject the V2 version and I will send in another one tomorrow which will survive through a make clean.

Quoted 7 lines

while you are at it, please add both md5 and sha256 to the *.hash file. Your package is ony PyPi, that already provides MD5. In addition we add stronger sha256 checksum. Just take a look at tornado package:

http://git.buildroot.net/buildroot/tree/package/python-tornado/python-tornado.hash

Yegor

This last comment about an example helped a lot. I did not realize that there was a generic download source at pypi. Much better. So I changed to that source and included the original md5 as you suggested as well as my sha256.

The other thing I did not know was how to determine PYTHON_PYRATEMP_SETUP_TYPE. I guess I stopped at the tutorial in the manual. The next section "python-package reference" helpfully told me how to determine the type.

Regards, Steve