wpa_supplicant: fix static link with readline
PATCH 1/1 wpa_supplicant: fix static link with readline
When linking statically, the order of libraries on the linker command matters, since readline depends on ncurses.
--- package/wpa_supplicant/0005-fix-readline-libs-ordering.patch | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 package/wpa_supplicant/0005-fix-readline-libs-ordering.patch
package/wpa_supplicant/0005-fix-readline-libs-ordering.patch new file +11 -0
@@ -0,0 +1,11 @@ +--- ./wpa_supplicant/Makefile ++++ ./wpa_supplicant/Makefile +@@ -1379,7 +1379,7 @@ + + ifdef CONFIG_READLINE + OBJS_c += ../src/utils/edit_readline.o +-LIBS_c += -lncurses -lreadline ++LIBS_c += -lreadline -lncurses + else + ifdef CONFIG_WPA_CLI_EDIT + OBJS_c += ../src/utils/edit.o
Signature · 1 line
1.8.3.1
PATCH 1/1 wpa_supplicant: fix static link with readline
David,
Thanks for this contribution!
package/wpa_supplicant/0005-fix-readline-libs-ordering.patch
Quoted 14 lines · David du Colombier
When linking statically, the order of libraries on the linker command matters, since readline depends on ncurses.
Signed-off-by David du Colombier <[email protected]>--- package/wpa_supplicant/0005-fix-readline-libs-ordering.patch | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 package/wpa_supplicant/0005-fix-readline-libs-ordering.patchpackage/wpa_supplicant/0005-fix-readline-libs-ordering.patch new file +0
-0
Thanks for the patch, but patches in Buildroot have to have a description and a Signed-off-by line. See
http://buildroot.uclibc.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches.
Also, could you submit this patch to upstream wpa_supplicant?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 wpa_supplicant: fix static link with readline
Thomas,
Quoted 5 lines
Thanks for the patch, but patches in Buildroot have to have a description and a Signed-off-by line. See
http://buildroot.uclibc.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches.Also, could you submit this patch to upstream
wpa_supplicant?
I've just submitted the fix to the wpa_supplicant mailing list. I will send a new version of this change, including the patch I sent.
Signature · 1 line
David du Colombier