Skip to contentSkip to conversation

reiser4: fix supported flags check in reiser4_rename2_common().

PATCH In review Ivan Shapovalov 2 participants 2 messages Sep 14, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 reiser4: fix supported flags check in reiser4_rename2_common().

---

This was left behind some time ago. I've just spotted a relevant warning.

 fs/reiser4/plugin/inode_ops_rename.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/reiser4/plugin/inode_ops_rename.c +1 -1
index 6744e14..ddb7bf5 100644
@@ -435,7 +435,7 @@ int reiser4_rename2_common(struct inode *old_dir /* directory where @old
 	 * We support:
 	 * - RENAME_NOREPLACE (no-op)
 	 */
-	if (flags & supported_flags != flags)
+	if ((flags & supported_flags) != flags)
 		return RETERR(-EINVAL);
 
 	old_entry = kzalloc(3 * sizeof(*old_entry) + 2 * sizeof(*new_lh) +
Signature · 1 line
2.5.1
#1 lore raw

OK

Quoted 20 lines · Ivan Shapovalov

---

This was left behind some time ago. I've just spotted a relevant warning.

  fs/reiser4/plugin/inode_ops_rename.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
fs/reiser4/plugin/inode_ops_rename.c +1 -1
index 6744e14..ddb7bf5 100644
@@ -435,7 +435,7 @@ int reiser4_rename2_common(struct inode *old_dir /* directory where @old
  	 * We support:
  	 * - RENAME_NOREPLACE (no-op)
  	 */
-	if (flags & supported_flags != flags)
+	if ((flags & supported_flags) != flags)
  		return RETERR(-EINVAL);
 
  	old_entry = kzalloc(3 * sizeof(*old_entry) + 2 * sizeof(*new_lh) +