lib/string_helpers.c: fix infinite loop in string_get_size()
Subsystems (2)
PATCH v2 1/1 lib/string_helpers.c: fix infinite loop in string_get_size()
Some string_get_size() calls (e.g.:
string_get_size(1, 512, STRING_UNITS_10, ..., ...) string_get_size(15, 64, STRING_UNITS_10, ..., ...)
) result in an infinite loop. The problem is that if size is equal to divisor[units]/blk_size and is smaller than divisor[units] we'll end up with size == 0 when we start doing sf_cap calculations:
For string_get_size(1, 512, STRING_UNITS_10, ..., ...) case:
...
remainder = do_div(size, divisor[units]); -> size is 0, remainder is 1 remainder *= blk_size; -> remainder is 512
...
size *= blk_size; -> size is still 0
size += remainder / divisor[units]; -> size is still 0
The caller causing the issue is sd_read_capacity(), the problem was noticed on Hyper-V, such weird size was reported by host when scanning collides with device removal. This is probably a separate issue worth fixing, this patch is intended to prevent the library routing from infinite looping.
--- lib/string_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/string_helpers.c +1 -1
@@ -59,7 +59,7 @@ void string_get_size(u64 size, u64 blk_size, const enum string_size_units units, } exp = divisor[units] / (u32 )blk_size; -if (size >= exp) { +if (size > exp) { remainder =do_div (size, divisor[units]); remainder *= blk_size; i++;
Signature · 1 line
2.4.3
Quoted 30 lines · Vitaly Kuznetsov
Some
string_get_size()calls (e.g.:
string_get_size(1, 512, STRING_UNITS_10, ..., ...)string_get_size(15, 64, STRING_UNITS_10, ..., ...)
) result in an infinite loop. The problem is that if size is equal to divisor[units]/blk_size and is smaller than divisor[units] we'll end up with size == 0 when we start doingsf_capcalculations:For
string_get_size(1, 512, STRING_UNITS_10, ..., ...)case:... remainder = do_div(size, divisor[units]); -> size is 0, remainder is 1 remainder *= blk_size; -> remainder is 512 ... size *= blk_size; -> size is still 0 size += remainder / divisor[units]; -> size is still 0The caller causing the issue is
sd_read_capacity(), the problem was noticed on Hyper-V, such weird size was reported by host when scanning collides with device removal. This is probably a separate issue worth fixing, this patch is intended to prevent the library routing from infinite looping.Signed-off-by Vitaly Kuznetsov <[email protected]>--- lib/string_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/string_helpers.c +0
-0
lib/string_helpers.c void string_get_size(u64 size, u64 blk_size, const enum string_size_units units, · line 61
Quoted 3 lines
lib/string_helpers.c +0
-0@@ -59,7 +59,7 @@ void string_get_size(u64 size, u64 blk_size, const enum string_size_units units, } exp = divisor[units] / (u32 )blk_size;
Add a comment here explaining to those who come after why strict greater than is necessary. Something like:
/* size must be strictly greater than exp here to ensure
* that remainder is greater than divisor[units] coming out of the if */
lib/string_helpers.c void string_get_size(u64 size, u64 blk_size, const enum string_size_units units, · line 65
Quoted 5 lines
lib/string_helpers.c +1
-1-if (size >= exp) { +if (size > exp) { remainder =do_div (size, divisor[units]); remainder *= blk_size; i++;
So when pushed, you finally found the algorithmic problem. Well done.
James
���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay�ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m����������?�I�