Skip to contentSkip to conversation

image.bbclass: add do_rootfs vardeps for IMAGE_{CMD, TYPEDEP}_*

PATCH In review Christopher Larson 2 participants 3 messages Sep 14, 2015 – Sep 15, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 image.bbclass: add do_rootfs vardeps for IMAGE_{CMD, TYPEDEP}_*

From: Christopher Larson <[email protected]>

We want do_rootfs to rerun if the image commands or dependencies change for any of our configured fstypes (IMGE_FSTYPES).

---
 meta/classes/image.bbclass | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)
meta/classes/image.bbclass +23 -1
index fc7d64d..d81fa27 100644
@@ -106,14 +106,36 @@ python () {
             d.setVarFlag(var, 'func', '1')
 }
 
+def fstype_variables(d):
+    fstype_vars = set()
+    fstypes = set(d.getVar('IMAGE_FSTYPES', True).split())
+    def _typedeps(fstype, seen):
+        if fstype in seen:
+            return
+
+        yield fstype
+        for typedep in (d.getVar('IMAGE_TYPEDEP_%s' % fstype, True) or "").split():
+            for _typedep in _typedeps(typedep, seen):
+                yield _typedep
+
+    seen = set()
+    for fstype in list(fstypes):
+        fstypes |= set(_typedeps(fstype, seen))
+
+    for fstype in fstypes:
+        fstype_vars.add('IMAGE_TYPEDEP_%s' % fstype)
+        fstype_vars.add('IMAGE_CMD_%s' % fstype)
+    return sorted(fstype_vars)
+
 def rootfs_variables(d):
     from oe.rootfs import variable_depends
-    variables = ['IMAGE_DEVICE_TABLES','BUILD_IMAGES_FROM_FEEDS','IMAGE_TYPEDEP_','IMAGE_TYPES_MASKED','IMAGE_ROOTFS_ALIGNMENT','IMAGE_OVERHEAD_FACTOR','IMAGE_ROOTFS_SIZE','IMAGE_ROOTFS_EXTRA_SPACE',
+    variables = ['IMAGE_DEVICE_TABLES','BUILD_IMAGES_FROM_FEEDS','IMAGE_TYPES_MASKED','IMAGE_ROOTFS_ALIGNMENT','IMAGE_OVERHEAD_FACTOR','IMAGE_ROOTFS_SIZE','IMAGE_ROOTFS_EXTRA_SPACE',
                  'IMAGE_ROOTFS_MAXSIZE','IMAGE_NAME','IMAGE_LINK_NAME','IMAGE_MANIFEST','DEPLOY_DIR_IMAGE','RM_OLD_IMAGE','IMAGE_FSTYPES','IMAGE_INSTALL_COMPLEMENTARY','IMAGE_LINGUAS','SDK_OS',
                  'SDK_OUTPUT','SDKPATHNATIVE','SDKTARGETSYSROOT','SDK_DIR','SDK_VENDOR','SDKIMAGE_INSTALL_COMPLEMENTARY','SDK_PACKAGE_ARCHS','SDK_OUTPUT','SDKTARGETSYSROOT','MULTILIBRE_ALLOW_REP',
                  'MULTILIB_TEMP_ROOTFS','MULTILIB_VARIANTS','MULTILIBS','ALL_MULTILIB_PACKAGE_ARCHS','MULTILIB_GLOBAL_VARIANTS','BAD_RECOMMENDATIONS','NO_RECOMMENDATIONS','PACKAGE_ARCHS',
                  'PACKAGE_CLASSES','TARGET_VENDOR','TARGET_VENDOR','TARGET_ARCH','TARGET_OS','OVERRIDES','BBEXTENDVARIANT','FEED_DEPLOYDIR_BASE_URI','INTERCEPT_DIR','USE_DEVFS',
                  'COMPRESSIONTYPES', 'IMAGE_GEN_DEBUGFS']
+    variables.extend(fstype_variables(d))
     variables.extend(command_variables(d))
     variables.extend(variable_depends(d))
     return " ".join(variables)
Signature · 1 line
2.2.1
#1 lore raw
Quoted 8 lines · Christopher Larson

From: Christopher Larson <[email protected]>

We want do_rootfs to rerun if the image commands or dependencies change for any of
our configured fstypes (IMGE_FSTYPES).

Hold off on accepting this, need to account compression types and COMPRESS_CMD. Expect a v2.

Signature · 5 lines
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
#2 lore raw

On Mon, Sep 14, 2015 at 4:41 PM, Christopher Larson <[email protected]

Quoted 11 lines

wrote:

Quoted 6 lines · Christopher Larson

From: Christopher Larson <[email protected]>

We want do_rootfs to rerun if the image commands or dependencies change for any of
our configured fstypes (IMGE_FSTYPES).

Quoted 5 lines
Quoted 2 lines

Hold off on accepting this, need to account compression types and COMPRESS_CMD. Expect a v2.

'[PATCH] image.bbclass: add do_rootfs vardeps for {COMPRESS,IMAGE}_CMD_*' is submitted, and supercedes this.

Signature · 5 lines
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics