Skip to contentSkip to conversation

ARM: Remove __ref on hotplug cpu die path

PATCH In review Stephen Boyd 7 participants 7 messages Sep 15, 2015 – Oct 2, 2015

Subsystems (9)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: Remove __ref on hotplug cpu die path

Now that __cpuinit has been removed, the __ref markings on these functions are useless. Remove them. This also reduces the size of the multi_v7_defconfig image:

$ size before after
   text    data     bss     dec     hex filename
   12683578        1470996  348904 14503478         dd4e36 before
   12683274        1470996  348904 14503174         dd4d06 after

presumably because now we don't have to jump to code in the .ref.text section and/or the noinline marking is removed.

Cc Tony Lindgren <[email protected]>
Cc Barry Song <[email protected]>
Cc Andy Gross <[email protected]>
Cc Viresh Kumar <[email protected]>
Cc Shiraz Hashim <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Alexandre Courbot <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Sudeep Holla <[email protected]>
Cc Lorenzo Pieralisi <[email protected]>
Cc Will Deacon <[email protected]>
Cc Mark Rutland <[email protected]>

---

This patch can be broken up into per-SoC if desired.

 arch/arm/kernel/psci_smp.c           | 4 ++--
 arch/arm/mach-omap2/omap-hotplug.c   | 2 +-
 arch/arm/mach-omap2/omap-wakeupgen.c | 2 +-
 arch/arm/mach-prima2/hotplug.c       | 2 +-
 arch/arm/mach-qcom/platsmp.c         | 2 +-
 arch/arm/mach-realview/hotplug.c     | 2 +-
 arch/arm/mach-spear/hotplug.c        | 2 +-
 arch/arm/mach-tegra/hotplug.c        | 2 +-
 arch/arm/mach-ux500/hotplug.c        | 2 +-
 arch/arm/mach-vexpress/hotplug.c     | 2 +-
 10 files changed, 11 insertions(+), 11 deletions(-)
arch/arm/kernel/psci_smp.c +2 -2
index 61c04b02faeb..9d479b2ea40d 100644
@@ -71,7 +71,7 @@ int psci_cpu_disable(unsigned int cpu)
 	return 0;
 }
 
-void __ref psci_cpu_die(unsigned int cpu)
+void psci_cpu_die(unsigned int cpu)
 {
 	u32 state = PSCI_POWER_STATE_TYPE_POWER_DOWN <<
 		    PSCI_0_2_POWER_STATE_TYPE_SHIFT;
@@ -83,7 +83,7 @@ void __ref psci_cpu_die(unsigned int cpu)
 	panic("psci: cpu %d failed to shutdown\n", cpu);
 }
 
-int __ref psci_cpu_kill(unsigned int cpu)
+int psci_cpu_kill(unsigned int cpu)
 {
 	int err, i;
 
arch/arm/mach-omap2/omap-hotplug.c +1 -1
index 971791fe9a3f..593fec753b28 100644
@@ -27,7 +27,7 @@
  * platform-specific code to shutdown a CPU
  * Called with IRQs disabled
  */
-void __ref omap4_cpu_die(unsigned int cpu)
+void omap4_cpu_die(unsigned int cpu)
 {
 	unsigned int boot_cpu = 0;
 	void __iomem *base = omap_get_wakeupgen_base();
arch/arm/mach-omap2/omap-wakeupgen.c +1 -1
index e1d2e991d17a..d9b317706e63 100644
@@ -330,7 +330,7 @@ static int irq_cpu_hotplug_notify(struct notifier_block *self,
 	return NOTIFY_OK;
 }
 
-static struct notifier_block __refdata irq_hotplug_notifier = {
+static struct notifier_block irq_hotplug_notifier = {
 	.notifier_call = irq_cpu_hotplug_notify,
 };
 
arch/arm/mach-prima2/hotplug.c +1 -1
index 0ab2f8bae28e..a728c78b996f 100644
@@ -32,7 +32,7 @@ static inline void platform_do_lowpower(unsigned int cpu)
  *
  * Called with IRQs disabled
  */
-void __ref sirfsoc_cpu_die(unsigned int cpu)
+void sirfsoc_cpu_die(unsigned int cpu)
 {
 	platform_do_lowpower(cpu);
 }
arch/arm/mach-qcom/platsmp.c +1 -1
index 5cde63a64b34..9b00123a315d 100644
@@ -49,7 +49,7 @@ extern void secondary_startup_arm(void);
 static DEFINE_SPINLOCK(boot_lock);
 
 #ifdef CONFIG_HOTPLUG_CPU
-static void __ref qcom_cpu_die(unsigned int cpu)
+static void qcom_cpu_die(unsigned int cpu)
 {
 	wfi();
 }
arch/arm/mach-realview/hotplug.c +1 -1
index ac22dd41b135..968e2d1964f6 100644
@@ -90,7 +90,7 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious)
  *
  * Called with IRQs disabled
  */
-void __ref realview_cpu_die(unsigned int cpu)
+void realview_cpu_die(unsigned int cpu)
 {
 	int spurious = 0;
 
arch/arm/mach-spear/hotplug.c +1 -1
index d97749c642ce..12edd1cf8a12 100644
@@ -80,7 +80,7 @@ static inline void spear13xx_do_lowpower(unsigned int cpu, int *spurious)
  *
  * Called with IRQs disabled
  */
-void __ref spear13xx_cpu_die(unsigned int cpu)
+void spear13xx_cpu_die(unsigned int cpu)
 {
 	int spurious = 0;
 
arch/arm/mach-tegra/hotplug.c +1 -1
index 6fc71f1534b0..1b129899a277 100644
@@ -37,7 +37,7 @@ int tegra_cpu_kill(unsigned cpu)
  *
  * Called with IRQs disabled
  */
-void __ref tegra_cpu_die(unsigned int cpu)
+void tegra_cpu_die(unsigned int cpu)
 {
 	if (!tegra_hotplug_shutdown) {
 		WARN(1, "hotplug is not yet initialized\n");
arch/arm/mach-ux500/hotplug.c +1 -1
index 2bc00b085e38..1cbed0331fd3 100644
@@ -21,7 +21,7 @@
  *
  * Called with IRQs disabled
  */
-void __ref ux500_cpu_die(unsigned int cpu)
+void ux500_cpu_die(unsigned int cpu)
 {
 	/* directly enter low power state, skipping secure registers */
 	for (;;) {
arch/arm/mach-vexpress/hotplug.c +1 -1
index f0ce6b8f5e71..f2fafc10a91d 100644
@@ -85,7 +85,7 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious)
  *
  * Called with IRQs disabled
  */
-void __ref vexpress_cpu_die(unsigned int cpu)
+void vexpress_cpu_die(unsigned int cpu)
 {
 	int spurious = 0;
 
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
Acked-by on v1 1/1
#1 lore raw
Quoted 30 lines · Stephen Boyd

Now that __cpuinit has been removed, the __ref markings on these functions are useless. Remove them. This also reduces the size of the multi_v7_defconfig image:

$ size before after
   text    data     bss     dec     hex filename
   12683578        1470996  348904 14503478         dd4e36 before
   12683274        1470996  348904 14503174         dd4d06 after

presumably because now we don't have to jump to code in the .ref.text section and/or the noinline marking is removed.

Cc Tony Lindgren <[email protected]>
Cc Barry Song <[email protected]>
Cc Andy Gross <[email protected]>
Cc Viresh Kumar <[email protected]>
Cc Shiraz Hashim <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Alexandre Courbot <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Sudeep Holla <[email protected]>
Cc Lorenzo Pieralisi <[email protected]>
Cc Will Deacon <[email protected]>
Cc Mark Rutland <[email protected]>
Quoted 5 lines

---

This patch can be broken up into per-SoC if desired.

 arch/arm/mach-spear/hotplug.c        | 2 +-
Signature · 1 line
viresh
Acked-by on v1 1/1
#2 lore raw
In reply to Stephen Boyd

2015-09-15 8:23 GMT+08:00 Stephen Boyd <[email protected]>:

Quoted 22 lines

Now that __cpuinit has been removed, the __ref markings on these functions are useless. Remove them. This also reduces the size of the multi_v7_defconfig image:

$ size before after
   text    data     bss     dec     hex filename
   12683578        1470996  348904 14503478         dd4e36 before
   12683274        1470996  348904 14503174         dd4d06 after

presumably because now we don't have to jump to code in the .ref.text section and/or the noinline marking is removed.

Cc Tony Lindgren <[email protected]>
Cc Barry Song <[email protected]>
Cc Andy Gross <[email protected]>
Cc Viresh Kumar <[email protected]>
Cc Shiraz Hashim <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Alexandre Courbot <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Sudeep Holla <[email protected]>
Quoted 8 lines
Quoted 159 lines

---

This patch can be broken up into per-SoC if desired.

 arch/arm/kernel/psci_smp.c           | 4 ++--
 arch/arm/mach-omap2/omap-hotplug.c   | 2 +-
 arch/arm/mach-omap2/omap-wakeupgen.c | 2 +-
 arch/arm/mach-prima2/hotplug.c       | 2 +-
 arch/arm/mach-qcom/platsmp.c         | 2 +-
 arch/arm/mach-realview/hotplug.c     | 2 +-
 arch/arm/mach-spear/hotplug.c        | 2 +-
 arch/arm/mach-tegra/hotplug.c        | 2 +-
 arch/arm/mach-ux500/hotplug.c        | 2 +-
 arch/arm/mach-vexpress/hotplug.c     | 2 +-
 10 files changed, 11 insertions(+), 11 deletions(-)
arch/arm/kernel/psci_smp.c +2 -2
index 61c04b02faeb..9d479b2ea40d 100644
@@ -71,7 +71,7 @@ int psci_cpu_disable(unsigned int cpu)
        return 0;
 }
 
-void __ref psci_cpu_die(unsigned int cpu)
+void psci_cpu_die(unsigned int cpu)
 {
        u32 state = PSCI_POWER_STATE_TYPE_POWER_DOWN <<
                    PSCI_0_2_POWER_STATE_TYPE_SHIFT;
@@ -83,7 +83,7 @@ void __ref psci_cpu_die(unsigned int cpu)
        panic("psci: cpu %d failed to shutdown\n", cpu);
 }
 
-int __ref psci_cpu_kill(unsigned int cpu)
+int psci_cpu_kill(unsigned int cpu)
 {
        int err, i;
 
arch/arm/mach-omap2/omap-hotplug.c +1 -1
index 971791fe9a3f..593fec753b28 100644
@@ -27,7 +27,7 @@
  * platform-specific code to shutdown a CPU
  * Called with IRQs disabled
  */
-void __ref omap4_cpu_die(unsigned int cpu)
+void omap4_cpu_die(unsigned int cpu)
 {
        unsigned int boot_cpu = 0;
        void __iomem *base = omap_get_wakeupgen_base();
arch/arm/mach-omap2/omap-wakeupgen.c +1 -1
index e1d2e991d17a..d9b317706e63 100644
@@ -330,7 +330,7 @@ static int irq_cpu_hotplug_notify(struct notifier_block *self,
        return NOTIFY_OK;
 }
 
-static struct notifier_block __refdata irq_hotplug_notifier = {
+static struct notifier_block irq_hotplug_notifier = {
        .notifier_call = irq_cpu_hotplug_notify,
 };
 
arch/arm/mach-prima2/hotplug.c +1 -1
index 0ab2f8bae28e..a728c78b996f 100644
@@ -32,7 +32,7 @@ static inline void platform_do_lowpower(unsigned int cpu)
  *
  * Called with IRQs disabled
  */
-void __ref sirfsoc_cpu_die(unsigned int cpu)
+void sirfsoc_cpu_die(unsigned int cpu)
 {
        platform_do_lowpower(cpu);
 }
arch/arm/mach-qcom/platsmp.c +1 -1
index 5cde63a64b34..9b00123a315d 100644
@@ -49,7 +49,7 @@ extern void secondary_startup_arm(void);
 static DEFINE_SPINLOCK(boot_lock);
 
 #ifdef CONFIG_HOTPLUG_CPU
-static void __ref qcom_cpu_die(unsigned int cpu)
+static void qcom_cpu_die(unsigned int cpu)
 {
        wfi();
 }
arch/arm/mach-realview/hotplug.c +1 -1
index ac22dd41b135..968e2d1964f6 100644
@@ -90,7 +90,7 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious)
  *
  * Called with IRQs disabled
  */
-void __ref realview_cpu_die(unsigned int cpu)
+void realview_cpu_die(unsigned int cpu)
 {
        int spurious = 0;
 
arch/arm/mach-spear/hotplug.c +1 -1
index d97749c642ce..12edd1cf8a12 100644
@@ -80,7 +80,7 @@ static inline void spear13xx_do_lowpower(unsigned int cpu, int *spurious)
  *
  * Called with IRQs disabled
  */
-void __ref spear13xx_cpu_die(unsigned int cpu)
+void spear13xx_cpu_die(unsigned int cpu)
 {
        int spurious = 0;
 
arch/arm/mach-tegra/hotplug.c +1 -1
index 6fc71f1534b0..1b129899a277 100644
@@ -37,7 +37,7 @@ int tegra_cpu_kill(unsigned cpu)
  *
  * Called with IRQs disabled
  */
-void __ref tegra_cpu_die(unsigned int cpu)
+void tegra_cpu_die(unsigned int cpu)
 {
        if (!tegra_hotplug_shutdown) {
                WARN(1, "hotplug is not yet initialized\n");
arch/arm/mach-ux500/hotplug.c +1 -1
index 2bc00b085e38..1cbed0331fd3 100644
@@ -21,7 +21,7 @@
  *
  * Called with IRQs disabled
  */
-void __ref ux500_cpu_die(unsigned int cpu)
+void ux500_cpu_die(unsigned int cpu)
 {
        /* directly enter low power state, skipping secure registers */
        for (;;) {
arch/arm/mach-vexpress/hotplug.c +1 -2
index f0ce6b8f5e71..f2fafc10a91d 100644
@@ -85,7 +85,7 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious)
  *
  * Called with IRQs disabled
  */
-void __ref vexpress_cpu_die(unsigned int cpu)
+void vexpress_cpu_die(unsigned int cpu)
 {
        int spurious = 0;
 
--

The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

Acked-by on v1 1/1
#3 lore raw
In reply to Stephen Boyd

On Mon, Sep 14, 2015 at 05:23:17PM -0700, Stephen Boyd wrote:
[...]

Quoted 1 line
 arch/arm/mach-tegra/hotplug.c        | 2 +-

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150915/135d9671/attachment-0001.sig>

Acked-by on v1 1/1
#4 lore raw
In reply to Stephen Boyd
Quoted 34 lines · Stephen Boyd

Now that __cpuinit has been removed, the __ref markings on these functions are useless. Remove them. This also reduces the size of the multi_v7_defconfig image:

$ size before after
    text    data     bss     dec     hex filename
    12683578        1470996  348904 14503478         dd4e36 before
    12683274        1470996  348904 14503174         dd4d06 after

presumably because now we don't have to jump to code in the .ref.text section and/or the noinline marking is removed.

Cc Tony Lindgren <[email protected]>
Cc Barry Song <[email protected]>
Cc Andy Gross <[email protected]>
Cc Viresh Kumar <[email protected]>
Cc Shiraz Hashim <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Alexandre Courbot <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Sudeep Holla <[email protected]>
Cc Lorenzo Pieralisi <[email protected]>
Cc Will Deacon <[email protected]>
Cc Mark Rutland <[email protected]>

---

This patch can be broken up into per-SoC if desired.

[...]

Quoted 1 line
  arch/arm/mach-vexpress/hotplug.c     | 2 +-

Regards,

Acked-by on v1 1/1
#5 lore raw
In reply to Stephen Boyd
Quoted 11 lines · Stephen Boyd

Now that __cpuinit has been removed, the __ref markings on these functions are useless. Remove them. This also reduces the size of the multi_v7_defconfig image:

$ size before after
   text    data     bss     dec     hex filename
   12683578        1470996  348904 14503478         dd4e36 before
   12683274        1470996  348904 14503174         dd4d06 after

presumably because now we don't have to jump to code in the .ref.text section and/or the noinline marking is removed.

<snip>

Signature · 3 lines
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
Acked-by on v1 1/1
#6 lore raw
In reply to Stephen Boyd
Quoted 22 lines · Stephen Boyd

Now that __cpuinit has been removed, the __ref markings on these functions are useless. Remove them. This also reduces the size of the multi_v7_defconfig image:

$ size before after
   text    data     bss     dec     hex filename
   12683578        1470996  348904 14503478         dd4e36 before
   12683274        1470996  348904 14503174         dd4d06 after

presumably because now we don't have to jump to code in the .ref.text section and/or the noinline marking is removed.

Cc Tony Lindgren <[email protected]>
Cc Barry Song <[email protected]>
Cc Andy Gross <[email protected]>
Cc Viresh Kumar <[email protected]>
Cc Shiraz Hashim <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Alexandre Courbot <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Sudeep Holla <[email protected]>
Quoted 8 lines

Yours,
Linus Walleij