Skip to contentSkip to conversation

arm64: dts: fsl-ls2085a: Add serial aliases

PATCH New Scott Wood 3 participants 5 messages Sep 15, 2015

Subsystems (2)
lore
Share & tools
lore

Scott Wood

author
#0 lore raw

PATCH 1/1 arm64: dts: fsl-ls2085a: Add serial aliases

These will allow U-Boot to set linux,stdout-path in /chosen based on the active console device, which will allow devicetree-based earlycon.

---
 arch/arm64/boot/dts/freescale/fsl-ls2085a.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm64/boot/dts/freescale/fsl-ls2085a.dtsi +5 -0
index e281ceb..eae454e 100644
@@ -55,6 +55,11 @@
 	#address-cells = <2>;
 	#size-cells = <2>;
 
+	aliases {
+		serial0 = &serial0;
+		serial1 = &serial1;
+	};
+
 	cpus {
 		#address-cells = <2>;
 		#size-cells = <0>;
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 arm64: dts: fsl-ls2085a: Add serial aliases

Quoted 20 lines

From: linuxppc-release-bounces at linux.freescale.net [mailto:linuxppc- release-bounces at linux.freescale.net] On Behalf Of Scott Wood
Sent: Tuesday, September 15, 2015 6:18 AM

These will allow U-Boot to set linux,stdout-path in /chosen based on the active console device, which will allow devicetree-based earlycon.

---
 arch/arm64/boot/dts/freescale/fsl-ls2085a.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm64/boot/dts/freescale/fsl-ls2085a.dtsi +0 -0
index e281ceb..eae454e 100644
@@ -55,6 +55,11 @@
 	#address-cells = <2>;
 	#size-cells = <2>;

arch/arm64/boot/dts/freescale/fsl-ls2085a.dtsi

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-ls2085a.dtsi +5 -1
 
+	aliases {
+		serial0 = &serial0;
+		serial1 = &serial1;
+	};
+
 	cpus {
 		#address-cells = <2>;
 		#size-cells = <0>;
--

Rebase this to my LS2080A v2 DTS sent some time ago, as LS2085A is now renamed to LS2080A.

Regards,
Bhupesh

author
#2 lore raw

PATCH 1/1 arm64: dts: fsl-ls2085a: Add serial aliases

Quoted 21 lines · On Tue, 2015-09-15 at 00:57 -0500, Sharma Bhupesh-B45370 wrote:
Quoted 21 lines

From: linuxppc-release-bounces at linux.freescale.net[mailto:linuxppc- release-bounces at linux.freescale.net] On Behalf Of Scott Wood
Sent: Tuesday, September 15, 2015 6:18 AM

These will allow U-Boot to set linux,stdout-path in /chosen based on the active console device, which will allow devicetree-based earlycon.

---
 arch/arm64/boot/dts/freescale/fsl-ls2085a.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm64/boot/dts/freescale/fsl-ls2085a.dtsi +0 -0
index e281ceb..eae454e 100644
@@ -55,6 +55,11 @@
    #address-cells = <2>;
    #size-cells = <2>;
 
Quoted 12 lines

arch/arm64/boot/dts/freescale/fsl-ls2085a.dtsi

Quoted 9 lines
arch/arm64/boot/dts/freescale/fsl-ls2085a.dtsi +5 -1
+   aliases {
+           serial0 = &serial0;
+           serial1 = &serial1;
+   };
+
    cpus {
            #address-cells = <2>;
            #size-cells = <0>;
--

Rebase this to my LS2080A v2 DTS sent some time ago, as LS2085A is now renamed to LS2080A.

Patchwork link?
How long ago? When is it going to be merged?

-Scott

#3 lore raw

PATCH 1/1 arm64: dts: fsl-ls2085a: Add serial aliases

In reply to Scott Wood
Quoted 13 lines · On Monday 14 September 2015 19:48:27 Scott Wood wrote:

These will allow U-Boot to set linux,stdout-path in /chosen based on the active console device, which will allow devicetree-based earlycon.

---
 arch/arm64/boot/dts/freescale/fsl-ls2085a.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm64/boot/dts/freescale/fsl-ls2085a.dtsi +0 -0
index e281ceb..eae454e 100644

arch/arm64/boot/dts/freescale/fsl-ls2085a.dtsi line 62

Quoted 8 lines
arch/arm64/boot/dts/freescale/fsl-ls2085a.dtsi +5 -0
@@ -55,6 +55,11 @@
        #address-cells = <2>;
        #size-cells = <2>;
 
+       aliases {
+               serial0 = &serial0;
+               serial1 = &serial1;
+       };
+

I normally ask people to put the aliases into the board specific dts file, to account for machines that do not have all the uarts, or that number them differently from the SoC.

I didn't know about U-Boot setting the stdout-path property, but that's great, as long as U-Boot uses the same numbering of the uarts that the board uses. Do you know if that is normally the case?

Arnd

author
#4 lore raw

PATCH 1/1 arm64: dts: fsl-ls2085a: Add serial aliases

Quoted 18 lines · Arnd Bergmann
Quoted 17 lines · On Monday 14 September 2015 19:48:27 Scott Wood wrote:

These will allow U-Boot to set linux,stdout-path in /chosen based on the active console device, which will allow devicetree-based earlycon.

---
 arch/arm64/boot/dts/freescale/fsl-ls2085a.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm64/boot/dts/freescale/fsl-ls2085a.dtsi +0 -0
index e281ceb..eae454e 100644
@@ -55,6 +55,11 @@
        #address-cells = <2>;
        #size-cells = <2>;
 
Quoted 9 lines

arch/arm64/boot/dts/freescale/fsl-ls2085a.dtsi line 62

Quoted 5 lines
arch/arm64/boot/dts/freescale/fsl-ls2085a.dtsi +5 -0
+       aliases {
+               serial0 = &serial0;
+               serial1 = &serial1;
+       };
+

I normally ask people to put the aliases into the board specific dts file, to account for machines that do not have all the uarts, or that number them differently from the SoC.

OK, I'll respin on top of https://patchwork.kernel.org/patch/7120211/

Quoted 3 lines

I didn't know about U-Boot setting the stdout-path property, but that's great, as long as U-Boot uses the same numbering of the uarts that the board uses. Do you know if that is normally the case?

Yes, the numbering of the serial aliases in the dts should match the numbering that U-Boot uses.

-Scott