Skip to contentSkip to conversation

fsl: Add binding for RCPM

PATCH Superseded Dongsheng Wang 3 participants 13 messages Sep 15, 2015 – Sep 16, 2015

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 fsl: Add binding for RCPM

From: Wang Dongsheng <[email protected]>

RCPM is the Run Control and Power Management module performs all device-level tasks associated with device run control and power management.

Add this for freescale powerpc platform and layerscape platform.

---
*v2*
- Remove P4080 example.
- Modify rcpm-wakeup property description.

Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +60 -0
new file mode 100644
index 0000000..ea24d76
@@ -0,0 +1,60 @@
+* Run Control and Power Management
+-------------------------------------------
+The RCPM performs all device-level tasks associated with device run control
+and power management.
+
+Required properites:
+  - reg : Offset and length of the register set of RCPM block.
+  - compatible : Sould contain a chip-specific RCPM block compatible string
+	and (if applicable) may contain a chassis-version RCPM compatible string.
+	Chip-specific strings are of the form "fsl,<chip>-rcpm", such as:
+	* "fsl,p2041-rcpm"
+	* "fsl,p3041-rcpm"
+	* "fsl,p4080-rcpm"
+	* "fsl,p5020-rcpm"
+	* "fsl,p5040-rcpm"
+	* "fsl,t4240-rcpm"
+	* "fsl,b4420-rcpm"
+	* "fsl,b4860-rcpm"
+
+	Chassis-version strings are of the form "fsl,qoriq-rcpm-<version>",
+	such as:
+	* "fsl,qoriq-rcpm-1.0": for chassis 1.0 rcpm
+	* "fsl,qoriq-rcpm-2.0": for chassis 2.0 rcpm
+	* "fsl,qoriq-rcpm-2.1": for chassis 2.1 rcpm
+
+All references to "1.0" and "2.0" refer to the QorIQ chassis version to
+which the chip complies.
+Chassis Version		Example Chips
+---------------		-------------------------------
+1.0				p4080, p5020, p5040, p2041, p3041
+2.0				t4240, b4860, b4420
+2.1				t1040, ls1021
+
+Example:
+The RCPM node for T4240:
+	rcpm: global-utilities at e2000 {
+		compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0";
+		reg = <0xe2000 0x1000>;
+	};
+
+* Freescale RCPM Wakeup Source Device Tree Bindings
+-------------------------------------------
+Required rcpm-wakeup property should be added to a device node if the device
+can be used as a wakeup source.
+
+  - rcpm-wakeup: The value of the property consists of 3 cells. The first cell
+	is a pointer to the rcpm node, the second cell is the bit mask that
+	should be set in IPPDEXPCR0, and the last cell is for IPPDEXPCR1.
+	Note: If the platform has no IPPDEXPCR1 register, put a zero here.
+
+Example:
+	lpuart0: serial at 2950000 {
+		compatible = "fsl,ls1021a-lpuart";
+		reg = <0x0 0x2950000 0x0 0x1000>;
+		interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&sysclk>;
+		clock-names = "ipg";
+		rcpm-wakeup = <&rcpm 0x0 0x40000000>;
+		status = "disabled";
+	};
Signature · 1 line
2.1.0.27.g96db324
#1 lore raw

PATCH v2 2/2 arm/layerscape: add RCPM device tree support for ls1021a.

From: Wang Dongsheng <[email protected]>

---
*v2*: No changes.

arch/arm/boot/dts/ls1021a.dtsi +7 -0
index 973a496..deb1271 100644
@@ -139,6 +139,7 @@
 			sdhci,auto-cmd12;
 			big-endian;
 			bus-width = <4>;
+			rcpm-wakeup = <&rcpm 0x00000080 0x0>;
 			status = "disabled";
 		};
 
@@ -186,6 +187,11 @@
 			};
 		};
 
+		rcpm: rcpm at 1ee2000 {
+			compatible = "fsl,ls1021a-rcpm", "fsl,qoriq-rcpm-2.1";
+			reg = <0x0 0x1ee2000 0x0 0x10000>;
+		};
+
 		dspi0: dspi at 2100000 {
 			compatible = "fsl,ls1021a-v1.0-dspi";
 			#address-cells = <1>;
@@ -287,6 +293,7 @@
 			interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&sysclk>;
 			clock-names = "ipg";
+			rcpm-wakeup = <&rcpm 0x0 0x40000000>;
 			status = "disabled";
 		};
 
Signature · 1 line
2.1.0.27.g96db324
#2 lore raw

PATCH v2 1/2 fsl: Add binding for RCPM

In reply to Dongsheng Wang

Documentation/devicetree/bindings/soc/fsl/rcpm.txt line 49

Quoted 11 lines · Dongsheng Wang
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +3 -0
+* Freescale RCPM Wakeup Source Device Tree Bindings
+-------------------------------------------
+Required rcpm-wakeup property should be added to a device node if the 

device

Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +3 -0
+can be used as a wakeup source.
+
+  - rcpm-wakeup: The value of the property consists of 3 cells. The first 

cell

Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +3 -0
+     is a pointer to the rcpm node, the second cell is the bit mask that
+     should be set in IPPDEXPCR0, and the last cell is for IPPDEXPCR1.
+     Note: If the platform has no IPPDEXPCR1 register, put a zero here.

What if a future platform has more than two of these registers?

-Scott

#3 lore raw

PATCH v2 1/2 fsl: Add binding for RCPM

Hi Scott,

Quoted 10 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 7:57 AM
To: Wang Dongsheng-B40534
Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan-B18965; Jin Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote:

Quoted 13 lines

Documentation/devicetree/bindings/soc/fsl/rcpm.txt line 49

Quoted 11 lines
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +3 -0
+* Freescale RCPM Wakeup Source Device Tree Bindings
+-------------------------------------------
+Required rcpm-wakeup property should be added to a device node if the

device

Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +3 -0
+can be used as a wakeup source.
+
+  - rcpm-wakeup: The value of the property consists of 3 cells. The first

cell

Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +3 -0
+     is a pointer to the rcpm node, the second cell is the bit mask that
+     should be set in IPPDEXPCR0, and the last cell is for IPPDEXPCR1.
+     Note: If the platform has no IPPDEXPCR1 register, put a zero here.

What if a future platform has more than two of these registers?

Those registers are only used for wakeup device, we have a lot of available bit for feature. For example, In LS1021a platform only 7bits has used in the registers, and 57bits is reserved.

Regards,
-Dongsheng

#4 lore raw

PATCH v2 1/2 fsl: Add binding for RCPM

Quoted 29 lines · On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote:

Hi Scott,

Quoted 11 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 7:57 AM
To: Wang Dongsheng-B40534
Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan- B18965; Jin
Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

On Tue, 2015-09-15 at 16:55 +0800, Dongsheng Wang wrote:

Quoted 15 lines

Documentation/devicetree/bindings/soc/fsl/rcpm.txt line 49

Quoted 13 lines
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +3 -0
+* Freescale RCPM Wakeup Source Device Tree Bindings
+-------------------------------------------
+Required rcpm-wakeup property should be added to a device node if the

device

Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +3 -0
+can be used as a wakeup source.
+
+  - rcpm-wakeup: The value of the property consists of 3 cells. The 

first
cell
+ is a pointer to the rcpm node, the second cell is the bit mask
that

Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +2 -0
+     should be set in IPPDEXPCR0, and the last cell is for IPPDEXPCR1.
+     Note: If the platform has no IPPDEXPCR1 register, put a zero here.

What if a future platform has more than two of these registers?

Quoted 5 lines

Those registers are only used for wakeup device, we have a lot of available bit
for feature. For example, In LS1021a platform only 7bits has used in the registers,
and 57bits is reserved.

Still, it'd be better to for the rcpm node to advertise the number of cells it expects.

-Scott

#5 lore raw

PATCH v2 1/2 fsl: Add binding for RCPM

Hi Scott,

Quoted 42 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 10:19 AM
To: Wang Dongsheng-B40534
Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan-B18965; Jin Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 32 lines · On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote:

Hi Scott,

Quoted 29 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 7:57 AM
To: Wang Dongsheng-B40534
Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan- B18965; Jin
Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 14 lines · Dongsheng Wang
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +4 -0
+* Freescale RCPM Wakeup Source Device Tree Bindings
+-------------------------------------------
+Required rcpm-wakeup property should be added to a device node if
+the

device

Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +4 -0
+can be used as a wakeup source.
+
+  - rcpm-wakeup: The value of the property consists of 3 cells.
+ The

first
cell
+ is a pointer to the rcpm node, the second cell is the bit
+ mask
that

Documentation/devicetree/bindings/soc/fsl/rcpm.txt line 49

Quoted 2 lines
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +2 -0
+     should be set in IPPDEXPCR0, and the last cell is for IPPDEXPCR1.
+     Note: If the platform has no IPPDEXPCR1 register, put a zero here.

What if a future platform has more than two of these registers?

Quoted 6 lines
Quoted 3 lines

Those registers are only used for wakeup device, we have a lot of available bit for feature. For example, In LS1021a platform only 7bits has used in the registers, and 57bits is reserved.

Still, it'd be better to for the rcpm node to advertise the number of cells it expects.

For the foreseeable future it should be enough to use, even if not enough to use in the future at that time we can update the binding.

Regards,
-Dongsheng

#6 lore raw

PATCH v2 1/2 fsl: Add binding for RCPM

Quoted 51 lines · On Tue, 2015-09-15 at 21:30 -0500, Wang Dongsheng-B40534 wrote:

Hi Scott,

Quoted 49 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 10:19 AM
To: Wang Dongsheng-B40534
Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan- B18965; Jin
Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 37 lines · On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote:

Hi Scott,

Quoted 23 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 7:57 AM
To: Wang Dongsheng-B40534
Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan- B18965; Jin
Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 12 lines · Dongsheng Wang
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +4 -0
+* Freescale RCPM Wakeup Source Device Tree Bindings
+-------------------------------------------
+Required rcpm-wakeup property should be added to a device node if
+the

device

Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +4 -0
+can be used as a wakeup source.
+
+  - rcpm-wakeup: The value of the property consists of 3 cells.
+ The

first
cell
+ is a pointer to the rcpm node, the second cell is the bit

Quoted 8 lines
Quoted 6 lines

+ mask
that
+ should be set in IPPDEXPCR0, and the last cell is for
IPPDEXPCR1.
+ Note: If the platform has no IPPDEXPCR1 register, put a zero
here.

What if a future platform has more than two of these registers?

Those registers are only used for wakeup device, we have a lot of available bit for feature. For example, In LS1021a platform only 7bits has used in the registers, and 57bits is reserved.

Quoted 7 lines
Quoted 3 lines

Still, it'd be better to for the rcpm node to advertise the number of cells it
expects.

For the foreseeable future it should be enough to use, even if not enough to use in
the future at that time we can update the binding.

That's the whole point. Device tree is stable ABI. Updating it later to not be fixed to two cells would be a lot harder than getting it right from the beginning. Putting the number of cells in the phandle target is a standard device tree idiom.

-Scott

#7 lore raw

PATCH v2 1/2 fsl: Add binding for RCPM

Quoted 71 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 10:32 AM
To: Wang Dongsheng-B40534 <[email protected]>
Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan- B18965 <[email protected]>; Jin Zhengxiong-R64188 <[email protected]>; Zhao Chenhui-B35336 <[email protected]>; Tang Yuantian-B29983 <[email protected]>
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 56 lines · On Tue, 2015-09-15 at 21:30 -0500, Wang Dongsheng-B40534 wrote:

Hi Scott,

Quoted 53 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 10:19 AM
To: Wang Dongsheng-B40534
Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan- B18965; Jin
Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 36 lines · On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote:

Hi Scott,

Quoted 25 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 7:57 AM
To: Wang Dongsheng-B40534
Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang robh+Huan-
B18965; Jin
Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 13 lines · Dongsheng Wang
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +4 -0
+* Freescale RCPM Wakeup Source Device Tree Bindings
+-------------------------------------------
+Required rcpm-wakeup property should be added to a device
+node if the

device

Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +4 -0
+can be used as a wakeup source.
+
+  - rcpm-wakeup: The value of the property consists of 3 cells.
+ The

first
cell
+ is a pointer to the rcpm node, the second cell is the
+ bit mask

Quoted 8 lines
Quoted 6 lines

that
+ should be set in IPPDEXPCR0, and the last cell is for
IPPDEXPCR1.
+ Note: If the platform has no IPPDEXPCR1 register, put a
+ zero
here.

What if a future platform has more than two of these registers?

Quoted 3 lines

Those registers are only used for wakeup device, we have a lot of available bit for feature. For example, In LS1021a platform only 7bits has used in the registers, and 57bits is reserved.

Still, it'd be better to for the rcpm node to advertise the number of cells it expects.

Quoted 8 lines
Quoted 2 lines

For the foreseeable future it should be enough to use, even if not enough to use in the future at that time we can update the binding.

That's the whole point. Device tree is stable ABI. Updating it later to not be fixed to two cells would be a lot harder than getting it right from the beginning. Putting the number of cells in the phandle target is a standard device tree idiom.

I agree with you. But what's the point a SOC has more than 64 wakeup source?

Regards,
Yuantian

Quoted 1 line

-Scott

#8 lore raw

PATCH v2 1/2 fsl: Add binding for RCPM

Quoted 73 lines · On Tue, 2015-09-15 at 21:35 -0500, Tang Yuantian-B29983 wrote:
Quoted 73 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 10:32 AM
To: Wang Dongsheng-B40534 <[email protected]>
Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan- B18965 <[email protected]>; Jin Zhengxiong-R64188 <[email protected]>; Zhao Chenhui-B35336 <[email protected]>; Tang Yuantian-B29983 <[email protected]>
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 58 lines · On Tue, 2015-09-15 at 21:30 -0500, Wang Dongsheng-B40534 wrote:

Hi Scott,

Quoted 47 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 10:19 AM
To: Wang Dongsheng-B40534
Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan- B18965; Jin
Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 36 lines · On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote:

Hi Scott,

Quoted 33 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 7:57 AM
To: Wang Dongsheng-B40534
Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang robh+Huan-
B18965; Jin
Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 11 lines · Dongsheng Wang
(quoted diff) +4 -0
+* Freescale RCPM Wakeup Source Device Tree Bindings
+-------------------------------------------
+Required rcpm-wakeup property should be added to a device
+node if the

device

(quoted diff) +4 -0
+can be used as a wakeup source.
+
+  - rcpm-wakeup: The value of the property consists of 3 cells.
+ The

first
cell

Quoted 8 lines

+ is a pointer to the rcpm node, the second cell is the
+ bit mask
that
+ should be set in IPPDEXPCR0, and the last cell is for
IPPDEXPCR1.
+ Note: If the platform has no IPPDEXPCR1 register, put a
+ zero
here.

What if a future platform has more than two of these registers?

Quoted 6 lines
Quoted 3 lines

Those registers are only used for wakeup device, we have a lot of available bit for feature. For example, In LS1021a platform only 7bits has used in the registers, and 57bits is reserved.

Still, it'd be better to for the rcpm node to advertise the number of cells it expects.

For the foreseeable future it should be enough to use, even if not enough to use in the future at that time we can update the binding.

Quoted 8 lines
Quoted 7 lines

That's the whole point. Device tree is stable ABI. Updating it later to not be
fixed to two cells would be a lot harder than getting it right from the beginning. Putting the number of cells in the phandle target is a standard
device tree idiom.

I agree with you. But what's the point a SOC has more than 64 wakeup source?

I don't know. Hardware people do strange things sometimes. They might not want to reuse bits they once used for something on some other chip, or they might have some encoding scheme in mind that results in the bits not being packed as tightly as possible, or there may be some big array of similar devices...

What's the point of skipping this part of the phandle-plus-arguments idiom?

-Scott

#9 lore raw

PATCH v2 1/2 fsl: Add binding for RCPM

Quoted 94 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 10:38 AM
To: Tang Yuantian-B29983
Cc: Wang Dongsheng-B40534; devicetree at vger.kernel.org; linuxppc-
dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan-B18965; Jin Zhengxiong-R64188; Zhao Chenhui-B35336
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 73 lines · On Tue, 2015-09-15 at 21:35 -0500, Tang Yuantian-B29983 wrote:
Quoted 73 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 10:32 AM
To: Wang Dongsheng-B40534 <[email protected]>
Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan- B18965 <[email protected]>; Jin Zhengxiong-R64188 <[email protected]>; Zhao Chenhui-B35336 <[email protected]>; Tang Yuantian-B29983 <[email protected]>
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 58 lines · On Tue, 2015-09-15 at 21:30 -0500, Wang Dongsheng-B40534 wrote:

Hi Scott,

Quoted 47 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 10:19 AM
To: Wang Dongsheng-B40534
Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan- B18965; Jin
Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 36 lines · On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote:

Hi Scott,

Quoted 33 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 7:57 AM
To: Wang Dongsheng-B40534
Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang robh+Huan-
B18965; Jin
Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 11 lines · Dongsheng Wang
(quoted diff) +4 -0
+* Freescale RCPM Wakeup Source Device Tree Bindings
+-------------------------------------------
+Required rcpm-wakeup property should be added to a device
+node if the

device

(quoted diff) +4 -0
+can be used as a wakeup source.
+
+  - rcpm-wakeup: The value of the property consists of 3 cells.
+ The

first
cell

Quoted 8 lines

+ is a pointer to the rcpm node, the second cell is the
+ bit mask
that
+ should be set in IPPDEXPCR0, and the last cell is for
IPPDEXPCR1.
+ Note: If the platform has no IPPDEXPCR1 register, put a
+ zero
here.

What if a future platform has more than two of these registers?

Quoted 6 lines
Quoted 3 lines

Those registers are only used for wakeup device, we have a lot of available bit for feature. For example, In LS1021a platform only 7bits has used in the registers, and 57bits is reserved.

Still, it'd be better to for the rcpm node to advertise the number of cells it expects.

For the foreseeable future it should be enough to use, even if not enough to use in the future at that time we can update the binding.

Quoted 8 lines
Quoted 7 lines

That's the whole point. Device tree is stable ABI. Updating it later to not be
fixed to two cells would be a lot harder than getting it right from the beginning. Putting the number of cells in the phandle target is a standard
device tree idiom.

I agree with you. But what's the point a SOC has more than 64 wakeup source?

Quoted 7 lines

I don't know. Hardware people do strange things sometimes. They might not want to reuse bits they once used for something on some other chip, or they might have some encoding scheme in mind that results in the bits not being packed as tightly as possible, or there may be some big array of similar devices...

What's the point of skipping this part of the phandle-plus-arguments idiom?

Fine, I will add a property in rcpm node to describe the number of register.

Regards,
-Dongsheng

#10 lore raw

PATCH v2 1/2 fsl: Add binding for RCPM

In reply to Scott Wood

Hi Scott,

Quoted 115 lines

-----Original Message-----
From: Wang Dongsheng-B40534
Sent: Wednesday, September 16, 2015 10:44 AM
To: Wood Scott-B07421; Tang Yuantian-B29983
Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan-B18965; Jin Zhengxiong-R64188; Zhao Chenhui-B35336
Subject: RE: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 10 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 10:38 AM
To: Tang Yuantian-B29983
Cc: Wang Dongsheng-B40534; devicetree at vger.kernel.org; linuxppc- dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org;
Wang Huan-B18965; Jin Zhengxiong-R64188; Zhao Chenhui-B35336
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 73 lines
Quoted 72 lines · On Tue, 2015-09-15 at 21:35 -0500, Tang Yuantian-B29983 wrote:
Quoted 72 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 10:32 AM
To: Wang Dongsheng-B40534 <[email protected]>
Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang robh+Huan-
B18965 <[email protected]>; Jin Zhengxiong-R64188 <[email protected]>; Zhao Chenhui-B35336 <[email protected]>; Tang Yuantian-B29983 <[email protected]>
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 57 lines · On Tue, 2015-09-15 at 21:30 -0500, Wang Dongsheng-B40534 wrote:

Hi Scott,

Quoted 55 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 10:19 AM
To: Wang Dongsheng-B40534
Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang robh+Huan-
B18965; Jin
Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 43 lines · On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote:

Hi Scott,

Quoted 29 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 7:57 AM
To: Wang Dongsheng-B40534
Cc: devicetree at vger.kernel.org;
linuxppc-dev at lists.ozlabs.org;
robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; robh+Wang
robh+Huan-
B18965; Jin
Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 14 lines · Dongsheng Wang
(quoted diff) +4 -0
+* Freescale RCPM Wakeup Source Device Tree Bindings
+-------------------------------------------
+Required rcpm-wakeup property should be added to a
+device node if the

device

(quoted diff) +4 -0
+can be used as a wakeup source.
+
+  - rcpm-wakeup: The value of the property consists of 3 cells.
+ The

first
cell
+ is a pointer to the rcpm node, the second cell is
+ the bit mask
that

Quoted 8 lines
Quoted 6 lines

+ should be set in IPPDEXPCR0, and the last cell is
+ for
IPPDEXPCR1.
+ Note: If the platform has no IPPDEXPCR1 register,
+ put a zero
here.

What if a future platform has more than two of these registers?

Those registers are only used for wakeup device, we have a lot of available bit for feature. For example, In LS1021a platform only 7bits has used in the registers, and 57bits is

reserved.

Quoted 20 lines
Quoted 7 lines
Quoted 7 lines
Quoted 6 lines
Quoted 3 lines

Still, it'd be better to for the rcpm node to advertise the number of cells it expects.

For the foreseeable future it should be enough to use, even if not enough to use in the future at that time we can update the binding.

Quoted 6 lines
Quoted 5 lines

That's the whole point. Device tree is stable ABI. Updating it later to not be fixed to two cells would be a lot harder than getting it right from the beginning. Putting the number of cells in the phandle target is a standard device tree idiom.

I agree with you. But what's the point a SOC has more than 64 wakeup source?

I don't know. Hardware people do strange things sometimes. They might not want to reuse bits they once used for something on some other chip, or they might have some encoding scheme in mind that results in the bits not being packed as tightly as possible, or there may be some big array of similar devices...

Quoted 4 lines
Quoted 1 line

What's the point of skipping this part of the phandle-plus-arguments idiom?

Fine, I will add a property in rcpm node to describe the number of register.

How about the following modify? If okay for you I will fix in next version.

Required properites:
- reg : Offset and length of the register set of RCPM block.
+ - fsl,rcpm-wakeup-cell-num : The number of cell in rcpm-wakeup property.

        rcpm: global-utilities at e2000 {
                compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0";
                reg = <0xe2000 0x1000>;
+               fsl,rcpm-wakeup-cell-num = <2>;
        };

Regards,
-Dongsheng

#11 lore raw

PATCH v2 1/2 fsl: Add binding for RCPM

Quoted 133 lines · On Tue, 2015-09-15 at 22:18 -0500, Wang Dongsheng-B40534 wrote:

Hi Scott,

Quoted 120 lines

-----Original Message-----
From: Wang Dongsheng-B40534
Sent: Wednesday, September 16, 2015 10:44 AM
To: Wood Scott-B07421; Tang Yuantian-B29983
Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan- B18965; Jin
Zhengxiong-R64188; Zhao Chenhui-B35336
Subject: RE: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 10 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 10:38 AM
To: Tang Yuantian-B29983
Cc: Wang Dongsheng-B40534; devicetree at vger.kernel.org; linuxppc- dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org;
Wang Huan-B18965; Jin Zhengxiong-R64188; Zhao Chenhui-B35336
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 75 lines
Quoted 74 lines · On Tue, 2015-09-15 at 21:35 -0500, Tang Yuantian-B29983 wrote:
Quoted 74 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 10:32 AM
To: Wang Dongsheng-B40534 <[email protected]>
Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang robh+Huan-
B18965 <[email protected]>; Jin Zhengxiong-R64188 <[email protected]>; Zhao Chenhui-B35336 <[email protected]>; Tang Yuantian-B29983 <[email protected]>
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 59 lines · On Tue, 2015-09-15 at 21:30 -0500, Wang Dongsheng-B40534 wrote:

Hi Scott,

Quoted 57 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 10:19 AM
To: Wang Dongsheng-B40534
Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang robh+Huan-
B18965; Jin
Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 45 lines · On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote:

Hi Scott,

Quoted 31 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 7:57 AM
To: Wang Dongsheng-B40534
Cc: devicetree at vger.kernel.org;
linuxppc-dev at lists.ozlabs.org;
robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; robh+Wang
robh+Huan-
B18965; Jin
Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 16 lines · Dongsheng Wang
(quoted diff) +4 -0
+* Freescale RCPM Wakeup Source Device Tree Bindings
+-------------------------------------------
+Required rcpm-wakeup property should be added to a
+device node if the

device

(quoted diff) +3 -0
+can be used as a wakeup source.
+
+  - rcpm-wakeup: The value of the property consists of 3 

cells.
+ The
first
cell
+ is a pointer to the rcpm node, the second cell is
+ the bit mask
that
+ should be set in IPPDEXPCR0, and the last cell is

Quoted 8 lines
Quoted 5 lines

+ for
IPPDEXPCR1.
+ Note: If the platform has no IPPDEXPCR1 register,
+ put a zero
here.

What if a future platform has more than two of these registers?

Those registers are only used for wakeup device, we have a lot of available bit for feature. For example, In LS1021a platform only 7bits has used in the registers, and 57bits is

reserved.

Quoted 22 lines
Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
Quoted 3 lines

Still, it'd be better to for the rcpm node to advertise the number of cells it expects.

For the foreseeable future it should be enough to use, even if not enough to use in the future at that time we can update the binding.

Quoted 7 lines
Quoted 5 lines

That's the whole point. Device tree is stable ABI. Updating it later to not be fixed to two cells would be a lot harder than getting it right from the beginning. Putting the number of cells in the phandle target is a standard device tree idiom.

I agree with you. But what's the point a SOC has more than 64 wakeup source?

I don't know. Hardware people do strange things sometimes. They might not want to reuse bits they once used for something on some other chip, or they might have some encoding scheme in mind that results in the bits not being packed as tightly as possible, or there may be some big array of similar devices...

Quoted 6 lines
Quoted 2 lines

What's the point of skipping this part of the phandle-plus-arguments idiom?

Fine, I will add a property in rcpm node to describe the number of register.

How about the following modify? If okay for you I will fix in next version.

Required properites:
- reg : Offset and length of the register set of RCPM block.

Review

Quoted 7 lines
(quoted diff) +2 -0
+  - fsl,rcpm-wakeup-cell-num : The number of cell in rcpm-wakeup property.
 
        rcpm:  global-utilities at e2000{
                compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0";
                reg = <0xe2000 0x1000>;
+               fsl,rcpm-wakeup-cell-num = <2>;
        };

OK, though "fsl,#rcpm-wakeup-cells" would be more idiomatic.

Also s/number of cell/number of cells/

-Scott

#12 lore raw

PATCH v2 1/2 fsl: Add binding for RCPM

Quoted 153 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 12:14 PM
To: Wang Dongsheng-B40534
Cc: Tang Yuantian-B29983; devicetree at vger.kernel.org; linuxppc-
dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan-B18965; Jin Zhengxiong-R64188; Zhao Chenhui-B35336
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 141 lines · On Tue, 2015-09-15 at 22:18 -0500, Wang Dongsheng-B40534 wrote:

Hi Scott,

Quoted 126 lines

-----Original Message-----
From: Wang Dongsheng-B40534
Sent: Wednesday, September 16, 2015 10:44 AM
To: Wood Scott-B07421; Tang Yuantian-B29983
Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang Huan- B18965; Jin
Zhengxiong-R64188; Zhao Chenhui-B35336
Subject: RE: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 10 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 10:38 AM
To: Tang Yuantian-B29983
Cc: Wang Dongsheng-B40534; devicetree at vger.kernel.org; linuxppc- dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org;
Wang Huan-B18965; Jin Zhengxiong-R64188; Zhao Chenhui-B35336
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 81 lines
Quoted 80 lines · On Tue, 2015-09-15 at 21:35 -0500, Tang Yuantian-B29983 wrote:
Quoted 80 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 10:32 AM
To: Wang Dongsheng-B40534 <[email protected]>
Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org; robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; Wang robh+Huan-
B18965 <[email protected]>; Jin Zhengxiong-R64188 <[email protected]>; Zhao Chenhui-B35336 <[email protected]>; Tang Yuantian-B29983 <[email protected]>
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 65 lines · On Tue, 2015-09-15 at 21:30 -0500, Wang Dongsheng-B40534 wrote:

Hi Scott,

Quoted 63 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 10:19 AM
To: Wang Dongsheng-B40534
Cc: devicetree at vger.kernel.org;
linuxppc-dev at lists.ozlabs.org;
robh+dt at kernel.org; linux-arm-kernel at lists.infradead.org; robh+Wang
robh+Huan-
B18965; Jin
Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 48 lines · On Tue, 2015-09-15 at 21:15 -0500, Wang Dongsheng-B40534 wrote:

Hi Scott,

Quoted 33 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, September 16, 2015 7:57 AM
To: Wang Dongsheng-B40534
Cc: devicetree at vger.kernel.org; linuxppc-dev at lists.ozlabs.org;
robh+dt at kernel.org;
robh+linux-arm-kernel at lists.infradead.org; robh+Wang
robh+Huan-
B18965; Jin
Zhengxiong-R64188; Zhao Chenhui-B35336; Tang Yuantian-B29983
Subject: Re: [PATCH v2 1/2] fsl: Add binding for RCPM

Quoted 17 lines · Dongsheng Wang
(quoted diff) +4 -0
+* Freescale RCPM Wakeup Source Device Tree Bindings
+-------------------------------------------
+Required rcpm-wakeup property should be added to a
+device node if the

device

(quoted diff) +4 -0
+can be used as a wakeup source.
+
+  - rcpm-wakeup: The value of the property consists
+ of 3

cells.
+ The
first
cell
+ is a pointer to the rcpm node, the second cell
+ is the bit mask
that
+ should be set in IPPDEXPCR0, and the last cell

Quoted 8 lines
Quoted 5 lines

+ is for
IPPDEXPCR1.
+ Note: If the platform has no IPPDEXPCR1
+ register, put a zero
here.

What if a future platform has more than two of these registers?

Those registers are only used for wakeup device, we have a lot of available bit for feature. For example, In LS1021a platform only 7bits has used in the registers, and 57bits is

reserved.

Quoted 22 lines
Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
Quoted 3 lines

Still, it'd be better to for the rcpm node to advertise the number of cells it expects.

For the foreseeable future it should be enough to use, even if not enough to use in the future at that time we can update the binding.

Quoted 7 lines
Quoted 5 lines

That's the whole point. Device tree is stable ABI. Updating it later to not be fixed to two cells would be a lot harder than getting it right from the beginning. Putting the number of cells in the phandle target is a standard device tree idiom.

I agree with you. But what's the point a SOC has more than 64 wakeup source?

I don't know. Hardware people do strange things sometimes. They might not want to reuse bits they once used for something on some other chip, or they might have some encoding scheme in mind that results in the bits not being packed as tightly as possible, or there may be some big array of similar devices...

Quoted 6 lines
Quoted 2 lines

What's the point of skipping this part of the
phandle-plus-arguments idiom?

Fine, I will add a property in rcpm node to describe the number of register.

How about the following modify? If okay for you I will fix in next version.

Required properites:
- reg : Offset and length of the register set of RCPM block.
+ - fsl,rcpm-wakeup-cell-num : The number of cell in rcpm-wakeup property.

Quoted 7 lines
Quoted 5 lines
        rcpm:  global-utilities at e2000{
                compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0";
                reg = <0xe2000 0x1000>;
+               fsl,rcpm-wakeup-cell-num = <2>;
        };

OK, though "fsl,#rcpm-wakeup-cells" would be more idiomatic.

OK, thanks. Will fix it in next version.

Regards,
-Dongsheng