Skip to contentSkip to conversation

Patch "staging: rtl8192e: Fix log spamming in rtl8192_hard_data_xmit" has been added to the 4.2-stable tree

PATCH [email protected] 1 participant 1 message Sep 16, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

staging: rtl8192e: Fix log spamming in rtl8192_hard_data_xmit

to the 4.2-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:

     staging-rtl8192e-fix-log-spamming-in-rtl8192_hard_data_xmit.patch

and it can be found in the queue-4.2 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 435009bba4d0449b611bc24ae5c9636ac5b2a00e Mon Sep 17 00:00:00 2001

From: Mateusz Kulikowski <[email protected]>
Date: Wed, 12 Aug 2015 21:54:49 +0200
Subject: staging: rtl8192e: Fix log spamming in rtl8192_hard_data_xmit

From: Mateusz Kulikowski <[email protected]>

commit 435009bba4d0449b611bc24ae5c9636ac5b2a00e upstream.

This patch fixes issue generated by commit ca93dcba3a92 ("staging: rtl8192e: Remove assert() macro")

One negation was missed in conversion, therefore
asserted message was always printed.
For 1MB file downloaded via http, ~500 messages
were generated.

---
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8192e/rtl8192e/rtl_core.c +2 -2
@@ -1826,8 +1826,8 @@ void rtl8192_hard_data_xmit(struct sk_bu
 		return;
 	}
 
-	if (queue_index != TXCMD_QUEUE)
-		netdev_warn(dev, "%s(): queue index != TXCMD_QUEUE\n",
+	if (queue_index == TXCMD_QUEUE)
+		netdev_warn(dev, "%s(): queue index == TXCMD_QUEUE\n",
 			    __func__);
 
 	memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));

Patches currently in stable-queue which might be from [email protected] are

queue-4.2/staging-rtl8192e-fix-log-spamming-in-rtl8192_hard_data_xmit.patch