Skip to contentSkip to conversation

misc: hpilo: Add mini and max value of module parameter in description

PATCH Superseded Masanari Iida 3 participants 7 messages Sep 16, 2015 – Sep 21, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 misc: hpilo: Add mini and max value of module parameter in description

This patch add minimum and maximum value of module parameter max_ccb in hpilo.c.

---
 drivers/misc/hpilo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/hpilo.c +1 -1
index b83e3ca..d45cff0 100644
@@ -906,7 +906,7 @@ MODULE_AUTHOR("David Altobelli <[email protected]>");
 MODULE_LICENSE("GPL v2");
 
 module_param(max_ccb, uint, 0444);
-MODULE_PARM_DESC(max_ccb, "Maximum number of HP iLO channels to attach (16)");
+MODULE_PARM_DESC(max_ccb, "Maximum number of HP iLO channels to attach (8-24)(default=16)");
 
 module_init(ilo_init);
 module_exit(ilo_exit);
Signature · 1 line
2.6.0.rc2
#1 lore raw

That works for me, if it helps people understand what's going on.

I need to change my email from @hp to @hpe.

-----Original Message-----
From: Masanari Iida [mailto:[email protected]]
Sent: Wednesday, September 16, 2015 10:32 AM
To: [email protected]; [email protected]; [email protected]; Altobelli, David
Cc: Masanari Iida
Subject: [PATCH] misc: hpilo: Add mini and max value of module parameter in description

This patch add minimum and maximum value of module parameter max_ccb in hpilo.c.

---
 drivers/misc/hpilo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/hpilo.c +1 -1
index b83e3ca..d45cff0 100644
@@ -906,7 +906,7 @@ MODULE_AUTHOR("David Altobelli <[email protected]>");
 MODULE_LICENSE("GPL v2");
 
 module_param(max_ccb, uint, 0444);
-MODULE_PARM_DESC(max_ccb, "Maximum number of HP iLO channels to attach (16)");
+MODULE_PARM_DESC(max_ccb, "Maximum number of HP iLO channels to attach (8-24)(default=16)");
 
 module_init(ilo_init);
 module_exit(ilo_exit);
Signature · 1 line
2.6.0.rc2
#2 lore raw

PATCH v2 1/2 misc: hpilo: Add min and max value of module parameter in description

This patch add minimum and maximum value of module parameter max_ccb in hpilo.c.

---
 drivers/misc/hpilo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/hpilo.c +1 -1
index b83e3ca..d45cff0 100644
@@ -906,7 +906,7 @@ MODULE_AUTHOR("David Altobelli <[email protected]>");
 MODULE_LICENSE("GPL v2");
 
 module_param(max_ccb, uint, 0444);
-MODULE_PARM_DESC(max_ccb, "Maximum number of HP iLO channels to attach (16)");
+MODULE_PARM_DESC(max_ccb, "Maximum number of HP iLO channels to attach (8-24)(default=16)");
 
 module_init(ilo_init);
 module_exit(ilo_exit);
Signature · 1 line
2.6.0.rc2
#3 lore raw

PATCH v2 2/2 misc: hpilo: Change e-mail address from hp.com to hpe.com

This patch changes maintainer's email address from hp.com to hpe.com in hpilo.c.

---
 drivers/misc/hpilo.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/misc/hpilo.c +2 -2
index d45cff0..d6a901c 100644
@@ -2,7 +2,7 @@
  * Driver for the HP iLO management processor.
  *
  * Copyright (C) 2008 Hewlett-Packard Development Company, L.P.
- *	David Altobelli <[email protected]>
+ *	David Altobelli <[email protected]>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as
@@ -902,7 +902,7 @@ static void __exit ilo_exit(void)
 MODULE_VERSION("1.4.1");
 MODULE_ALIAS(ILO_NAME);
 MODULE_DESCRIPTION(ILO_NAME);
-MODULE_AUTHOR("David Altobelli <[email protected]>");
+MODULE_AUTHOR("David Altobelli <[email protected]>");
 MODULE_LICENSE("GPL v2");
 
 module_param(max_ccb, uint, 0444);
Signature · 1 line
2.6.0.rc2
maintainer
#4 lore raw

Re: [PATCH v2, 2/2] misc: hpilo: Change e-mail address from hp.com to hpe.com

Quoted 7 lines · Masanari Iida

This patch changes maintainer's email address from hp.com to hpe.com in hpilo.c.

---
 drivers/misc/hpilo.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

I'd like to get an ack from the driver author before accepting something like this...

#5 lore raw

RE: [PATCH v2, 2/2] misc: hpilo: Change e-mail address from hp.com to hpe.com

-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Sunday, September 20, 2015 9:29 PM
To: Masanari Iida
Cc: Altobelli, David; [email protected]; [email protected]
Subject: Re: [PATCH v2, 2/2] misc: hpilo: Change e-mail address from hp.com to hpe.com

Quoted 10 lines · Masanari Iida
Quoted 7 lines

This patch changes maintainer's email address from hp.com to hpe.com in hpilo.c.

---
 drivers/misc/hpilo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

I'd like to get an ack from the driver author before accepting something like this...

Sorry, wasn't really sure if anyone needed that (sorry about formatting)...

#6 lore raw
In reply to Altobelli, David
Quoted 4 lines · David

That works for me, if it helps people understand what's going on.

I need to change my email from @hp to @hpe.

Thanks for the comment.
I sent another patch to change all @hp to @hpe in hpilo.c

Masanari