Skip to contentSkip to conversation

Patch "usb: gadget: m66592-udc: forever loop in set_feature()" has been added to the 4.1-stable tree

PATCH [email protected] 1 participant 1 message Sep 16, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

usb: gadget: m66592-udc: forever loop in set_feature()

to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:

     usb-gadget-m66592-udc-forever-loop-in-set_feature.patch

and it can be found in the queue-4.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 5feb5d2003499b1094d898c010a7604d7afddc4c Mon Sep 17 00:00:00 2001

From: Dan Carpenter <[email protected]>
Date: Thu, 30 Jul 2015 00:30:58 +0300
Subject: usb: gadget: m66592-udc: forever loop in set_feature()

From: Dan Carpenter <[email protected]>

commit 5feb5d2003499b1094d898c010a7604d7afddc4c upstream.

There is an "&&" vs "||" typo here so this loops 3000 times or if we get unlucky it could loop forever.

Fixes ceaa0a6eeadf ('usb: gadget: m66592-udc: add support for TEST_MODE')
---
 drivers/usb/gadget/udc/m66592-udc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/gadget/udc/m66592-udc.c +1 -1
@@ -1052,7 +1052,7 @@ static void set_feature(struct m66592 *m
 				tmp = m66592_read(m66592, M66592_INTSTS0) &
 								M66592_CTSQ;
 				udelay(1);
-			} while (tmp != M66592_CS_IDST || timeout-- > 0);
+			} while (tmp != M66592_CS_IDST && timeout-- > 0);
 
 			if (tmp == M66592_CS_IDST)
 				m66592_bset(m66592,

Patches currently in stable-queue which might be from [email protected] are

queue-4.1/clk-versatile-off-by-one-in-clk_sp810_timerclken_of_get.patch queue-4.1/usb-gadget-m66592-udc-forever-loop-in-set_feature.patch