Skip to contentSkip to conversation

pmem: add proper synchronization to pmem_rw_page()

PATCH New Ross Zwisler 1 participant 1 message Sep 16, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pmem: add proper synchronization to pmem_rw_page()

pmem_rw_page() needs to call wmb_pmem() on writes to make sure that the newly written data is durable. This flow was added to pmem_rw_bytes() and pmem_make_request() with this commit:

commit 61031952f4c8 ("arch, x86: pmem api for ensuring durability of
persistent memory updates")

but it looks like the pmem_rw_page() path was missed.

---
 drivers/nvdimm/pmem.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/nvdimm/pmem.c +2 -0
index b952538..0ba6a97 100644
@@ -92,6 +92,8 @@ static int pmem_rw_page(struct block_device *bdev, sector_t sector,
 	struct pmem_device *pmem = bdev->bd_disk->private_data;
 
 	pmem_do_bvec(pmem, page, PAGE_CACHE_SIZE, 0, rw, sector);
+	if (rw & WRITE)
+		wmb_pmem();
 	page_endio(page, rw & WRITE, 0);
 
 	return 0;
Signature · 1 line
2.1.0