udev + 60-persistent-storage.rules + IDE
Hello!
I just noticed that udev (no longer) creates /dev/disk/by-uuid links for my boot partition under qemu when booting a whole-disk image (hdddirect). The device is then /dev/hda, with /dev/hda2 being the root partition.
systemd's 60-persistent-storage.rules indeed skips the relevant rules because "hd" is not listed:
KERNEL!="loop*|mmcblk*[0-9]|msblk*[0-9]|mspblk*[0-9]|nvme*|sd*|sr*|vd*|xvd*|bcache*|cciss*|dasd*|ubd*", GOTO="persistent_storage_end"
Adding "hd*" to that line fixes the problem. I'll send patches to systemd and for OE-core.
I'm a bit puzzled a) that plain-old IDE block devices have never been matched by 60-persistent-storage.rules (I checked the history) and b) that this suddenly broke. I'm fairly sure that I had tested that (but I cannot 100% guarantee that anymore).
Did indeed something change recently that led to /dev/hda?
Signature · 6 lines
Best Regards, Patrick Ohly The content of this message is my personal opinion only and although I am an employee of Intel, the statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak on behalf of Intel on this matter.
Quoted 5 lines · Patrick Ohly
I just noticed that udev (no longer) creates
/dev/disk/by-uuidlinks for my boot partition under qemu when booting a whole-disk image (hdddirect). The device is then/dev/hda, with/dev/hda2being the root partition.
Quoted 7 lines
systemd's 60-persistent-storage.rules indeed skips the relevant rules because "hd" is not listed:
KERNEL!="loop*|mmcblk*[0-9]|msblk*[0-9]|mspblk*[0-9]|nvme*|sd*|sr*|vd*|xvd*|bcache*|cciss*|dasd*|ubd*", GOTO="persistent_storage_end"
Adding "hd*" to that line fixes the problem. I'll send patches to systemd and for OE-core.
Lennart argued that /dev/hd* is caused by using the deprecated CONFIG_IDE in the kernel and therefore rejected adding "hd*" to upstream udev.
CONFIG_IDE seems to come from common-pc-drivers.cfg [1] but that's just a guess - I'm not entirely sure how to identify the actual kernel config fragments that were used during a build. Anyway, it has been there since 2011 and modernizing that is a different topic, so I'll just send the patch for systemd/udev.
Signature · 6 lines
Best Regards, Patrick Ohly The content of this message is my personal opinion only and although I am an employee of Intel, the statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak on behalf of Intel on this matter.
PATCH 1/1 systemd: apply persistent storage udev rules also for /dev/hd*
This fixes booting with initramfs and root=UUID on machines with IDE disks, like "runqemu hdddirect", and kernels which still use the deprecated CONFIG_IDE.
--- .../systemd/rules-whitelist-hd-devices.patch | 32 ++++++++++++++++++++++ meta/recipes-core/systemd/systemd_225.bb | 1 + 2 files changed, 33 insertions(+) create mode 100644 meta/recipes-core/systemd/systemd/rules-whitelist-hd-devices.patch
meta/recipes-core/systemd/systemd/rules-whitelist-hd-devices.patch new file +32 -0
@@ -0,0 +1,32 @@ +From f77b7e5626e70c3a775e993816a33af5a61dea42 Mon Sep 17 00:00:00 2001 +From: Patrick Ohly <[email protected]> +Date: Wed, 16 Sep 2015 13:55:58 +0200 +Subject: [PATCH] rules: whitelist hd* devices + +qemu by default emulates IDE and the linux-yocto kernel(s) use +CONFIG_IDE instead of the more modern libsata, so disks appear as +/dev/hd*. Patch rejected upstream because CONFIG_IDE is deprecated. + +Upstream-Status: Denied [https://github.com/systemd/systemd/pull/1276] + +Signed-off-by: Patrick Ohly <[email protected]> +--- + rules/60-persistent-storage.rules | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/rules/60-persistent-storage.rules b/rules/60-persistent-storage.rules +index 0b14bb4..1c4d97a 100644 +--- a/rules/60-persistent-storage.rules ++++ b/rules/60-persistent-storage.rules +@@ -6,7 +6,7 @@ + ACTION=="remove", GOTO="persistent_storage_end" + + SUBSYSTEM!="block", GOTO="persistent_storage_end" +-KERNEL!="loop*|mmcblk*[0-9]|msblk*[0-9]|mspblk*[0-9]|nvme*|sd*|sr*|vd*|xvd*|bcache*|cciss*|dasd*|ubd*", GOTO="persistent_storage_end" ++KERNEL!="loop*|mmcblk*[0-9]|msblk*[0-9]|mspblk*[0-9]|nvme*|hd*|sd*|sr*|vd*|xvd*|bcache*|cciss*|dasd*|ubd*", GOTO="persistent_storage_end" + + # ignore partitions that span the entire disk + TEST=="whole_disk", GOTO="persistent_storage_end" +-- +2.1.4 +
meta/recipes-core/systemd/systemd_225.bb +1 -0
@@ -45,6 +45,7 @@ SRC_URI = "git://github.com/systemd/systemd.git;protocol=git \ file://00-create-volatile.conf \ file://init \ file://run-ptest \ + file://rules-whitelist-hd-devices.patch \ " SRC_URI_append_qemuall = "file://qemuall_io_latency-core-device.c-Change-the-default-device-timeout-to-2.patch"
Signature · 1 line
2.1.4
Quoted 18 lines · Patrick Ohly
Quoted 5 lines · Patrick Ohly
I just noticed that udev (no longer) creates
/dev/disk/by-uuidlinks for my boot partition under qemu when booting a whole-disk image (hdddirect). The device is then/dev/hda, with/dev/hda2being the root partition.Quoted 7 lines
systemd's 60-persistent-storage.rules indeed skips the relevant rules because "hd" is not listed:
KERNEL!="loop*|mmcblk*[0-9]|msblk*[0-9]|mspblk*[0-9]|nvme*|sd*|sr*|vd*|xvd*|bcache*|cciss*|dasd*|ubd*", GOTO="persistent_storage_end"
Adding "hd*" to that line fixes the problem. I'll send patches to systemd and for OE-core.
Lennart argued that
/dev/hd*is caused by using the deprecatedCONFIG_IDEin the kernel and therefore rejected adding "hd*" to upstream udev.
Quoted 5 lines
CONFIG_IDEseems to come from common-pc-drivers.cfg [1] but that's just a guess - I'm not entirely sure how to identify the actual kernel config fragments that were used during a build. Anyway, it has been there since 2011 and modernizing that is a different topic, so I'll just send the patch for systemd/udev.
That is in fact where it comes from for those machines .. and in fact, I started removing it from various trees about a year ago. Up until recently, it was around
for compatibility reasons .. but now the generic scsi subsystem provides everything
that CONFIG_IDE used to .. and they can in fact be dropped.
I may do it to the 4.1 kernel, or wait until after the upcoming release to avoid any
chance of breaking something that still depends on it.
Bruce
Quoted 19 lines
--
Best Regards, Patrick OhlyThe content of this message is my personal opinion only and although I am an employee of Intel, the statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak on behalf of Intel on this matter.
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Signature · 2 lines
"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"
PATCH v2 1/1 systemd: apply persistent storage udev rules also for /dev/hd*
In reply to Patrick OhlyThis fixes booting with initramfs and root=UUID on machines with IDE disks, like "runqemu hdddirect", and kernels which still use the deprecated CONFIG_IDE.
v2: Rebased against current master-next.
--- .../systemd/rules-whitelist-hd-devices.patch | 32 ++++++++++++++++++++++ meta/recipes-core/systemd/systemd_225.bb | 1 + 2 files changed, 33 insertions(+) create mode 100644 meta/recipes-core/systemd/systemd/rules-whitelist-hd-devices.patch
meta/recipes-core/systemd/systemd/rules-whitelist-hd-devices.patch new file +32 -0
@@ -0,0 +1,32 @@ +From f77b7e5626e70c3a775e993816a33af5a61dea42 Mon Sep 17 00:00:00 2001 +From: Patrick Ohly <[email protected]> +Date: Wed, 16 Sep 2015 13:55:58 +0200 +Subject: [PATCH] rules: whitelist hd* devices + +qemu by default emulates IDE and the linux-yocto kernel(s) use +CONFIG_IDE instead of the more modern libsata, so disks appear as +/dev/hd*. Patch rejected upstream because CONFIG_IDE is deprecated. + +Upstream-Status: Denied [https://github.com/systemd/systemd/pull/1276] + +Signed-off-by: Patrick Ohly <[email protected]> +--- + rules/60-persistent-storage.rules | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/rules/60-persistent-storage.rules b/rules/60-persistent-storage.rules +index 0b14bb4..1c4d97a 100644 +--- a/rules/60-persistent-storage.rules ++++ b/rules/60-persistent-storage.rules +@@ -6,7 +6,7 @@ + ACTION=="remove", GOTO="persistent_storage_end" + + SUBSYSTEM!="block", GOTO="persistent_storage_end" +-KERNEL!="loop*|mmcblk*[0-9]|msblk*[0-9]|mspblk*[0-9]|nvme*|sd*|sr*|vd*|xvd*|bcache*|cciss*|dasd*|ubd*", GOTO="persistent_storage_end" ++KERNEL!="loop*|mmcblk*[0-9]|msblk*[0-9]|mspblk*[0-9]|nvme*|hd*|sd*|sr*|vd*|xvd*|bcache*|cciss*|dasd*|ubd*", GOTO="persistent_storage_end" + + # ignore partitions that span the entire disk + TEST=="whole_disk", GOTO="persistent_storage_end" +-- +2.1.4 +
meta/recipes-core/systemd/systemd_225.bb +1 -0
@@ -45,6 +45,7 @@ SRC_URI = "git://github.com/systemd/systemd.git;protocol=git \ file://00-create-volatile.conf \ file://init \ file://run-ptest \ + file://rules-whitelist-hd-devices.patch \ " SRC_URI_append_qemuall = " file://qemuall_io_latency-core-device.c-Change-the-default-device-timeout-to-2.patch"
Signature · 1 line
2.1.4