mfd: lpc_ich: Separate device cells for clarity
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 mfd: lpc_ich: Separate device cells for clarity
The lpc_ich_cells array gives the wrong impression about the relationship between the watchdog and GPIO devices. They are completely distinct devices, so this patch separates the array into distinct mfd_cell structs per device.
A side effect of removing the array, is that the lpc_cells enum is no longer needed.
--- drivers/mfd/lpc_ich.c | 42 ++++++++++++++++++------------------------ 1 file changed, 18 insertions(+), 24 deletions(-)
drivers/mfd/lpc_ich.c +18 -24
@@ -131,24 +131,18 @@ static struct resource gpio_ich_res[] = { }, }; -enum lpc_cells { -LPC_WDT =0 , -LPC_GPIO , +static struct mfd_cell lpc_ich_wdt_cell = { + .name ="iTCO_wdt" , + .num_resources =ARRAY_SIZE (wdt_ich_res), + .resources = wdt_ich_res, + .ignore_resource_conflicts = true, }; -static struct mfd_cell lpc_ich_cells[] = { - [LPC_WDT ] = { - .name ="iTCO_wdt" , - .num_resources =ARRAY_SIZE (wdt_ich_res), - .resources = wdt_ich_res, - .ignore_resource_conflicts = true, - }, - [LPC_GPIO ] = { - .name ="gpio_ich" , - .num_resources =ARRAY_SIZE (gpio_ich_res), - .resources = gpio_ich_res, - .ignore_resource_conflicts = true, - }, +static struct mfd_cell lpc_ich_gpio_cell = { + .name ="gpio_ich" , + .num_resources =ARRAY_SIZE (gpio_ich_res), + .resources = gpio_ich_res, + .ignore_resource_conflicts = true, };/* chipset related info */
@@ -881,7 +875,7 @@ static int lpc_ich_init_gpio(struct pci_dev *dev) base_addr = base_addr_cfg &0x0000ff80 ;if (!base_addr) {dev_notice (&dev->dev,"I/O space for ACPI uninitialized\n" ); - lpc_ich_cells[LPC_GPIO ].num_resources--; + lpc_ich_gpio_cell.num_resources--; goto gpe0_done; }
@@ -895,7 +889,7 @@ static int lpc_ich_init_gpio(struct pci_dev *dev)* the platform_device subsystem doesn't see this resource * or it will register an invalid region. */ - lpc_ich_cells[LPC_GPIO ].num_resources--; + lpc_ich_gpio_cell.num_resources--; acpi_conflict = true; }else {lpc_ich_enable_acpi_space (dev);
@@ -933,14 +927,14 @@ gpe0_done: lpc_chipset_info[priv->chipset].use_gpio = ret;lpc_ich_enable_gpio_space (dev); -lpc_ich_finalize_cell (dev, &lpc_ich_cells[LPC_GPIO ]); +lpc_ich_finalize_cell (dev, &lpc_ich_gpio_cell); ret =mfd_add_devices (&dev->dev,PLATFORM_DEVID_AUTO , - &lpc_ich_cells[LPC_GPIO ],1 ,NULL ,0 ,NULL ); + &lpc_ich_gpio_cell,1 ,NULL ,0 ,NULL ); gpio_done:if (acpi_conflict)pr_warn ("Resource conflict(s) found affecting %s\n" , - lpc_ich_cells[LPC_GPIO ].name); + lpc_ich_gpio_cell.name);return ret; }
@@ -984,7 +978,7 @@ static int lpc_ich_init_wdt(struct pci_dev *dev)*/ if (lpc_chipset_info[priv->chipset].iTCO_version ==1 ) {/* Don't register iomem for TCO ver 1 */ - lpc_ich_cells[LPC_WDT ].num_resources--; + lpc_ich_wdt_cell.num_resources--; }else if (lpc_chipset_info[priv->chipset].iTCO_version ==2 ) {pci_read_config_dword (dev,RCBABASE , &base_addr_cfg); base_addr = base_addr_cfg &0xffffc000 ;
@@ -1007,9 +1001,9 @@ static int lpc_ich_init_wdt(struct pci_dev *dev) res->end = base_addr +ACPIBASE_PMC_END ; } -lpc_ich_finalize_cell (dev, &lpc_ich_cells[LPC_WDT ]); +lpc_ich_finalize_cell (dev, &lpc_ich_wdt_cell); ret =mfd_add_devices (&dev->dev,PLATFORM_DEVID_AUTO , - &lpc_ich_cells[LPC_WDT ],1 ,NULL ,0 ,NULL ); + &lpc_ich_wdt_cell,1 ,NULL ,0 ,NULL ); wdt_done:return ret;
Signature · 1 line
1.9.1
Quoted 8 lines · Aaron Sierra
The
lpc_ich_cellsarray gives the wrong impression about the relationship between the watchdog and GPIO devices. They are completely distinct devices, so this patch separates the array into distinctmfd_cellstructs per device.A side effect of removing the array, is that the
lpc_cellsenum is no longer needed.
Looks good for me.
Quoted 109 lines
Signed-off-by Aaron Sierra <[email protected]>--- drivers/mfd/lpc_ich.c | 42 ++++++++++++++++++-----------------------(quoted diff) +0
-1- 1 file changed, 18 insertions(+), 24 deletions(-)drivers/mfd/lpc_ich.c +11
-17@@ -131,24 +131,18 @@ static struct resource gpio_ich_res[] = { }, }; -enum lpc_cells { -LPC_WDT =0 , -LPC_GPIO , +static struct mfd_cell lpc_ich_wdt_cell = { + .name ="iTCO_wdt" , + .num_resources =ARRAY_SIZE (wdt_ich_res), + .resources = wdt_ich_res, + .ignore_resource_conflicts = true, }; -static struct mfd_cell lpc_ich_cells[] = { - [LPC_WDT ] = { - .name ="iTCO_wdt" , - .num_resources =ARRAY_SIZE (wdt_ich_res), - .resources = wdt_ich_res, - .ignore_resource_conflicts = true, - }, - [LPC_GPIO ] = { - .name ="gpio_ich" , - .num_resources =ARRAY_SIZE (gpio_ich_res), - .resources = gpio_ich_res, - .ignore_resource_conflicts = true, - }, +static struct mfd_cell lpc_ich_gpio_cell = { + .name ="gpio_ich" , + .num_resources =ARRAY_SIZE (gpio_ich_res), + .resources = gpio_ich_res, + .ignore_resource_conflicts = true, };/* chipset related info */ @@ -881,7 +875,7 @@ static int lpc_ich_init_gpio(struct pci_dev *dev) base_addr = base_addr_cfg &0x0000ff80 ;if (!base_addr) {dev_notice (&dev->dev,"I/O space for ACPI uninitialized\n"); - lpc_ich_cells[LPC_GPIO ].num_resources--; + lpc_ich_gpio_cell.num_resources--; goto gpe0_done; }@@ -895,7 +889,7 @@ static int lpc_ich_init_gpio(struct pci_dev *dev)* the platform_device subsystem doesn't see this resource
drivers/mfd/lpc_ich.c +5
-5* or it will register an invalid region. */ - lpc_ich_cells[LPC_GPIO ].num_resources--; + lpc_ich_gpio_cell.num_resources--; acpi_conflict = true; }else {lpc_ich_enable_acpi_space (dev);@@ -933,14 +927,14 @@ gpe0_done: lpc_chipset_info[priv->chipset].use_gpio = ret;lpc_ich_enable_gpio_space (dev); -lpc_ich_finalize_cell (dev, &lpc_ich_cells[LPC_GPIO ]); +lpc_ich_finalize_cell (dev, &lpc_ich_gpio_cell); ret =mfd_add_devices (&dev->dev,PLATFORM_DEVID_AUTO , - &lpc_ich_cells[LPC_GPIO ],1 ,NULL ,0 ,NULL ); + &lpc_ich_gpio_cell, 1, NULL, 0, NULL); gpio_done:if (acpi_conflict)pr_warn ("Resource conflict(s) found affecting %s\n" , - lpc_ich_cells[LPC_GPIO ].name); + lpc_ich_gpio_cell.name);return ret; }@@ -984,7 +978,7 @@ static int lpc_ich_init_wdt(struct pci_dev *dev)*/ if (lpc_chipset_info[priv->chipset].iTCO_version ==1 ) {/* Don't register iomem for TCO ver 1 */ - lpc_ich_cells[LPC_WDT ].num_resources--; + lpc_ich_wdt_cell.num_resources--; }else if (lpc_chipset_info[priv->chipset].iTCO_version ==2 ) { pci_read_config_dword(dev, RCBABASE,
&base_addr_cfg);drivers/mfd/lpc_ich.c +2
-2base_addr = base_addr_cfg &0xffffc000 ;@@ -1007,9 +1001,9 @@ static int lpc_ich_init_wdt(struct pci_dev *dev) res->end = base_addr +ACPIBASE_PMC_END ; } -lpc_ich_finalize_cell (dev, &lpc_ich_cells[LPC_WDT ]); +lpc_ich_finalize_cell (dev, &lpc_ich_wdt_cell); ret =mfd_add_devices (&dev->dev,PLATFORM_DEVID_AUTO , - &lpc_ich_cells[LPC_WDT ],1 ,NULL ,0 ,NULL ); + &lpc_ich_wdt_cell, 1, NULL, 0, NULL);
wdt_done:
return ret;
Signature · 2 lines
Andy Shevchenko <[email protected]> Intel Finland Oy
Quoted 11 lines · Andy Shevchenko
Quoted 8 lines · Aaron Sierra
The
lpc_ich_cellsarray gives the wrong impression about the relationship between the watchdog and GPIO devices. They are completely distinct devices, so this patch separates the array into distinctmfd_cellstructs per device.A side effect of removing the array, is that the
lpc_cellsenum is no longer needed.Looks good for me.
Is that an Ack? If so, can you formally provide one please?
Quoted 110 lines
Quoted 109 lines
Signed-off-by Aaron Sierra <[email protected]>--- drivers/mfd/lpc_ich.c | 42 ++++++++++++++++++-----------------------(quoted diff) +0
-1- 1 file changed, 18 insertions(+), 24 deletions(-)drivers/mfd/lpc_ich.c +11
-17@@ -131,24 +131,18 @@ static struct resource gpio_ich_res[] = { }, }; -enum lpc_cells { -LPC_WDT =0 , -LPC_GPIO , +static struct mfd_cell lpc_ich_wdt_cell = { + .name ="iTCO_wdt" , + .num_resources =ARRAY_SIZE (wdt_ich_res), + .resources = wdt_ich_res, + .ignore_resource_conflicts = true, }; -static struct mfd_cell lpc_ich_cells[] = { - [LPC_WDT ] = { - .name ="iTCO_wdt" , - .num_resources =ARRAY_SIZE (wdt_ich_res), - .resources = wdt_ich_res, - .ignore_resource_conflicts = true, - }, - [LPC_GPIO ] = { - .name ="gpio_ich" , - .num_resources =ARRAY_SIZE (gpio_ich_res), - .resources = gpio_ich_res, - .ignore_resource_conflicts = true, - }, +static struct mfd_cell lpc_ich_gpio_cell = { + .name ="gpio_ich" , + .num_resources =ARRAY_SIZE (gpio_ich_res), + .resources = gpio_ich_res, + .ignore_resource_conflicts = true, };/* chipset related info */ @@ -881,7 +875,7 @@ static int lpc_ich_init_gpio(struct pci_dev *dev) base_addr = base_addr_cfg &0x0000ff80 ;if (!base_addr) {dev_notice (&dev->dev,"I/O space for ACPI uninitialized\n"); - lpc_ich_cells[LPC_GPIO ].num_resources--; + lpc_ich_gpio_cell.num_resources--; goto gpe0_done; }@@ -895,7 +889,7 @@ static int lpc_ich_init_gpio(struct pci_dev *dev)* the platform_device subsystem doesn't see this resource
drivers/mfd/lpc_ich.c +5
-5* or it will register an invalid region. */ - lpc_ich_cells[LPC_GPIO ].num_resources--; + lpc_ich_gpio_cell.num_resources--; acpi_conflict = true; }else {lpc_ich_enable_acpi_space (dev);@@ -933,14 +927,14 @@ gpe0_done: lpc_chipset_info[priv->chipset].use_gpio = ret;lpc_ich_enable_gpio_space (dev); -lpc_ich_finalize_cell (dev, &lpc_ich_cells[LPC_GPIO ]); +lpc_ich_finalize_cell (dev, &lpc_ich_gpio_cell); ret =mfd_add_devices (&dev->dev,PLATFORM_DEVID_AUTO , - &lpc_ich_cells[LPC_GPIO ],1 ,NULL ,0 ,NULL ); + &lpc_ich_gpio_cell, 1, NULL, 0, NULL); gpio_done:if (acpi_conflict)pr_warn ("Resource conflict(s) found affecting %s\n" , - lpc_ich_cells[LPC_GPIO ].name); + lpc_ich_gpio_cell.name);return ret; }@@ -984,7 +978,7 @@ static int lpc_ich_init_wdt(struct pci_dev *dev)*/ if (lpc_chipset_info[priv->chipset].iTCO_version ==1 ) {/* Don't register iomem for TCO ver 1 */ - lpc_ich_cells[LPC_WDT ].num_resources--; + lpc_ich_wdt_cell.num_resources--; }else if (lpc_chipset_info[priv->chipset].iTCO_version ==2 ) { pci_read_config_dword(dev, RCBABASE,
&base_addr_cfg);drivers/mfd/lpc_ich.c +2
-2base_addr = base_addr_cfg &0xffffc000 ;@@ -1007,9 +1001,9 @@ static int lpc_ich_init_wdt(struct pci_dev *dev) res->end = base_addr +ACPIBASE_PMC_END ; } -lpc_ich_finalize_cell (dev, &lpc_ich_cells[LPC_WDT ]); +lpc_ich_finalize_cell (dev, &lpc_ich_wdt_cell); ret =mfd_add_devices (&dev->dev,PLATFORM_DEVID_AUTO , - &lpc_ich_cells[LPC_WDT ],1 ,NULL ,0 ,NULL ); + &lpc_ich_wdt_cell, 1, NULL, 0, NULL);
wdt_done:
return ret;
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Andy Shevchenko
Acked-byQuoted 8 lines · Lee Jones
Quoted 6 lines · Andy Shevchenko
Quoted 5 lines · Aaron Sierra
The
lpc_ich_cellsarray gives the wrong impression about the relationship between the watchdog and GPIO devices. They are completely distinct devices, so this patch separates the array into distinctmfd_cellstructs per device.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
A side effect of removing the array, is that the
lpc_cellsenum is no longer needed.Looks good for me.
Is that an Ack? If so, can you formally provide one please?
Sorry, might be late. Was too busy by some hw quirks yesterday.
Quoted 123 lines
Quoted 122 lines
Quoted 121 lines
Signed-off-by Aaron Sierra <[email protected]>--- drivers/mfd/lpc_ich.c | 42 ++++++++++++++++++-----------------------
(quoted diff) +0
-1- 1 file changed, 18 insertions(+), 24 deletions(-)drivers/mfd/lpc_ich.c +11
-17@@ -131,24 +131,18 @@ static struct resource gpio_ich_res[] = { }, }; -enum lpc_cells { -LPC_WDT =0 , -LPC_GPIO , +static struct mfd_cell lpc_ich_wdt_cell = { + .name ="iTCO_wdt" , + .num_resources =ARRAY_SIZE (wdt_ich_res), + .resources = wdt_ich_res, + .ignore_resource_conflicts = true, }; -static struct mfd_cell lpc_ich_cells[] = { - [LPC_WDT ] = { - .name ="iTCO_wdt" , - .num_resources =ARRAY_SIZE (wdt_ich_res), - .resources = wdt_ich_res, - .ignore_resource_conflicts = true, - }, - [LPC_GPIO ] = { - .name ="gpio_ich" , - .num_resources =ARRAY_SIZE (gpio_ich_res), - .resources = gpio_ich_res, - .ignore_resource_conflicts = true, - }, +static struct mfd_cell lpc_ich_gpio_cell = { + .name ="gpio_ich" , + .num_resources =ARRAY_SIZE (gpio_ich_res), + .resources = gpio_ich_res, + .ignore_resource_conflicts = true, };/* chipset related info */ @@ -881,7 +875,7 @@ static int lpc_ich_init_gpio(struct pci_dev *dev) base_addr = base_addr_cfg &0x0000ff80 ;if (!base_addr) {dev_notice (&dev->dev,"I/O space for ACPI uninitialized\n"); - lpc_ich_cells[LPC_GPIO ].num_resources--; + lpc_ich_gpio_cell.num_resources--; goto gpe0_done;drivers/mfd/lpc_ich.c +0
-0}@@ -895,7 +889,7 @@ static int lpc_ich_init_gpio(struct pci_dev *dev) * the platform_device subsystem doesn't seethis
resourcedrivers/mfd/lpc_ich.c +5
-5* or it will register an invalid region. */ - lpc_ich_cells[LPC_GPIO ].num_resources--; + lpc_ich_gpio_cell.num_resources--; acpi_conflict = true; }else {lpc_ich_enable_acpi_space (dev);@@ -933,14 +927,14 @@ gpe0_done: lpc_chipset_info[priv->chipset].use_gpio = ret;lpc_ich_enable_gpio_space (dev); -lpc_ich_finalize_cell (dev, &lpc_ich_cells[LPC_GPIO ]); +lpc_ich_finalize_cell (dev, &lpc_ich_gpio_cell); ret =mfd_add_devices (&dev->dev,PLATFORM_DEVID_AUTO , - &lpc_ich_cells[LPC_GPIO ],1 ,NULL ,0 ,NULL ); + &lpc_ich_gpio_cell,1 ,NULL ,0 , NULL); gpio_done:if (acpi_conflict) pr_warn("Resource conflict(s) found affecting %s\n", - lpc_ich_cells[LPC_GPIO].name); + lpc_ich_gpio_cell.name);return ret; }@@ -984,7 +978,7 @@ static int lpc_ich_init_wdt(struct pci_dev*dev) */ if (lpc_chipset_info[priv->chipset].iTCO_version ==1 ) {/* Don't register iomem for TCO ver 1 */ - lpc_ich_cells[LPC_WDT ].num_resources--; + lpc_ich_wdt_cell.num_resources--; } else if (lpc_chipset_info[priv->chipset].iTCO_version==
2) {
pci_read_config_dword(dev, RCBABASE,&base_addr_cfg);drivers/mfd/lpc_ich.c +2
-2base_addr = base_addr_cfg &0xffffc000 ;@@ -1007,9 +1001,9 @@ static int lpc_ich_init_wdt(struct pci_dev *dev) res->end = base_addr +ACPIBASE_PMC_END ; } -lpc_ich_finalize_cell (dev, &lpc_ich_cells[LPC_WDT ]); +lpc_ich_finalize_cell (dev, &lpc_ich_wdt_cell); ret =mfd_add_devices (&dev->dev,PLATFORM_DEVID_AUTO , - &lpc_ich_cells[LPC_WDT ],1 ,NULL ,0 ,NULL ); + &lpc_ich_wdt_cell, 1, NULL, 0,NULL);
wdt_done:
return ret;
Signature · 2 lines
Andy Shevchenko <[email protected]> Intel Finland Oy
Quoted 4 lines · Aaron Sierra
The
lpc_ich_cellsarray gives the wrong impression about the relationship between the watchdog and GPIO devices. They are completely distinct devices, so this patch separates the array into distinctmfd_cellstructs per device.
What does this mean? In what way are they distinct?
Quoted 104 lines
A side effect of removing the array, is that the
lpc_cellsenum is no longer needed.Signed-off-by Aaron Sierra <[email protected]>--- drivers/mfd/lpc_ich.c | 42 ++++++++++++++++++------------------------ 1 file changed, 18 insertions(+), 24 deletions(-)drivers/mfd/lpc_ich.c +18
-24@@ -131,24 +131,18 @@ static struct resource gpio_ich_res[] = { }, }; -enum lpc_cells { -LPC_WDT =0 , -LPC_GPIO , +static struct mfd_cell lpc_ich_wdt_cell = { + .name ="iTCO_wdt" , + .num_resources =ARRAY_SIZE (wdt_ich_res), + .resources = wdt_ich_res, + .ignore_resource_conflicts = true, }; -static struct mfd_cell lpc_ich_cells[] = { - [LPC_WDT ] = { - .name ="iTCO_wdt" , - .num_resources =ARRAY_SIZE (wdt_ich_res), - .resources = wdt_ich_res, - .ignore_resource_conflicts = true, - }, - [LPC_GPIO ] = { - .name ="gpio_ich" , - .num_resources =ARRAY_SIZE (gpio_ich_res), - .resources = gpio_ich_res, - .ignore_resource_conflicts = true, - }, +static struct mfd_cell lpc_ich_gpio_cell = { + .name ="gpio_ich" , + .num_resources =ARRAY_SIZE (gpio_ich_res), + .resources = gpio_ich_res, + .ignore_resource_conflicts = true, };/* chipset related info */ @@ -881,7 +875,7 @@ static int lpc_ich_init_gpio(struct pci_dev *dev) base_addr = base_addr_cfg &0x0000ff80 ;if (!base_addr) {dev_notice (&dev->dev,"I/O space for ACPI uninitialized\n" ); - lpc_ich_cells[LPC_GPIO ].num_resources--; + lpc_ich_gpio_cell.num_resources--; goto gpe0_done; }@@ -895,7 +889,7 @@ static int lpc_ich_init_gpio(struct pci_dev *dev)* the platform_device subsystem doesn't see this resource * or it will register an invalid region. */ - lpc_ich_cells[LPC_GPIO ].num_resources--; + lpc_ich_gpio_cell.num_resources--; acpi_conflict = true; }else {lpc_ich_enable_acpi_space (dev);@@ -933,14 +927,14 @@ gpe0_done: lpc_chipset_info[priv->chipset].use_gpio = ret;lpc_ich_enable_gpio_space (dev); -lpc_ich_finalize_cell (dev, &lpc_ich_cells[LPC_GPIO ]); +lpc_ich_finalize_cell (dev, &lpc_ich_gpio_cell); ret =mfd_add_devices (&dev->dev,PLATFORM_DEVID_AUTO , - &lpc_ich_cells[LPC_GPIO ],1 ,NULL ,0 ,NULL ); + &lpc_ich_gpio_cell,1 ,NULL ,0 ,NULL ); gpio_done:if (acpi_conflict)pr_warn ("Resource conflict(s) found affecting %s\n" , - lpc_ich_cells[LPC_GPIO ].name); + lpc_ich_gpio_cell.name);return ret; }@@ -984,7 +978,7 @@ static int lpc_ich_init_wdt(struct pci_dev *dev)*/ if (lpc_chipset_info[priv->chipset].iTCO_version ==1 ) {/* Don't register iomem for TCO ver 1 */ - lpc_ich_cells[LPC_WDT ].num_resources--; + lpc_ich_wdt_cell.num_resources--; }else if (lpc_chipset_info[priv->chipset].iTCO_version ==2 ) {pci_read_config_dword (dev,RCBABASE , &base_addr_cfg); base_addr = base_addr_cfg &0xffffc000 ;@@ -1007,9 +1001,9 @@ static int lpc_ich_init_wdt(struct pci_dev *dev) res->end = base_addr +ACPIBASE_PMC_END ; } -lpc_ich_finalize_cell (dev, &lpc_ich_cells[LPC_WDT ]); +lpc_ich_finalize_cell (dev, &lpc_ich_wdt_cell); ret =mfd_add_devices (&dev->dev,PLATFORM_DEVID_AUTO , - &lpc_ich_cells[LPC_WDT ],1 ,NULL ,0 ,NULL ); + &lpc_ich_wdt_cell,1 ,NULL ,0 ,NULL ); wdt_done:return ret;
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
----- Original Message -----
Quoted 11 lines
From: "Lee Jones" <[email protected]>
Sent: Saturday, September 19, 2015 5:16:06 AMQuoted 4 lines · Aaron Sierra
The
lpc_ich_cellsarray gives the wrong impression about the relationship between the watchdog and GPIO devices. They are completely distinct devices, so this patch separates the array into distinctmfd_cellstructs per device.What does this mean? In what way are they distinct?
Lee,
This issue was discussed in late July regarding this patch Matt Fleming submitted:
[PATCH 1/5] iTCO_wdt: Expose watchdog properties using platform data
You asked why there were multiple calls to mfd_add_devices() in the driver. The reason that I provided was that the WDT cells can be registered even if the GPIO cells cannot. And vice versa.
Having their cells stored in the same array added to the illusion that a failure preparing/registering the cells of one should cause all cells to be unregistered.
-Aaron
Quoted 104 lines
Quoted 104 lines
A side effect of removing the array, is that the
lpc_cellsenum is no longer needed.Signed-off-by Aaron Sierra <[email protected]>--- drivers/mfd/lpc_ich.c | 42 ++++++++++++++++++------------------------ 1 file changed, 18 insertions(+), 24 deletions(-)drivers/mfd/lpc_ich.c +18
-24@@ -131,24 +131,18 @@ static struct resource gpio_ich_res[] = { }, }; -enum lpc_cells { -LPC_WDT =0 , -LPC_GPIO , +static struct mfd_cell lpc_ich_wdt_cell = { + .name ="iTCO_wdt" , + .num_resources =ARRAY_SIZE (wdt_ich_res), + .resources = wdt_ich_res, + .ignore_resource_conflicts = true, }; -static struct mfd_cell lpc_ich_cells[] = { - [LPC_WDT ] = { - .name ="iTCO_wdt" , - .num_resources =ARRAY_SIZE (wdt_ich_res), - .resources = wdt_ich_res, - .ignore_resource_conflicts = true, - }, - [LPC_GPIO ] = { - .name ="gpio_ich" , - .num_resources =ARRAY_SIZE (gpio_ich_res), - .resources = gpio_ich_res, - .ignore_resource_conflicts = true, - }, +static struct mfd_cell lpc_ich_gpio_cell = { + .name ="gpio_ich" , + .num_resources =ARRAY_SIZE (gpio_ich_res), + .resources = gpio_ich_res, + .ignore_resource_conflicts = true, };/* chipset related info */ @@ -881,7 +875,7 @@ static int lpc_ich_init_gpio(struct pci_dev *dev) base_addr = base_addr_cfg &0x0000ff80 ;if (!base_addr) {dev_notice (&dev->dev,"I/O space for ACPI uninitialized\n" ); - lpc_ich_cells[LPC_GPIO ].num_resources--; + lpc_ich_gpio_cell.num_resources--; goto gpe0_done; }@@ -895,7 +889,7 @@ static int lpc_ich_init_gpio(struct pci_dev *dev)* the platform_device subsystem doesn't see this resource * or it will register an invalid region. */ - lpc_ich_cells[LPC_GPIO ].num_resources--; + lpc_ich_gpio_cell.num_resources--; acpi_conflict = true; }else {lpc_ich_enable_acpi_space (dev);@@ -933,14 +927,14 @@ gpe0_done: lpc_chipset_info[priv->chipset].use_gpio = ret;lpc_ich_enable_gpio_space (dev); -lpc_ich_finalize_cell (dev, &lpc_ich_cells[LPC_GPIO ]); +lpc_ich_finalize_cell (dev, &lpc_ich_gpio_cell); ret =mfd_add_devices (&dev->dev,PLATFORM_DEVID_AUTO , - &lpc_ich_cells[LPC_GPIO ],1 ,NULL ,0 ,NULL ); + &lpc_ich_gpio_cell,1 ,NULL ,0 ,NULL ); gpio_done:if (acpi_conflict)pr_warn ("Resource conflict(s) found affecting %s\n" , - lpc_ich_cells[LPC_GPIO ].name); + lpc_ich_gpio_cell.name);return ret; }@@ -984,7 +978,7 @@ static int lpc_ich_init_wdt(struct pci_dev *dev)*/ if (lpc_chipset_info[priv->chipset].iTCO_version ==1 ) {/* Don't register iomem for TCO ver 1 */ - lpc_ich_cells[LPC_WDT ].num_resources--; + lpc_ich_wdt_cell.num_resources--; }else if (lpc_chipset_info[priv->chipset].iTCO_version ==2 ) {pci_read_config_dword (dev,RCBABASE , &base_addr_cfg); base_addr = base_addr_cfg &0xffffc000 ;@@ -1007,9 +1001,9 @@ static int lpc_ich_init_wdt(struct pci_dev *dev) res->end = base_addr +ACPIBASE_PMC_END ; } -lpc_ich_finalize_cell (dev, &lpc_ich_cells[LPC_WDT ]); +lpc_ich_finalize_cell (dev, &lpc_ich_wdt_cell); ret =mfd_add_devices (&dev->dev,PLATFORM_DEVID_AUTO , - &lpc_ich_cells[LPC_WDT ],1 ,NULL ,0 ,NULL ); + &lpc_ich_wdt_cell,1 ,NULL ,0 ,NULL ); wdt_done:return ret;
Lee Jones
AppliedQuoted 5 lines · Aaron Sierra
The
lpc_ich_cellsarray gives the wrong impression about the relationship between the watchdog and GPIO devices. They are completely distinct devices, so this patch separates the array into distinctmfd_cellstructs per device.
Quoted 7 lines
A side effect of removing the array, is that the
lpc_cellsenum is no longer needed.Signed-off-by Aaron Sierra <[email protected]>--- drivers/mfd/lpc_ich.c | 42 ++++++++++++++++++------------------------ 1 file changed, 18 insertions(+), 24 deletions(-)
Applied, thanks.
Quoted 96 lines
drivers/mfd/lpc_ich.c +18
-24@@ -131,24 +131,18 @@ static struct resource gpio_ich_res[] = { }, }; -enum lpc_cells { -LPC_WDT =0 , -LPC_GPIO , +static struct mfd_cell lpc_ich_wdt_cell = { + .name ="iTCO_wdt" , + .num_resources =ARRAY_SIZE (wdt_ich_res), + .resources = wdt_ich_res, + .ignore_resource_conflicts = true, }; -static struct mfd_cell lpc_ich_cells[] = { - [LPC_WDT ] = { - .name ="iTCO_wdt" , - .num_resources =ARRAY_SIZE (wdt_ich_res), - .resources = wdt_ich_res, - .ignore_resource_conflicts = true, - }, - [LPC_GPIO ] = { - .name ="gpio_ich" , - .num_resources =ARRAY_SIZE (gpio_ich_res), - .resources = gpio_ich_res, - .ignore_resource_conflicts = true, - }, +static struct mfd_cell lpc_ich_gpio_cell = { + .name ="gpio_ich" , + .num_resources =ARRAY_SIZE (gpio_ich_res), + .resources = gpio_ich_res, + .ignore_resource_conflicts = true, };/* chipset related info */ @@ -881,7 +875,7 @@ static int lpc_ich_init_gpio(struct pci_dev *dev) base_addr = base_addr_cfg &0x0000ff80 ;if (!base_addr) {dev_notice (&dev->dev,"I/O space for ACPI uninitialized\n" ); - lpc_ich_cells[LPC_GPIO ].num_resources--; + lpc_ich_gpio_cell.num_resources--; goto gpe0_done; }@@ -895,7 +889,7 @@ static int lpc_ich_init_gpio(struct pci_dev *dev)* the platform_device subsystem doesn't see this resource * or it will register an invalid region. */ - lpc_ich_cells[LPC_GPIO ].num_resources--; + lpc_ich_gpio_cell.num_resources--; acpi_conflict = true; }else {lpc_ich_enable_acpi_space (dev);@@ -933,14 +927,14 @@ gpe0_done: lpc_chipset_info[priv->chipset].use_gpio = ret;lpc_ich_enable_gpio_space (dev); -lpc_ich_finalize_cell (dev, &lpc_ich_cells[LPC_GPIO ]); +lpc_ich_finalize_cell (dev, &lpc_ich_gpio_cell); ret =mfd_add_devices (&dev->dev,PLATFORM_DEVID_AUTO , - &lpc_ich_cells[LPC_GPIO ],1 ,NULL ,0 ,NULL ); + &lpc_ich_gpio_cell,1 ,NULL ,0 ,NULL ); gpio_done:if (acpi_conflict)pr_warn ("Resource conflict(s) found affecting %s\n" , - lpc_ich_cells[LPC_GPIO ].name); + lpc_ich_gpio_cell.name);return ret; }@@ -984,7 +978,7 @@ static int lpc_ich_init_wdt(struct pci_dev *dev)*/ if (lpc_chipset_info[priv->chipset].iTCO_version ==1 ) {/* Don't register iomem for TCO ver 1 */ - lpc_ich_cells[LPC_WDT ].num_resources--; + lpc_ich_wdt_cell.num_resources--; }else if (lpc_chipset_info[priv->chipset].iTCO_version ==2 ) {pci_read_config_dword (dev,RCBABASE , &base_addr_cfg); base_addr = base_addr_cfg &0xffffc000 ;@@ -1007,9 +1001,9 @@ static int lpc_ich_init_wdt(struct pci_dev *dev) res->end = base_addr +ACPIBASE_PMC_END ; } -lpc_ich_finalize_cell (dev, &lpc_ich_cells[LPC_WDT ]); +lpc_ich_finalize_cell (dev, &lpc_ich_wdt_cell); ret =mfd_add_devices (&dev->dev,PLATFORM_DEVID_AUTO , - &lpc_ich_cells[LPC_WDT ],1 ,NULL ,0 ,NULL ); + &lpc_ich_wdt_cell,1 ,NULL ,0 ,NULL ); wdt_done:return ret;
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Quoted 5 lines · Aaron Sierra
The
lpc_ich_cellsarray gives the wrong impression about the relationship between the watchdog and GPIO devices. They are completely distinct devices, so this patch separates the array into distinctmfd_cellstructs per device.
Quoted 7 lines
A side effect of removing the array, is that the
lpc_cellsenum is no longer needed.Signed-off-by Aaron Sierra <[email protected]>--- drivers/mfd/lpc_ich.c | 42 ++++++++++++++++++------------------------ 1 file changed, 18 insertions(+), 24 deletions(-)
You need to rebase this. It doesn't apply.
Quoted 96 lines
drivers/mfd/lpc_ich.c +18
-24@@ -131,24 +131,18 @@ static struct resource gpio_ich_res[] = { }, }; -enum lpc_cells { -LPC_WDT =0 , -LPC_GPIO , +static struct mfd_cell lpc_ich_wdt_cell = { + .name ="iTCO_wdt" , + .num_resources =ARRAY_SIZE (wdt_ich_res), + .resources = wdt_ich_res, + .ignore_resource_conflicts = true, }; -static struct mfd_cell lpc_ich_cells[] = { - [LPC_WDT ] = { - .name ="iTCO_wdt" , - .num_resources =ARRAY_SIZE (wdt_ich_res), - .resources = wdt_ich_res, - .ignore_resource_conflicts = true, - }, - [LPC_GPIO ] = { - .name ="gpio_ich" , - .num_resources =ARRAY_SIZE (gpio_ich_res), - .resources = gpio_ich_res, - .ignore_resource_conflicts = true, - }, +static struct mfd_cell lpc_ich_gpio_cell = { + .name ="gpio_ich" , + .num_resources =ARRAY_SIZE (gpio_ich_res), + .resources = gpio_ich_res, + .ignore_resource_conflicts = true, };/* chipset related info */ @@ -881,7 +875,7 @@ static int lpc_ich_init_gpio(struct pci_dev *dev) base_addr = base_addr_cfg &0x0000ff80 ;if (!base_addr) {dev_notice (&dev->dev,"I/O space for ACPI uninitialized\n" ); - lpc_ich_cells[LPC_GPIO ].num_resources--; + lpc_ich_gpio_cell.num_resources--; goto gpe0_done; }@@ -895,7 +889,7 @@ static int lpc_ich_init_gpio(struct pci_dev *dev)* the platform_device subsystem doesn't see this resource * or it will register an invalid region. */ - lpc_ich_cells[LPC_GPIO ].num_resources--; + lpc_ich_gpio_cell.num_resources--; acpi_conflict = true; }else {lpc_ich_enable_acpi_space (dev);@@ -933,14 +927,14 @@ gpe0_done: lpc_chipset_info[priv->chipset].use_gpio = ret;lpc_ich_enable_gpio_space (dev); -lpc_ich_finalize_cell (dev, &lpc_ich_cells[LPC_GPIO ]); +lpc_ich_finalize_cell (dev, &lpc_ich_gpio_cell); ret =mfd_add_devices (&dev->dev,PLATFORM_DEVID_AUTO , - &lpc_ich_cells[LPC_GPIO ],1 ,NULL ,0 ,NULL ); + &lpc_ich_gpio_cell,1 ,NULL ,0 ,NULL ); gpio_done:if (acpi_conflict)pr_warn ("Resource conflict(s) found affecting %s\n" , - lpc_ich_cells[LPC_GPIO ].name); + lpc_ich_gpio_cell.name);return ret; }@@ -984,7 +978,7 @@ static int lpc_ich_init_wdt(struct pci_dev *dev)*/ if (lpc_chipset_info[priv->chipset].iTCO_version ==1 ) {/* Don't register iomem for TCO ver 1 */ - lpc_ich_cells[LPC_WDT ].num_resources--; + lpc_ich_wdt_cell.num_resources--; }else if (lpc_chipset_info[priv->chipset].iTCO_version ==2 ) {pci_read_config_dword (dev,RCBABASE , &base_addr_cfg); base_addr = base_addr_cfg &0xffffc000 ;@@ -1007,9 +1001,9 @@ static int lpc_ich_init_wdt(struct pci_dev *dev) res->end = base_addr +ACPIBASE_PMC_END ; } -lpc_ich_finalize_cell (dev, &lpc_ich_cells[LPC_WDT ]); +lpc_ich_finalize_cell (dev, &lpc_ich_wdt_cell); ret =mfd_add_devices (&dev->dev,PLATFORM_DEVID_AUTO , - &lpc_ich_cells[LPC_WDT ],1 ,NULL ,0 ,NULL ); + &lpc_ich_wdt_cell,1 ,NULL ,0 ,NULL ); wdt_done:return ret;
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH v2 1/1 mfd: lpc_ich: Separate device cells for clarity
In reply to Aaron SierraThe lpc_ich_cells array gives the wrong impression about the relationship between the watchdog and GPIO devices. They are completely distinct devices, so this patch separates the array into distinct mfd_cell structs per device.
A side effect of removing the array, is that the lpc_cells enum is no longer needed.
---
v2 - rebase onto 4.3-rc2
drivers/mfd/lpc_ich.c | 42 ++++++++++++++++++------------------------ 1 file changed, 18 insertions(+), 24 deletions(-)
drivers/mfd/lpc_ich.c +18 -24
@@ -132,24 +132,18 @@ static struct resource gpio_ich_res[] = { }, }; -enum lpc_cells { -LPC_WDT =0 , -LPC_GPIO , +static struct mfd_cell lpc_ich_wdt_cell = { + .name ="iTCO_wdt" , + .num_resources =ARRAY_SIZE (wdt_ich_res), + .resources = wdt_ich_res, + .ignore_resource_conflicts = true, }; -static struct mfd_cell lpc_ich_cells[] = { - [LPC_WDT ] = { - .name ="iTCO_wdt" , - .num_resources =ARRAY_SIZE (wdt_ich_res), - .resources = wdt_ich_res, - .ignore_resource_conflicts = true, - }, - [LPC_GPIO ] = { - .name ="gpio_ich" , - .num_resources =ARRAY_SIZE (gpio_ich_res), - .resources = gpio_ich_res, - .ignore_resource_conflicts = true, - }, +static struct mfd_cell lpc_ich_gpio_cell = { + .name ="gpio_ich" , + .num_resources =ARRAY_SIZE (gpio_ich_res), + .resources = gpio_ich_res, + .ignore_resource_conflicts = true, };/* chipset related info */
@@ -841,7 +835,7 @@ static int lpc_ich_finalize_wdt_cell(struct pci_dev *dev)struct itco_wdt_platform_data *pdata;struct lpc_ich_priv *priv =pci_get_drvdata (dev);struct lpc_ich_info *info; -struct mfd_cell *cell = &lpc_ich_cells[LPC_WDT ]; +struct mfd_cell *cell = &lpc_ich_wdt_cell; pdata =devm_kzalloc (&dev->dev,sizeof (*pdata),GFP_KERNEL );if (!pdata)
@@ -860,7 +854,7 @@ static int lpc_ich_finalize_wdt_cell(struct pci_dev *dev)static void lpc_ich_finalize_gpio_cell (struct pci_dev *dev) {struct lpc_ich_priv *priv =pci_get_drvdata (dev); -struct mfd_cell *cell = &lpc_ich_cells[LPC_GPIO ]; +struct mfd_cell *cell = &lpc_ich_gpio_cell; cell->platform_data = &lpc_chipset_info[priv->chipset]; cell->pdata_size =sizeof (struct lpc_ich_info );
@@ -904,7 +898,7 @@ static int lpc_ich_init_gpio(struct pci_dev *dev) base_addr = base_addr_cfg &0x0000ff80 ;if (!base_addr) {dev_notice (&dev->dev,"I/O space for ACPI uninitialized\n" ); - lpc_ich_cells[LPC_GPIO ].num_resources--; + lpc_ich_gpio_cell.num_resources--; goto gpe0_done; }
@@ -918,7 +912,7 @@ static int lpc_ich_init_gpio(struct pci_dev *dev)* the platform_device subsystem doesn't see this resource * or it will register an invalid region. */ - lpc_ich_cells[LPC_GPIO ].num_resources--; + lpc_ich_gpio_cell.num_resources--; acpi_conflict = true; }else {lpc_ich_enable_acpi_space (dev);
@@ -958,12 +952,12 @@ gpe0_done:lpc_ich_finalize_gpio_cell (dev); ret =mfd_add_devices (&dev->dev,PLATFORM_DEVID_AUTO , - &lpc_ich_cells[LPC_GPIO ],1 ,NULL ,0 ,NULL ); + &lpc_ich_gpio_cell,1 ,NULL ,0 ,NULL ); gpio_done:if (acpi_conflict)pr_warn ("Resource conflict(s) found affecting %s\n" , - lpc_ich_cells[LPC_GPIO ].name); + lpc_ich_gpio_cell.name);return ret; }
@@ -1007,7 +1001,7 @@ static int lpc_ich_init_wdt(struct pci_dev *dev)*/ if (lpc_chipset_info[priv->chipset].iTCO_version ==1 ) {/* Don't register iomem for TCO ver 1 */ - lpc_ich_cells[LPC_WDT ].num_resources--; + lpc_ich_wdt_cell.num_resources--; }else if (lpc_chipset_info[priv->chipset].iTCO_version ==2 ) {pci_read_config_dword (dev,RCBABASE , &base_addr_cfg); base_addr = base_addr_cfg &0xffffc000 ;
@@ -1035,7 +1029,7 @@ static int lpc_ich_init_wdt(struct pci_dev *dev) goto wdt_done; ret =mfd_add_devices (&dev->dev,PLATFORM_DEVID_AUTO , - &lpc_ich_cells[LPC_WDT ],1 ,NULL ,0 ,NULL ); + &lpc_ich_wdt_cell,1 ,NULL ,0 ,NULL ); wdt_done:return ret;
Signature · 1 line
1.9.1
Quoted 8 lines · Aaron Sierra
The
lpc_ich_cellsarray gives the wrong impression about the relationship between the watchdog and GPIO devices. They are completely distinct devices, so this patch separates the array into distinctmfd_cellstructs per device.A side effect of removing the array, is that the
lpc_cellsenum is no longer needed.
Quoted 6 lines
Signed-off-by Aaron Sierra <[email protected]>---
v2 - rebase onto 4.3-rc2drivers/mfd/lpc_ich.c | 42 ++++++++++++++++++------------------------ 1 file changed, 18 insertions(+), 24 deletions(-)
Looks like you didn't apply Andy's Ack!
Applied with Andy's Ack.
Quoted 108 lines
drivers/mfd/lpc_ich.c +18
-24@@ -132,24 +132,18 @@ static struct resource gpio_ich_res[] = { }, }; -enum lpc_cells { -LPC_WDT =0 , -LPC_GPIO , +static struct mfd_cell lpc_ich_wdt_cell = { + .name ="iTCO_wdt" , + .num_resources =ARRAY_SIZE (wdt_ich_res), + .resources = wdt_ich_res, + .ignore_resource_conflicts = true, }; -static struct mfd_cell lpc_ich_cells[] = { - [LPC_WDT ] = { - .name ="iTCO_wdt" , - .num_resources =ARRAY_SIZE (wdt_ich_res), - .resources = wdt_ich_res, - .ignore_resource_conflicts = true, - }, - [LPC_GPIO ] = { - .name ="gpio_ich" , - .num_resources =ARRAY_SIZE (gpio_ich_res), - .resources = gpio_ich_res, - .ignore_resource_conflicts = true, - }, +static struct mfd_cell lpc_ich_gpio_cell = { + .name ="gpio_ich" , + .num_resources =ARRAY_SIZE (gpio_ich_res), + .resources = gpio_ich_res, + .ignore_resource_conflicts = true, };/* chipset related info */ @@ -841,7 +835,7 @@ static int lpc_ich_finalize_wdt_cell(struct pci_dev *dev)struct itco_wdt_platform_data *pdata;struct lpc_ich_priv *priv =pci_get_drvdata (dev);struct lpc_ich_info *info; -struct mfd_cell *cell = &lpc_ich_cells[LPC_WDT ]; +struct mfd_cell *cell = &lpc_ich_wdt_cell; pdata =devm_kzalloc (&dev->dev,sizeof (*pdata),GFP_KERNEL );if (!pdata)@@ -860,7 +854,7 @@ static int lpc_ich_finalize_wdt_cell(struct pci_dev *dev)static void lpc_ich_finalize_gpio_cell (struct pci_dev *dev) {struct lpc_ich_priv *priv =pci_get_drvdata (dev); -struct mfd_cell *cell = &lpc_ich_cells[LPC_GPIO ]; +struct mfd_cell *cell = &lpc_ich_gpio_cell; cell->platform_data = &lpc_chipset_info[priv->chipset]; cell->pdata_size =sizeof (struct lpc_ich_info );@@ -904,7 +898,7 @@ static int lpc_ich_init_gpio(struct pci_dev *dev) base_addr = base_addr_cfg &0x0000ff80 ;if (!base_addr) {dev_notice (&dev->dev,"I/O space for ACPI uninitialized\n" ); - lpc_ich_cells[LPC_GPIO ].num_resources--; + lpc_ich_gpio_cell.num_resources--; goto gpe0_done; }@@ -918,7 +912,7 @@ static int lpc_ich_init_gpio(struct pci_dev *dev)* the platform_device subsystem doesn't see this resource * or it will register an invalid region. */ - lpc_ich_cells[LPC_GPIO ].num_resources--; + lpc_ich_gpio_cell.num_resources--; acpi_conflict = true; }else {lpc_ich_enable_acpi_space (dev);@@ -958,12 +952,12 @@ gpe0_done:lpc_ich_finalize_gpio_cell (dev); ret =mfd_add_devices (&dev->dev,PLATFORM_DEVID_AUTO , - &lpc_ich_cells[LPC_GPIO ],1 ,NULL ,0 ,NULL ); + &lpc_ich_gpio_cell,1 ,NULL ,0 ,NULL ); gpio_done:if (acpi_conflict)pr_warn ("Resource conflict(s) found affecting %s\n" , - lpc_ich_cells[LPC_GPIO ].name); + lpc_ich_gpio_cell.name);return ret; }@@ -1007,7 +1001,7 @@ static int lpc_ich_init_wdt(struct pci_dev *dev)*/ if (lpc_chipset_info[priv->chipset].iTCO_version ==1 ) {/* Don't register iomem for TCO ver 1 */ - lpc_ich_cells[LPC_WDT ].num_resources--; + lpc_ich_wdt_cell.num_resources--; }else if (lpc_chipset_info[priv->chipset].iTCO_version ==2 ) {pci_read_config_dword (dev,RCBABASE , &base_addr_cfg); base_addr = base_addr_cfg &0xffffc000 ;@@ -1035,7 +1029,7 @@ static int lpc_ich_init_wdt(struct pci_dev *dev) goto wdt_done; ret =mfd_add_devices (&dev->dev,PLATFORM_DEVID_AUTO , - &lpc_ich_cells[LPC_WDT ],1 ,NULL ,0 ,NULL ); + &lpc_ich_wdt_cell,1 ,NULL ,0 ,NULL ); wdt_done:return ret;
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
----- Original Message -----
Quoted 13 lines
From: "Lee Jones" <[email protected]>
Sent: Tuesday, September 22, 2015 7:31:19 PMQuoted 8 lines · Aaron Sierra
The
lpc_ich_cellsarray gives the wrong impression about the relationship between the watchdog and GPIO devices. They are completely distinct devices, so this patch separates the array into distinctmfd_cellstructs per device.A side effect of removing the array, is that the
lpc_cellsenum is no longer needed.
Quoted 8 lines
Quoted 6 lines
Signed-off-by Aaron Sierra <[email protected]>---
v2 - rebase onto 4.3-rc2drivers/mfd/lpc_ich.c | 42 ++++++++++++++++++------------------------ 1 file changed, 18 insertions(+), 24 deletions(-)Looks like you didn't apply Andy's Ack!
Sorry, Andy! I erred on the side of caution. I wasn't sure if the Ack applied to the concept or the iteration of the patch.
Quoted 1 line
Applied with Andy's Ack.
Thanks
-Aaron