Skip to contentSkip to conversation

hw/pci-host/piix: fix one file descriptor leak

PATCH New Tiejun Chen 1 participant 1 message Sep 18, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/pci-host/piix: fix one file descriptor leak

Commit 595a4f07d6bd (piix: create host bridge to passthrough) introduced to leak of one file descriptor, "config_fd", now just fix that.

CC Michael S. Tsirkin <[email protected]>
CC Stefano Stabellini <[email protected]>
CC Paolo Bonzini <[email protected]>
---
 hw/pci-host/piix.c | 3 +++
 1 file changed, 3 insertions(+)
hw/pci-host/piix.c +3 -0
index 1fb71c8..7d44228 100644
@@ -775,15 +775,18 @@ static int host_pci_config_read(int pos, int len, uint32_t val)
     }
 
     if (lseek(config_fd, pos, SEEK_SET) != pos) {
+        close(config_fd);
         return -errno;
     }
     do {
         rc = read(config_fd, (uint8_t *)&val, len);
     } while (rc < 0 && (errno == EINTR || errno == EAGAIN));
     if (rc != len) {
+        close(config_fd);
         return -errno;
     }
 
+    close(config_fd);
     return 0;
 }
 
Signature · 1 line
1.9.1