selinux: do not check open perm on ftruncate call
PATCH v2 1/1 selinux: do not check open perm on ftruncate call
Use the ATTR_FILE attribute to distinguish between truncate() and ftruncate() system calls. The two other cases where do_truncate is called with a filp (and therefore ATTR_FILE is set) are for coredump files and for open(O_TRUNC). In both of those cases the open permission has already been checked during file open and therefore does not need to be repeated.
Commit 95dbf739313f ("SELinux: check OPEN on truncate calls") fixed a major issue where domains were allowed to truncate files without the open permission. However, it introduced a new bug where a domain with the write permission can no longer ftruncate files without the open permission, even when they receive an already open file.
---
V2 fixes mistakes in commit message
security/selinux/hooks.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
security/selinux/hooks.c +2 -1
@@ -2934,7 +2934,8 @@ static int selinux_inode_setattr(struct dentry *dentry, struct iattr *iattr) ATTR_ATIME_SET | ATTR_MTIME_SET | ATTR_TIMES_SET))return dentry_has_perm (cred, dentry,FILE__SETATTR ); -if (selinux_policycap_openperm && (ia_valid &ATTR_SIZE )) +if (selinux_policycap_openperm && (ia_valid &ATTR_SIZE ) + && !(ia_valid &ATTR_FILE )) av |=FILE__OPEN ;return dentry_has_perm (cred, dentry, av);
Signature · 1 line
2.6.0.rc0.131.gf624c3d
Quoted 7 lines · Jeff Vander Stoep
Use the
ATTR_FILEattribute to distinguish betweentruncate()andftruncate()system calls. The two other cases wheredo_truncateis called with a filp (and thereforeATTR_FILEis set) are for coredump files and foropen(O_TRUNC). In both of those cases the open permission has already been checked during file open and therefore does not need to be repeated.
Quoted 8 lines
Commit
95dbf739313f("SELinux: check OPEN on truncate calls") fixed a major issue where domains were allowed to truncate files without the open permission. However, it introduced a new bug where a domain with the write permission can no longer ftruncate files without the open permission, even when they receive an already open file.Signed-off-by Jeff Vander Stoep <[email protected]>
Quoted 21 lines
---
V2 fixes mistakes in commit messagesecurity/selinux/hooks.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)security/selinux/hooks.c +2
-1@@ -2934,7 +2934,8 @@ static int selinux_inode_setattr(struct dentry *dentry, struct iattr *iattr) ATTR_ATIME_SET | ATTR_MTIME_SET | ATTR_TIMES_SET))return dentry_has_perm (cred, dentry,FILE__SETATTR ); -if (selinux_policycap_openperm && (ia_valid &ATTR_SIZE )) +if (selinux_policycap_openperm && (ia_valid &ATTR_SIZE ) + && !(ia_valid &ATTR_FILE )) av |=FILE__OPEN ;return dentry_has_perm (cred, dentry, av);
Quoted 14 lines · Jeff Vander Stoep
Use the
ATTR_FILEattribute to distinguish betweentruncate()andftruncate()system calls. The two other cases wheredo_truncateis called with a filp (and thereforeATTR_FILEis set) are for coredump files and foropen(O_TRUNC). In both of those cases the open permission has already been checked during file open and therefore does not need to be repeated.Commit
95dbf739313f("SELinux: check OPEN on truncate calls") fixed a major issue where domains were allowed to truncate files without the open permission. However, it introduced a new bug where a domain with the write permission can no longer ftruncate files without the open permission, even when they receive an already open file.
Quoted 6 lines
Signed-off-by Jeff Vander Stoep <[email protected]>---
V2 fixes mistakes in commit messagesecurity/selinux/hooks.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Applied, thanks.
Quoted 15 lines
security/selinux/hooks.c +2
-1@@ -2934,7 +2934,8 @@ static int selinux_inode_setattr(struct dentry *dentry, struct iattr *iattr) ATTR_ATIME_SET | ATTR_MTIME_SET | ATTR_TIMES_SET))return dentry_has_perm (cred, dentry,FILE__SETATTR ); -if (selinux_policycap_openperm && (ia_valid &ATTR_SIZE )) +if (selinux_policycap_openperm && (ia_valid &ATTR_SIZE ) + && !(ia_valid &ATTR_FILE )) av |=FILE__OPEN ;return
dentry_has_perm(cred, dentry, av);
Signature · 2 lines
paul moore www.paul-moore.com