Skip to contentSkip to conversation

Patch "ARM: rockchip: fix broken build" has been added to the 4.1-stable tree

PATCH [email protected] 1 participant 1 message Sep 21, 2015

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ARM: rockchip: fix broken build

to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
arm-rockchip-fix-broken-build.patch
and it can be found in the queue-4.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From cb8cc37f4d38d96552f2c52deb15e511cdacf906 Mon Sep 17 00:00:00 2001

From: Caesar Wang <[email protected]>
Date: Mon, 6 Jul 2015 11:37:23 +0800
Subject: ARM: rockchip: fix broken build

From: Caesar Wang <[email protected]>

commit cb8cc37f4d38d96552f2c52deb15e511cdacf906 upstream.

The following was seen in branch[0] build.

arch/arm/mach-rockchip/platsmp.c:154:23: error:
'rockchip_secondary_startup' undeclared (first use in this function)

branch[0]:
git://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git
v4.3-armsoc/soc

The broken build is caused by the commit fe4407c0dc58 ("ARM: rockchip: fix the CPU soft reset").

The breakage was a result of it being wrongly merged in my branch with the cache invalidation rework from Russell 02b4e2756e01c ("ARM: v7 setup function should invalidate L1 cache").

---
 arch/arm/mach-rockchip/platsmp.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/mach-rockchip/platsmp.c +1 -2
@@ -152,8 +152,7 @@ static int __cpuinit rockchip_boot_secon
 		 * */
 		mdelay(1); /* ensure the cpus other than cpu0 to startup */
 
-		writel(virt_to_phys(rockchip_secondary_startup),
-			sram_base_addr + 8);
+		writel(virt_to_phys(secondary_startup), sram_base_addr + 8);
 		writel(0xDEADBEAF, sram_base_addr + 4);
 		dsb_sev();
 	}

Patches currently in stable-queue which might be from [email protected] are

queue-4.1/arm-rockchip-fix-broken-build.patch queue-4.1/arm-rockchip-fix-the-cpu-soft-reset.patch