drm/i915/bxt: Set time interval unit to 0.833us
Subsystems (2)
PATCH 1/1 drm/i915/bxt: Set time interval unit to 0.833us
From: Akash Goel <[email protected]>
--- drivers/gpu/drm/i915/i915_reg.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_reg.h +4 -1
@@ -2802,8 +2802,11 @@ enum skl_disp_power_wells {#define INTERVAL_1_28_US (us) (((us) * 100) >> 7)#define INTERVAL_1_33_US (us) (((us) * 3) >> 2) +#define INTERVAL_0_833_US (us) (((us) * 6) / 5)#define GT_INTERVAL_FROM_US (dev_priv, us) (IS_GEN9(dev_priv) ? \ - INTERVAL_1_33_US(us) : \ + (IS_BROXTON(dev_priv) ? \ + INTERVAL_0_833_US(us) : \ + INTERVAL_1_33_US(us)) : \ INTERVAL_1_28_US(us))/*
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 14 lines · Sagar Arun Kamble
From: Akash Goel <[email protected]>
Signed-off-by Ankitprasad Sharma <[email protected]>Signed-off-by Akash Goel <[email protected]>Signed-off-by Sagar Arun Kamble <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_reg.h +0
-0
drivers/gpu/drm/i915/i915_reg.h enum skl_disp_power_wells { · line 2810
Quoted 10 lines
drivers/gpu/drm/i915/i915_reg.h +4
-1@@ -2802,8 +2802,11 @@ enum skl_disp_power_wells {#define INTERVAL_1_28_US (us) (((us) * 100) >> 7)#define INTERVAL_1_33_US (us) (((us) * 3) >> 2) +#define INTERVAL_0_833_US (us) (((us) * 6) / 5)#define GT_INTERVAL_FROM_US (dev_priv, us) (IS_GEN9(dev_priv) ? \ - INTERVAL_1_33_US(us) : \ + (IS_BROXTON(dev_priv) ? \ + INTERVAL_0_833_US(us) : \ + INTERVAL_1_33_US(us)) : \ INTERVAL_1_28_US(us))
Note that neither of the GEN9 values are mentioned in Bspec, so a request for update should be filed there. I haven't found any other place that would document this either, could you point me to it?
--Imre
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 5 lines · Sagar Arun Kamble
From: Akash Goel <[email protected]>
Signed-off-by Ankitprasad Sharma <[email protected]>Signed-off-by Akash Goel <[email protected]>Signed-off-by Sagar Arun Kamble <[email protected]>
The comment about units in gen6_set_rps_thresholds() is outdated, so you could update that while at it. In any case this looks ok, so:
Quoted 11 lines
--- drivers/gpu/drm/i915/i915_reg.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_reg.h +0
-0@@ -2802,8 +2802,11 @@ enum skl_disp_power_wells {#define INTERVAL_1_28_US (us) (((us) * 100) >> 7)
drivers/gpu/drm/i915/i915_reg.h enum skl_disp_power_wells { · line 2812
Quoted 10 lines
drivers/gpu/drm/i915/i915_reg.h +4
-1#define INTERVAL_1_33_US (us) (((us) * 3) >> 2) +#define INTERVAL_0_833_US (us) (((us) * 6) / 5)#define GT_INTERVAL_FROM_US (dev_priv, us) (IS_GEN9(dev_priv) ? \ - INTERVAL_1_33_US(us) : \ + (IS_BROXTON(dev_priv) ? \ + INTERVAL_0_833_US(us) : \ + INTERVAL_1_33_US(us)) : \ INTERVAL_1_28_US(us))/*
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 10 lines · Imre Deak
Quoted 5 lines · Sagar Arun Kamble
From: Akash Goel <[email protected]>
Signed-off-by Ankitprasad Sharma <[email protected]>Signed-off-by Akash Goel <[email protected]>Signed-off-by Sagar Arun Kamble <[email protected]>The comment about units in
gen6_set_rps_thresholds()is outdated, so you could update that while at it. In any case this looks ok, so:Reviewed-by Imre Deak <[email protected]>
In your previous review you noticed that Bspec is still outdated. Has that been fixed meanwhile?
-Daniel
Quoted 28 lines
Quoted 12 lines
--- drivers/gpu/drm/i915/i915_reg.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_reg.h +0
-0@@ -2802,8 +2802,11 @@ enum skl_disp_power_wells {#define INTERVAL_1_28_US (us) (((us) * 100) >> 7)drivers/gpu/drm/i915/i915_reg.h enum skl_disp_power_wells { · line 2812
Quoted 10 lines
drivers/gpu/drm/i915/i915_reg.h +4
-1#define INTERVAL_1_33_US (us) (((us) * 3) >> 2) +#define INTERVAL_0_833_US (us) (((us) * 6) / 5)#define GT_INTERVAL_FROM_US (dev_priv, us) (IS_GEN9(dev_priv) ? \ - INTERVAL_1_33_US(us) : \ + (IS_BROXTON(dev_priv) ? \ + INTERVAL_0_833_US(us) : \ + INTERVAL_1_33_US(us)) : \ INTERVAL_1_28_US(us))/* _______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 8 lines · Daniel Vetter
Quoted 7 lines · Imre Deak
Quoted 5 lines · Sagar Arun Kamble
From: Akash Goel <[email protected]>
Signed-off-by Ankitprasad Sharma <[email protected]>Signed-off-by Akash Goel <[email protected]>Signed-off-by Sagar Arun Kamble <[email protected]>
Quoted 6 lines
Quoted 3 lines
The comment about units in
gen6_set_rps_thresholds()is outdated, so you could update that while at it. In any case this looks ok, so:Reviewed-by Imre Deak <[email protected]>In your previous review you noticed that Bspec is still outdated. Has that been fixed meanwhile?
Yep, Sagar pointed to a page in BSpec where the relevant clocks are defined ("Timestamp bases") and he also filed a change request in Bspec now to update the register description itself accordingly. Should've mentioned this when adding my r-b.
--Imre
Quoted 31 lines
-Daniel
Quoted 28 lines
Quoted 12 lines
--- drivers/gpu/drm/i915/i915_reg.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_reg.h +0
-0@@ -2802,8 +2802,11 @@ enum skl_disp_power_wells {#define INTERVAL_1_28_US (us) (((us) * 100) >> 7)drivers/gpu/drm/i915/i915_reg.h enum skl_disp_power_wells { · line 2812
Quoted 10 lines
drivers/gpu/drm/i915/i915_reg.h +4
-1#define INTERVAL_1_33_US (us) (((us) * 3) >> 2) +#define INTERVAL_0_833_US (us) (((us) * 6) / 5)#define GT_INTERVAL_FROM_US (dev_priv, us) (IS_GEN9(dev_priv) ? \ - INTERVAL_1_33_US(us) : \ + (IS_BROXTON(dev_priv) ? \ + INTERVAL_0_833_US(us) : \ + INTERVAL_1_33_US(us)) : \ INTERVAL_1_28_US(us))/* _______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 13 lines · Imre Deak
Quoted 12 lines · Daniel Vetter
Quoted 10 lines · Imre Deak
Quoted 5 lines · Sagar Arun Kamble
From: Akash Goel <[email protected]>
Signed-off-by Ankitprasad Sharma <[email protected]>Signed-off-by Akash Goel <[email protected]>Signed-off-by Sagar Arun Kamble <[email protected]>The comment about units in
gen6_set_rps_thresholds()is outdated, so you could update that while at it. In any case this looks ok, so:Reviewed-by Imre Deak <[email protected]>
Quoted 7 lines
Quoted 2 lines
In your previous review you noticed that Bspec is still outdated. Has that been fixed meanwhile?
Yep, Sagar pointed to a page in BSpec where the relevant clocks are defined ("Timestamp bases") and he also filed a change request in Bspec now to update the register description itself accordingly. Should've mentioned this when adding my r-b.
Awesome. Added a note about this and applied the patch.
Thanks, Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx