Skip to contentSkip to conversation

libgcc.inc: package baremetal multilib libraries

PATCH Superseded Juro Bystricky 3 participants 6 messages Sep 14, 2015 – Sep 21, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libgcc.inc: package baremetal multilib libraries

When building libgcc for baremetal cross-compilers, some files and libraries may be built but not packaged. This patch fixes errors such as these:

ERROR: QA Issue: libgcc: Files/directories were installed but not shipped in any package:
/usr/lib/arm-poky-eabi/4.9.3/thumb
/usr/lib/arm-poky-eabi/4.9.3/fpu /usr/lib/arm-poky-eabi/4.9.3/thumb/libgcov.a /usr/lib/arm-poky-eabi/4.9.3/thumb/crtn.o /usr/lib/arm-poky-eabi/4.9.3/thumb/crtend.o /usr/lib/arm-poky-eabi/4.9.3/thumb/crtbegin.o /usr/lib/arm-poky-eabi/4.9.3/thumb/libgcc.a /usr/lib/arm-poky-eabi/4.9.3/thumb/crti.o /usr/lib/arm-poky-eabi/4.9.3/fpu/libgcov.a /usr/lib/arm-poky-eabi/4.9.3/fpu/crtn.o /usr/lib/arm-poky-eabi/4.9.3/fpu/crtend.o /usr/lib/arm-poky-eabi/4.9.3/fpu/crtbegin.o /usr/lib/arm-poky-eabi/4.9.3/fpu/libgcc.a /usr/lib/arm-poky-eabi/4.9.3/fpu/crti.o
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install. [installed-vs-shipped]

---
 meta/recipes-devtools/gcc/libgcc.inc | 6 ++++++
 1 file changed, 6 insertions(+)
meta/recipes-devtools/gcc/libgcc.inc +6 -0
index 739adbd..95709e4 100644
@@ -28,6 +28,12 @@ FILES_${PN}-dev = "\
     ${libdir}/${TARGET_SYS}/${BINV}/libgcov.a \
 "
 
+FILES_${PN}-dev_libc-baremetal = "\
+    ${base_libdir}/ \
+    ${libdir}/* \
+    ${libdir}/${TARGET_SYS}/* \
+"
+
 FILES_${PN}-dbg += "${base_libdir}/.debug/"
 
 LIBGCCBUILDTREENAME = "gcc-build-internal-"
Signature · 1 line
1.9.1
#1 lore raw
Quoted 37 lines · Juro Bystricky

When building libgcc for baremetal cross-compilers, some files and libraries may be built but not packaged. This patch fixes errors such as these:

ERROR: QA Issue: libgcc: Files/directories were installed but not shipped in any package:
/usr/lib/arm-poky-eabi/4.9.3/thumb
/usr/lib/arm-poky-eabi/4.9.3/fpu /usr/lib/arm-poky-eabi/4.9.3/thumb/libgcov.a /usr/lib/arm-poky-eabi/4.9.3/thumb/crtn.o /usr/lib/arm-poky-eabi/4.9.3/thumb/crtend.o /usr/lib/arm-poky-eabi/4.9.3/thumb/crtbegin.o /usr/lib/arm-poky-eabi/4.9.3/thumb/libgcc.a /usr/lib/arm-poky-eabi/4.9.3/thumb/crti.o /usr/lib/arm-poky-eabi/4.9.3/fpu/libgcov.a /usr/lib/arm-poky-eabi/4.9.3/fpu/crtn.o /usr/lib/arm-poky-eabi/4.9.3/fpu/crtend.o /usr/lib/arm-poky-eabi/4.9.3/fpu/crtbegin.o /usr/lib/arm-poky-eabi/4.9.3/fpu/libgcc.a /usr/lib/arm-poky-eabi/4.9.3/fpu/crti.o
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install. [installed-vs-shipped]

---
meta/recipes-devtools/gcc/libgcc.inc | 6 ++++++

1 file changed, 6 insertions(+)
meta/recipes-devtools/gcc/libgcc.inc +0 -0
index 739adbd..95709e4 100644
@@ -28,6 +28,12 @@ FILES_${PN}-dev = "\
    ${libdir}/${TARGET_SYS}/${BINV}/libgcov.a \

"

meta/recipes-devtools/gcc/libgcc.inc FILES_${PN}-dev = "\

Quoted 5 lines
meta/recipes-devtools/gcc/libgcc.inc +5 -0
+FILES_${PN}-dev_libc-baremetal = "\
+    ${base_libdir}/ \
+    ${libdir}/* \
+    ${libdir}/${TARGET_SYS}/* \
+”

why not put it into libgcc-dev itself

Quoted 13 lines

+

FILES_${PN}-dbg += "${base_libdir}/.debug/"

LIBGCCBUILDTREENAME = "gcc-build-internal-"

Signature · 7 lines
1.9.1

-- 
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
#2 lore raw
Quoted 36 lines · Khem Raj
Quoted 36 lines · Juro Bystricky

When building libgcc for baremetal cross-compilers, some files and libraries may be built but not packaged. This patch fixes errors such as these:

ERROR: QA Issue: libgcc: Files/directories were installed but not shipped in any package:
/usr/lib/arm-poky-eabi/4.9.3/thumb
/usr/lib/arm-poky-eabi/4.9.3/fpu /usr/lib/arm-poky-eabi/4.9.3/thumb/libgcov.a /usr/lib/arm-poky-eabi/4.9.3/thumb/crtn.o /usr/lib/arm-poky-eabi/4.9.3/thumb/crtend.o /usr/lib/arm-poky-eabi/4.9.3/thumb/crtbegin.o /usr/lib/arm-poky-eabi/4.9.3/thumb/libgcc.a /usr/lib/arm-poky-eabi/4.9.3/thumb/crti.o /usr/lib/arm-poky-eabi/4.9.3/fpu/libgcov.a /usr/lib/arm-poky-eabi/4.9.3/fpu/crtn.o /usr/lib/arm-poky-eabi/4.9.3/fpu/crtend.o /usr/lib/arm-poky-eabi/4.9.3/fpu/crtbegin.o /usr/lib/arm-poky-eabi/4.9.3/fpu/libgcc.a /usr/lib/arm-poky-eabi/4.9.3/fpu/crti.o
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install. [installed-vs-shipped]

---
meta/recipes-devtools/gcc/libgcc.inc | 6 ++++++

1 file changed, 6 insertions(+)
meta/recipes-devtools/gcc/libgcc.inc +0 -0
index 739adbd..95709e4 100644
@@ -28,6 +28,12 @@ FILES_${PN}-dev = "\
    ${libdir}/${TARGET_SYS}/${BINV}/libgcov.a \

"

Quoted 7 lines

meta/recipes-devtools/gcc/libgcc.inc FILES_${PN}-dev = "\

Quoted 5 lines
meta/recipes-devtools/gcc/libgcc.inc +5 -0
+FILES_${PN}-dev_libc-baremetal = "\
+    ${base_libdir}/ \
+    ${libdir}/* \
+    ${libdir}/${TARGET_SYS}/* \
+”

why not put it into libgcc-dev itself

Agreed. I think the real issue here is nothing really to do with baremetal, it's just that the existing FILES_${PN}-dev pattern doesn't consider multilib for anything other than IA and mips.

p.

#3 lore raw

Thanks, I see what you mean. I'll repost a new patch after I've tested it.

Quoted 63 lines

-----Original Message-----
From: Phil Blundell [mailto:[email protected]]
Sent: Monday, September 14, 2015 12:53 PM
To: Khem Raj
Cc: Bystricky, Juro; Purdie, Richard; openembedded- [email protected]
Subject: Re: [OE-core] [PATCH] libgcc.inc: package baremetal multilib libraries

Quoted 1 line · Khem Raj
Quoted 1 line

On Sep 14, 2015, at 9:22 AM, Juro Bystricky <[email protected]>

Quoted 3 lines · wrote:
Quoted 3 lines

When building libgcc for baremetal cross-compilers, some files and libraries may be built but not packaged. This patch fixes errors such as

these:

Quoted 2 lines
Quoted 2 lines

ERROR: QA Issue: libgcc: Files/directories were installed but not shipped

in any package:

Quoted 31 lines
Quoted 31 lines

/usr/lib/arm-poky-eabi/4.9.3/thumb /usr/lib/arm-poky-eabi/4.9.3/fpu /usr/lib/arm-poky-eabi/4.9.3/thumb/libgcov.a /usr/lib/arm-poky-eabi/4.9.3/thumb/crtn.o /usr/lib/arm-poky-eabi/4.9.3/thumb/crtend.o /usr/lib/arm-poky-eabi/4.9.3/thumb/crtbegin.o /usr/lib/arm-poky-eabi/4.9.3/thumb/libgcc.a /usr/lib/arm-poky-eabi/4.9.3/thumb/crti.o /usr/lib/arm-poky-eabi/4.9.3/fpu/libgcov.a /usr/lib/arm-poky-eabi/4.9.3/fpu/crtn.o /usr/lib/arm-poky-eabi/4.9.3/fpu/crtend.o /usr/lib/arm-poky-eabi/4.9.3/fpu/crtbegin.o /usr/lib/arm-poky-eabi/4.9.3/fpu/libgcc.a /usr/lib/arm-poky-eabi/4.9.3/fpu/crti.o
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install. [installed-vs-shipped]

---
meta/recipes-devtools/gcc/libgcc.inc | 6 ++++++

1 file changed, 6 insertions(+)
meta/recipes-devtools/gcc/libgcc.inc +0 -0
index 739adbd..95709e4 100644
@@ -28,6 +28,12 @@ FILES_${PN}-dev = "\
    ${libdir}/${TARGET_SYS}/${BINV}/libgcov.a \ "
 
Quoted 7 lines

meta/recipes-devtools/gcc/libgcc.inc FILES_${PN}-dev = "\

Quoted 5 lines
meta/recipes-devtools/gcc/libgcc.inc +5 -0
+FILES_${PN}-dev_libc-baremetal = "\
+    ${base_libdir}/ \
+    ${libdir}/* \
+    ${libdir}/${TARGET_SYS}/* \
+”

why not put it into libgcc-dev itself

Agreed. I think the real issue here is nothing really to do with baremetal, it's just that the existing FILES_${PN}-dev pattern doesn't consider multilib for anything other than IA and mips.

p.

#4 lore raw

v2 cover libgcc: package multiple libraries

In reply to Phil Blundell

Second attempt. This patch is a bit more invasive than the previous one, but based on my understanding it should not break the existing code.

Juro Bystricky (1):
libgcc.inc: package baremetal multilib libraries

 meta/recipes-devtools/gcc/libgcc.inc | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)
Signature · 1 line
1.9.1
#5 lore raw

PATCH v2 1/1 libgcc.inc: package baremetal multilib libraries

When building libgcc some files and libraries may be built but not packaged. The original code packaged only some explicitly specified files targeting mostly x86. This patch does not discriminate between various targets.
It fixes errors such as these:

ERROR: QA Issue: libgcc: Files/directories were installed but not shipped in any package:
/usr/lib/arm-poky-eabi/4.9.3/thumb
/usr/lib/arm-poky-eabi/4.9.3/fpu /usr/lib/arm-poky-eabi/4.9.3/thumb/libgcov.a /usr/lib/arm-poky-eabi/4.9.3/thumb/crtn.o /usr/lib/arm-poky-eabi/4.9.3/thumb/crtend.o /usr/lib/arm-poky-eabi/4.9.3/thumb/crtbegin.o /usr/lib/arm-poky-eabi/4.9.3/thumb/libgcc.a /usr/lib/arm-poky-eabi/4.9.3/thumb/crti.o /usr/lib/arm-poky-eabi/4.9.3/fpu/libgcov.a /usr/lib/arm-poky-eabi/4.9.3/fpu/crtn.o /usr/lib/arm-poky-eabi/4.9.3/fpu/crtend.o /usr/lib/arm-poky-eabi/4.9.3/fpu/crtbegin.o /usr/lib/arm-poky-eabi/4.9.3/fpu/libgcc.a /usr/lib/arm-poky-eabi/4.9.3/fpu/crti.o
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install. [installed-vs-shipped]

---
 meta/recipes-devtools/gcc/libgcc.inc | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)
meta/recipes-devtools/gcc/libgcc.inc +1 -8
index 739adbd..95fa3f4 100644
@@ -15,17 +15,10 @@ LICENSE_${PN}-dev = "GPL-3.0-with-GCC-exception"
 LICENSE_${PN}-dbg = "GPL-3.0-with-GCC-exception"
 
 
-FILES_${PN} = "${base_libdir}/libgcc*.so.*"
 FILES_${PN}-dev = "\
     ${base_libdir}/libgcc*.so \
-    ${libdir}/${TARGET_SYS}/${BINV}/*crt* \
-    ${libdir}/${TARGET_SYS}/${BINV}/64 \
-    ${libdir}/${TARGET_SYS}/${BINV}/32 \
-    ${libdir}/${TARGET_SYS}/${BINV}/x32 \
-    ${libdir}/${TARGET_SYS}/${BINV}/n32 \
-    ${libdir}/${TARGET_SYS}/${BINV}/libgcc* \
     ${@base_conditional('BASETARGET_SYS', '${TARGET_SYS}', '', '${libdir}/${BASETARGET_SYS}', d)} \
-    ${libdir}/${TARGET_SYS}/${BINV}/libgcov.a \
+    ${libdir}/${TARGET_SYS}/${BINV}* \
 "
 
 FILES_${PN}-dbg += "${base_libdir}/.debug/"
Signature · 1 line
1.9.1