Skip to contentSkip to conversation

squeezelite: new package

PATCH Superseded kei-k at ca2.so-net.ne.jp 3 participants 4 messages Sep 22, 2015

v9 of 14 Superseded Latest is v14 →

lore
Share & tools
lore
#0 lore raw

PATCH v9 1/1 squeezelite: new package

---
 package/Config.in                  |    1 +
 package/squeezelite/Config.in      |   26 ++++++++++++++++++++++++++
 package/squeezelite/squeezelite.mk |   27 +++++++++++++++++++++++++++
 3 files changed, 54 insertions(+), 0 deletions(-)
 create mode 100644 package/squeezelite/Config.in
 create mode 100644 package/squeezelite/squeezelite.mk
package/Config.in +1 -0
index 5158371..2a47420 100644
@@ -33,6 +33,7 @@ menu "Audio and video applications"
 	source "package/opus-tools/Config.in"
 	source "package/pulseaudio/Config.in"
 	source "package/sox/Config.in"
+	source "package/squeezelite/Config.in"
 	source "package/tidsp-binaries/Config.in"
 	source "package/tovid/Config.in"
 	source "package/tstools/Config.in"
package/squeezelite/Config.in new file +26 -0
new file mode 100644
index 0000000..96efb7c
@@ -0,0 +1,26 @@
+config BR2_PACKAGE_SQUEEZELITE
+	bool "squeezelite"
+	depends on BR2_USE_WCHAR # flac
+	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
+	depends on BR2_USE_MMU # mpg123
+	select BR2_PACKAGE_ALSA_LIB
+	select BR2_PACKAGE_FLAC
+	select BR2_PACKAGE_LIBMAD
+	select BR2_PACKAGE_LIBVORBIS
+	select BR2_PACKAGE_FAAD2
+	select BR2_PACKAGE_MPG123
+	help
+	  Logitech Media Server client
+	  https://code.google.com/p/squeezelite/
+
+config BR2_PACKAGE_SQUEEZELITE_RESAMPLE
+	bool "Enable resampling function"
+	default n
+	select BR2_PACKAGE_LIBSOXR
+	depends on BR2_PACKAGE_SQUEEZELITE
+	help
+	  Enable resampling function
+
+comment "squeezelite needs a toolchain w/ wchar, threads"
+	depends on BR2_USE_MMU
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
package/squeezelite/squeezelite.mk new file +27 -0
new file mode 100644
index 0000000..4defa31
@@ -0,0 +1,27 @@
+################################################################################
+#
+# squeezelite
+#
+################################################################################
+
+SQUEEZELITE_VERSION = v1.8
+SQUEEZELITE_SITE = https://code.google.com/p/squeezelite
+SQUEEZELITE_SITE_METHOD = git
+SQUEEZELITE_LICENSE = GPLv3
+SQUEEZELITE_LICENSE_FILE = LICENSE.txt
+SQUEEZELITE_DEPENDENCIES = alsa-lib flac libmad libvorbis faad2 mpg123 libsoxr
+
+ifeq ($(BR2_PACKAGE_SQUEEZELITE_RESAMPLE),y)
+SQUEEZELITE_MAKE_OPTS += -DRESAMPLE -DRESAMPLE_MP
+endif
+
+define SQUEEZELITE_BUILD_CMDS
+    $(TARGET_MAKE_ENV) $(MAKE) OPTS="$(SQUEEZELITE_MAKE_OPTS)" \
+		CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all
+endef
+
+define SQUEEZELITE_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/squeezelite $(TARGET_DIR)/usr/bin
+endef
+
+$(eval $(generic-package))
Signature · 4 lines
1.7.1

============================================================
    Hiroshi Kawashima
#1 lore raw

PATCH v9 1/1 squeezelite: new package

Dear Hiroshi Kawashima,

On 09/22/2015 09:26 AM, kei-k at ca2.so-net.ne.jp wrote:
[snip]

Quoted 18 lines
package/squeezelite/Config.in new file +12 -0
new file mode 100644
index 0000000..96efb7c
@@ -0,0 +1,26 @@
+config BR2_PACKAGE_SQUEEZELITE
+	bool "squeezelite"
+	depends on BR2_USE_WCHAR # flac
+	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
+	depends on BR2_USE_MMU # mpg123
+	select BR2_PACKAGE_ALSA_LIB
+	select BR2_PACKAGE_FLAC
+	select BR2_PACKAGE_LIBMAD
+	select BR2_PACKAGE_LIBVORBIS
+	select BR2_PACKAGE_FAAD2
+	select BR2_PACKAGE_MPG123
+	help

package/squeezelite/Config.in line 22

Quoted 10 lines
package/squeezelite/Config.in new file +10 -0
+	  Logitech Media Server client
+	  https://code.google.com/p/squeezelite/
+
+config BR2_PACKAGE_SQUEEZELITE_RESAMPLE
+	bool "Enable resampling function"
+	default n
+	select BR2_PACKAGE_LIBSOXR
+	depends on BR2_PACKAGE_SQUEEZELITE
+	help
+	  Enable resampling function

The BR2_PACKAGE_SQUEEZELITE_RESAMPLE block needs to be enclosed into an if clause like these one:

if BR2_PACKAGE_SQUEEZELITE
[here the BR2_PACKAGE_SQUEEZELITE_RESAMPLE block]
endif

That way the resample option will only be shown in the menu after selecting the squeezelite package.

Regards,

Vincent.

Quoted 37 lines
package/squeezelite/Config.in new file +3 -0
+comment "squeezelite needs a toolchain w/ wchar, threads"
+	depends on BR2_USE_MMU
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
package/squeezelite/squeezelite.mk new file +27 -0
new file mode 100644
index 0000000..4defa31
@@ -0,0 +1,27 @@
+################################################################################
+#
+# squeezelite
+#
+################################################################################
+
+SQUEEZELITE_VERSION = v1.8
+SQUEEZELITE_SITE = https://code.google.com/p/squeezelite
+SQUEEZELITE_SITE_METHOD = git
+SQUEEZELITE_LICENSE = GPLv3
+SQUEEZELITE_LICENSE_FILE = LICENSE.txt
+SQUEEZELITE_DEPENDENCIES = alsa-lib flac libmad libvorbis faad2 mpg123 libsoxr
+
+ifeq ($(BR2_PACKAGE_SQUEEZELITE_RESAMPLE),y)
+SQUEEZELITE_MAKE_OPTS += -DRESAMPLE -DRESAMPLE_MP
+endif
+
+define SQUEEZELITE_BUILD_CMDS
+    $(TARGET_MAKE_ENV) $(MAKE) OPTS="$(SQUEEZELITE_MAKE_OPTS)" \
+		CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all
+endef
+
+define SQUEEZELITE_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/squeezelite $(TARGET_DIR)/usr/bin
+endef
+
+$(eval $(generic-package))
#2 lore raw

PATCH v9 1/1 squeezelite: new package

In reply to kei-k at ca2.so-net.ne.jp

Dear Hiroshi Kawashima,

Quoted 1 line · On Di, 2015-09-22 at 17:26 +0900, kei-k at ca2.so-net.ne.jp wrote:

No revision changelog. Please have a look at the Buildroot manual:
http://nightly.buildroot.org/#_providing_patches

Quoted 32 lines
---
 package/Config.in                  |    1 +
 package/squeezelite/Config.in      |   26 ++++++++++++++++++++++++++
 package/squeezelite/squeezelite.mk |   27
+++++++++++++++++++++++++++
 3 files changed, 54 insertions(+), 0 deletions(-)
 create mode 100644 package/squeezelite/Config.in
 create mode 100644 package/squeezelite/squeezelite.mk
package/Config.in +1 -0
index 5158371..2a47420 100644
@@ -33,6 +33,7 @@ menu "Audio and video applications"
 	source "package/opus-tools/Config.in"
 	source "package/pulseaudio/Config.in"
 	source "package/sox/Config.in"
+	source "package/squeezelite/Config.in"
 	source "package/tidsp-binaries/Config.in"
 	source "package/tovid/Config.in"
 	source "package/tstools/Config.in"
package/squeezelite/Config.in new file +4 -0
new file mode 100644
index 0000000..96efb7c
@@ -0,0 +1,26 @@
+config BR2_PACKAGE_SQUEEZELITE
+	bool "squeezelite"
+	depends on BR2_USE_WCHAR # flac
+	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib

package/squeezelite/Config.in line 14

Quoted 10 lines
package/squeezelite/Config.in new file +10 -0
+	depends on BR2_USE_MMU # mpg123
+	select BR2_PACKAGE_ALSA_LIB
+	select BR2_PACKAGE_FLAC
+	select BR2_PACKAGE_LIBMAD
+	select BR2_PACKAGE_LIBVORBIS
+	select BR2_PACKAGE_FAAD2
+	select BR2_PACKAGE_MPG123
+	help
+	  Logitech Media Server client
+	  https://code.google.com/p/squeezelite/

Buildroot uses a newline between the description and the URL.

package/squeezelite/Config.in line 18

Quoted 4 lines
package/squeezelite/Config.in new file +4 -0
+
+config BR2_PACKAGE_SQUEEZELITE_RESAMPLE
+	bool "Enable resampling function"
+	default n

"default n" is set implicitly and not needed here.

[snip]

Did you see my comments to the squeezelite.mk file in the last patch (v8)?

Best regards
J?rg Krause

author
#3 lore raw

PATCH v9 1/1 squeezelite: new package

OK, take it please, post next.

Quoted 73 lines

2015/09/22 17:54?J?rg Krause <[email protected]> ?????

Dear Hiroshi Kawashima,

Quoted 1 line · On Di, 2015-09-22 at 17:26 +0900, kei-k at ca2.so-net.ne.jp wrote:

No revision changelog. Please have a look at the Buildroot manual:
http://nightly.buildroot.org/#_providing_patches

Quoted 32 lines

---

package/Config.in                  |    1 +
package/squeezelite/Config.in      |   26 ++++++++++++++++++++++++++
package/squeezelite/squeezelite.mk |   27
+++++++++++++++++++++++++++
3 files changed, 54 insertions(+), 0 deletions(-)

create mode 100644 package/squeezelite/Config.in create mode 100644 package/squeezelite/squeezelite.mk

package/Config.in +1 -0
index 5158371..2a47420 100644
@@ -33,6 +33,7 @@ menu "Audio and video applications"
 	source "package/opus-tools/Config.in"
 	source "package/pulseaudio/Config.in"
 	source "package/sox/Config.in"
+	source "package/squeezelite/Config.in"
 	source "package/tidsp-binaries/Config.in"
 	source "package/tovid/Config.in"
 	source "package/tstools/Config.in"
package/squeezelite/Config.in new file +4 -0
new file mode 100644
index 0000000..96efb7c
@@ -0,0 +1,26 @@
+config BR2_PACKAGE_SQUEEZELITE
+	bool "squeezelite"
+	depends on BR2_USE_WCHAR # flac
+	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib

package/squeezelite/Config.in line 14

Quoted 10 lines
package/squeezelite/Config.in new file +10 -0
+	depends on BR2_USE_MMU # mpg123
+	select BR2_PACKAGE_ALSA_LIB
+	select BR2_PACKAGE_FLAC
+	select BR2_PACKAGE_LIBMAD
+	select BR2_PACKAGE_LIBVORBIS
+	select BR2_PACKAGE_FAAD2
+	select BR2_PACKAGE_MPG123
+	help
+	  Logitech Media Server client
+	  https://code.google.com/p/squeezelite/

Buildroot uses a newline between the description and the URL.

package/squeezelite/Config.in line 18

Quoted 4 lines
package/squeezelite/Config.in new file +4 -0
+
+config BR2_PACKAGE_SQUEEZELITE_RESAMPLE
+	bool "Enable resampling function"
+	default n

"default n" is set implicitly and not needed here.

[snip]

Did you see my comments to the squeezelite.mk file in the last patch (v8)?

Best regards
J?rg Krause
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot