Skip to contentSkip to conversation

oeqa/utils/qemurunner.py: Fix HIGH CPU usage on LoggingThread

PATCH New Aníbal Limón 1 participant 2 messages Sep 22, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 oeqa/utils/qemurunner.py: Fix HIGH CPU usage on LoggingThread

LoggingThread is used for receive console output from QEMU over TCP, so add filter to only wake poll on read events, also change the event mask variable name to be more descriptive.

This fixes HIGH CPU consume caused by wake on ready to write events.

---
 meta/lib/oeqa/utils/qemurunner.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/lib/oeqa/utils/qemurunner.py +3 -3
index d32c9db..6edd374 100644
@@ -440,9 +440,9 @@ class LoggingThread(threading.Thread):
 
     def eventloop(self):
         poll = select.poll()
-        eventmask = self.errorevents | self.readevents
+        event_read_mask = self.errorevents | self.readevents
         poll.register(self.serversock.fileno())
-        poll.register(self.readpipe, eventmask)
+        poll.register(self.readpipe, event_read_mask)
 
         breakout = False
         self.running = True
@@ -466,7 +466,7 @@ class LoggingThread(threading.Thread):
                     self.readsock, _ = self.serversock.accept()
                     self.readsock.setblocking(0)
                     poll.unregister(self.serversock.fileno())
-                    poll.register(self.readsock.fileno())
+                    poll.register(self.readsock.fileno(), event_read_mask)
 
                     self.logger.info("Setting connection established event")
                     self.connection_established.set()
Signature · 1 line
1.9.1
#1 lore raw

PATCH 2/2 oeqa/utils/qemurunner.py: Remove duplicate message on LoggingThread start

The Starting logging thread message is also executed on run() inside LoggingThread class.

---
 meta/lib/oeqa/utils/qemurunner.py | 1 -
 1 file changed, 1 deletion(-)
meta/lib/oeqa/utils/qemurunner.py +0 -1
index 6edd374..0357f99 100644
@@ -186,7 +186,6 @@ class QemuRunner:
             logger.info("Target IP: %s" % self.ip)
             logger.info("Server IP: %s" % self.server_ip)
 
-            logger.info("Starting logging thread")
             self.thread = LoggingThread(self.log, threadsock, logger)
             self.thread.start()
             if not self.thread.connection_established.wait(self.boottime):
Signature · 1 line
1.9.1