Skip to contentSkip to conversation

package/lua: do not install man files

PATCH New Jörg Krause 2 participants 3 messages Sep 21, 2015 – Sep 22, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/lua: do not install man files

As written in the holy manual:
http://buildroot.org/downloads/manual/manual.html#faq-no-doc-on-target

---
 package/lua/lua.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/lua/lua.mk +2 -2
index 1279b76..af5cef3 100644
@@ -87,7 +87,7 @@ define HOST_LUA_BUILD_CMDS
 endef
 
 define LUA_INSTALL_STAGING_CMDS
-	$(MAKE) INSTALL_TOP="$(STAGING_DIR)/usr" -C $(@D) install
+	$(MAKE) INSTALL_TOP="$(STAGING_DIR)/usr" INSTALL_MAN= -C $(@D) install
 	$(INSTALL) -m 0644 -D $(@D)/etc/lua.pc \
 		$(STAGING_DIR)/usr/lib/pkgconfig/lua.pc
 endef
@@ -97,7 +97,7 @@ define LUA_INSTALL_TARGET_CMDS
 endef
 
 define HOST_LUA_INSTALL_CMDS
-	$(MAKE) INSTALL_TOP="$(HOST_DIR)/usr" -C $(@D) install
+	$(MAKE) INSTALL_TOP="$(HOST_DIR)/usr" INSTALL_MAN= -C $(@D) install
 	$(INSTALL) -m 0644 -D $(@D)/etc/lua.pc \
 		$(HOST_DIR)/usr/lib/pkgconfig/lua.pc
 endef
Signature · 1 line
2.5.3
#1 lore raw

PATCH 1/1 package/lua: do not install man files

Hello J?rg,

Quoted 22 lines · J?rg Krause

As written in the holy manual:
http://buildroot.org/downloads/manual/manual.html#faq-no-doc-on-target

---
 package/lua/lua.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/lua/lua.mk +1 -1
index 1279b76..af5cef3 100644
@@ -87,7 +87,7 @@ define HOST_LUA_BUILD_CMDS
 endef
 
 define LUA_INSTALL_STAGING_CMDS
-	$(MAKE) INSTALL_TOP="$(STAGING_DIR)/usr" -C $(@D) install
+	$(MAKE) INSTALL_TOP="$(STAGING_DIR)/usr" INSTALL_MAN= -C $(@D) install
 	$(INSTALL) -m 0644 -D $(@D)/etc/lua.pc \
 		$(STAGING_DIR)/usr/lib/pkgconfig/lua.pc
 endef

package/lua/lua.mk define LUA_INSTALL_TARGET_CMDS · line 103

Quoted 8 lines
package/lua/lua.mk +1 -1
@@ -97,7 +97,7 @@ define LUA_INSTALL_TARGET_CMDS
 endef
 
 define HOST_LUA_INSTALL_CMDS
-	$(MAKE) INSTALL_TOP="$(HOST_DIR)/usr" -C $(@D) install
+	$(MAKE) INSTALL_TOP="$(HOST_DIR)/usr" INSTALL_MAN= -C $(@D) install
 	$(INSTALL) -m 0644 -D $(@D)/etc/lua.pc \
 		$(HOST_DIR)/usr/lib/pkgconfig/lua.pc
 endef

This is in fact not needed. Buildroot is already removing the man pages in the target-finalize step of the main Makefile. I have checked, the Lua man pages are installed in standard locations, so they are properly removed by this generic removal step.

For this reason, I am not sure it is really worth to add more complexity to a package to avoid doing something that is anyway already handled at some later point in a generic way. It would be worth if that thing was actually taking a significant amount of build time, or required additional dependencies. But it's not the case here, so i would be tempted to leave the Lua package as is, and not take this patch.

Opinions?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 package/lua: do not install man files

Quoted 54 lines · Thomas Petazzoni

Hello J?rg,

Quoted 30 lines · J?rg Krause

As written in the holy manual:
http://buildroot.org/downloads/manual/manual.html#faq-no-doc-on-tar
get

---
 package/lua/lua.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/lua/lua.mk +1 -1
index 1279b76..af5cef3 100644
@@ -87,7 +87,7 @@ define HOST_LUA_BUILD_CMDS
 endef
 
 define LUA_INSTALL_STAGING_CMDS
-	$(MAKE) INSTALL_TOP="$(STAGING_DIR)/usr" -C $(@D) install
+	$(MAKE) INSTALL_TOP="$(STAGING_DIR)/usr" INSTALL_MAN= -C

$(@D) install

package/lua/lua.mk +1 -1
 	$(INSTALL) -m 0644 -D $(@D)/etc/lua.pc \
 		$(STAGING_DIR)/usr/lib/pkgconfig/lua.pc
 endef
@@ -97,7 +97,7 @@ define LUA_INSTALL_TARGET_CMDS
 endef
 
 define HOST_LUA_INSTALL_CMDS
-	$(MAKE) INSTALL_TOP="$(HOST_DIR)/usr" -C $(@D) install
+	$(MAKE) INSTALL_TOP="$(HOST_DIR)/usr" INSTALL_MAN= -C

$(@D) install

package/lua/lua.mk define LUA_INSTALL_TARGET_CMDS · line 103

Quoted 3 lines
package/lua/lua.mk +0 -0
 	$(INSTALL) -m 0644 -D $(@D)/etc/lua.pc \
 		$(HOST_DIR)/usr/lib/pkgconfig/lua.pc
 endef

This is in fact not needed. Buildroot is already removing the man pages
in the target-finalize step of the main Makefile. I have checked, the Lua man pages are installed in standard locations, so they are properly
removed by this generic removal step.

For this reason, I am not sure it is really worth to add more complexity to a package to avoid doing something that is anyway already
handled at some later point in a generic way. It would be worth if that
thing was actually taking a significant amount of build time, or required additional dependencies. But it's not the case here, so i would be tempted to leave the Lua package as is, and not take this patch.

Quoted 2 lines

Opinions?

I see! I didn't know about this. I just build the lua package (without make all) and saw the man files in my target tree.

Many thanks for clarification! I'll mark this patch as rejected...

J?rg