perf/core improvements and fixes
Subsystems (3)
Arnaldo Carvalho de Melo
maintainerHi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 96f3eda67fcf2598e9d2794398e0e7ab35138ea6:
perf/x86/intel: Fix static checker warning in lbr enable (2015-09-18 09:24:57 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to e803cf97a4f90d31bcc2c9a1ea20fe9cdc12b2f9:
perf record: Synthesize COMM event for a command line workload (2015-09-22 22:43:12 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Fix a segfault in 'perf probe' when removing uprobe events (Masami Hiramatsu)
- Synthesize COMM event for workloads started from the command line in 'perf record' so that we can have the pid->comm mapping before we get the real PERF_RECORD_COMM switching from perf to the workload (Namhyung Kim)
- Fix build tools/vm/ due to removal of tools/lib/api/fs/debugfs.h (Arnaldo Carvalho de Melo)
Developer stuff:
- Fix the make tarball targets by including the recently added err.h header in the perf MANIFEST file (Jiri Olsa)
- Don't assume that the event parser returns a non empty evlist (Wang Nan)
- Add way to disambiguate feature detection state files, needed to use tools/build feature detection for multiple components in a single O= output dir, which will be the case with tools/perf/ and tools/lib/bpf/ (Arnaldo Carvalho de Melo)
- Fixup FEATURE_{TESTS,DISPLAY} inversion in tools/lib/bpf/ (Arnaldo Carvalho de Melo)
----------------------------------------------------------------
Arnaldo Carvalho de Melo (5):
tools build: Fixup feature detection display function name tools lib bpf: Fix up FEATURE_{TESTS,DISPLAY} usage
tools build: Allow setting the feature detection user
tools lib bpf: Use FEATURE_USER to allow building in the same dir as perf tools vm: Fix build due to removal of tools/lib/api/fs/debugfs.h
Jiri Olsa (1):
perf tools: Add include/err.h into MANIFEST
Masami Hiramatsu (1):
perf probe: Fix a segfault when removing uprobe events
Namhyung Kim (1):
perf record: Synthesize COMM event for a command line workload
Wang Nan (1):
perf tools: Don't assume that the parser returns non empty evsel list
tools/build/Makefile.feature | 9 +++++---- tools/lib/bpf/Makefile | 5 +++-- tools/perf/MANIFEST | 1 + tools/perf/builtin-probe.c | 7 +++++-- tools/perf/builtin-record.c | 15 ++++++++++++++- tools/perf/util/event.c | 2 +- tools/perf/util/event.h | 5 +++++ tools/perf/util/parse-events.c | 16 ++++++++++++++++ tools/vm/page-types.c | 6 +++--- 9 files changed, 53 insertions(+), 13 deletions(-)
Arnaldo Carvalho de Melo
maintainerPATCH 1/9 perf probe: Fix a segfault when removing uprobe events
From: Masami Hiramatsu <[email protected]>
Fix a segfault bug and a small mistake in perf probe -d.
Since the "ulist" in perf_del_probe_events is never initialized, strlist__add(ulist, *) always causes a segfault when removing uprobe events by perf probe -d.
Also, the "str" local variable is never released if fail to allocate the "klist". This fixes it too.
This has been introduced by the commit e607f1426b58 ("perf probe:
Print deleted events in cmd_probe()").
--- tools/perf/builtin-probe.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
tools/perf/builtin-probe.c +5 -2
@@ -380,8 +380,11 @@ static int perf_del_probe_events(struct strfilter *filter) goto out; klist =strlist__new (NULL ,NULL ); -if (!klist) -return -ENOMEM ; + ulist =strlist__new (NULL ,NULL ); +if (!klist || !ulist) { + ret = -ENOMEM ; + goto out; + } ret =probe_file__get_events (kfd, filter, klist);if (ret ==0 ) {
Signature · 1 line
2.1.0
Arnaldo Carvalho de Melo
maintainerPATCH 2/9 perf tools: Don't assume that the parser returns non empty evsel list
In reply to Arnaldo Carvalho de MeloFrom: Wang Nan <[email protected]>
Don't blindly retrieve and use a last element in the lists returned by parse_events__scanner(), as it may have collected no entries, i.e. return an empty list.
--- tools/perf/util/parse-events.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
tools/perf/util/parse-events.c +16 -0
@@ -827,6 +827,11 @@ void parse_events__set_leader(char *name, struct list_head *list) {struct perf_evsel *leader; +if (list_empty (list)) { +WARN_ONCE (true,"WARNING: failed to set leader: empty list" ); +return ; + } +__perf_evlist__set_leader (list); leader = list_entry(list->next, struct perf_evsel, node); leader->group_name = name ?strdup (name) :NULL ;
@@ -1176,6 +1181,11 @@ int parse_events(struct perf_evlist *evlist, const char *str,if (!ret) {struct perf_evsel *last; +if (list_empty (&data.list)) { +WARN_ONCE (true,"WARNING: event parser found nothing" ); +return -1 ; + } +perf_evlist__splice_list_tail (evlist, &data.list); evlist->nr_groups += data.nr_groups; last =perf_evlist__last (evlist);
@@ -1285,6 +1295,12 @@ foreach_evsel_in_last_glob(struct perf_evlist *evlist,struct perf_evsel *last =NULL ;int err; +/* +* Don't return when list_empty, give func a chance to report +* error when it found last == NULL. +* +* So no need to WARN here, let *func do this. +*/ if (evlist->nr_entries >0 ) last =perf_evlist__last (evlist);
Signature · 1 line
2.1.0
Arnaldo Carvalho de Melo
maintainerPATCH 3/9 tools build: Fixup feature detection display function name
In reply to Arnaldo Carvalho de MeloFrom: Arnaldo Carvalho de Melo <[email protected]>
Cut'n'paste mistake, it should eval the name of the function defined right next to it, in the next line, fix it.
Before:
$ make -C tools/lib/bpf/ make: Entering directory '/home/git/linux/tools/lib/bpf'
Auto-detecting system features:
... libelf: [ on ] ... libelf-getphdrnum: [ on ] ... libelf-mmap: [ on ] ... bpf: [ on ]
<SNIP>
After:
$ make -C tools/lib/bpf/ make: Entering directory '/home/git/linux/tools/lib/bpf'
Auto-detecting system features:
... libelf: [ on ]
... libelf-getphdrnum: [ OFF ]
... libelf-mmap: [ OFF ]
... bpf: [ on ]
<SNIP>
--- tools/build/Makefile.feature | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/build/Makefile.feature +1 -1
@@ -140,7 +140,7 @@ ifneq ("$(FEATURE_DUMP)","$(FEATURE_DUMP_FILE)") feature_display := 1 endif -feature_display_check = $(eval $(feature_check_code)) +feature_display_check = $(eval $(feature_check_display_code)) define feature_display_check_code ifneq ($(feature-$(1)), 1) feature_display := 1
Signature · 1 line
2.1.0
Arnaldo Carvalho de Melo
maintainerPATCH 4/9 tools lib bpf: Fix up FEATURE_{TESTS,DISPLAY} usage
In reply to Arnaldo Carvalho de MeloFrom: Arnaldo Carvalho de Melo <[email protected]>
When libbpf was introduced it wrongly asked for the "libelf" and "bpf" feature tests to be performed (via FEATURE_TESTS), while asking that "libbpf", "libelf-mmap", "libelf-getphdrnum" and "bpf" to have the result of its respective tests to be displayed (via FEATURE_DISPLAY).
Due to another recently bug fixed in the tools/build/ infrastructure ("tools build: Fixup feature detection display function name") the results for the entries in the FEATURE_DISPLAY, for this case, were appearing as all succeeding, when two of them (the ones only on the DISPLAY) were not even being performed.
Before:
$ make -C tools/lib/bpf/ make: Entering directory '/home/git/linux/tools/lib/bpf' Auto-detecting system features: ... libelf: [ on ] ... libelf-getphdrnum: [ OFF ] ... libelf-mmap: [ OFF ] ... bpf: [ on ] <SNIP>
After, with FEATURE_TESTS == FEATURE_DISPLAY:
Auto-detecting system features:
... libelf: [ on ] ... libelf-getphdrnum: [ on ] ... libelf-mmap: [ on ] ... bpf: [ on ]
<SNIP>
I just inverted, so that it tests the four features but displays just the libelf and mmap ones, to make it more compact. So it becomes:
$ make -C tools/lib/bpf/ make: Entering directory '/home/git/linux/tools/lib/bpf'
Auto-detecting system features:
... libelf: [ on ]
... bpf: [ on ]
--- tools/lib/bpf/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/lib/bpf/Makefile +2 -2
@@ -64,8 +64,8 @@ srctree := $(patsubst %/,%,$(dir $(srctree))) #$(info Determined 'srctree' to be $(srctree)) endif -FEATURE_DISPLAY = libelf libelf-getphdrnum libelf-mmap bpf -FEATURE_TESTS = libelf bpf +FEATURE_TESTS = libelf libelf-getphdrnum libelf-mmap bpf +FEATURE_DISPLAY = libelf bpf INCLUDES = -I. -I$(srctree)/tools/include -I$(srctree)/arch/$(ARCH)/include/uapi -I$(srctree)/include/uapi FEATURE_CHECK_CFLAGS-bpf = $(INCLUDES)
Signature · 1 line
2.1.0
Arnaldo Carvalho de Melo
maintainerPATCH 5/9 tools build: Allow setting the feature detection user
In reply to Arnaldo Carvalho de MeloFrom: Arnaldo Carvalho de Melo <[email protected]>
We will use the tools/build/ autodetection in the eBPF patchkit and it is currently sharing the output directory with perf, that also uses the feature detection logic.
As we keep state in the output directory, so that we can avoid running all the tests again, we need to have different filenames for the files used in this state, allow doing that via the FEATURE_USER variable, to be set alongside the existing FEATURE_{TEST,DISPLAY} variables.
v2: Fix comment describing the FEATURE_DUMP filename to make sure where
it is created, precisely at $(OUTPUT)FEATURE-DUMP$(FEATURE_USER). Pointed out by Jiri.
--- tools/build/Makefile.feature | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
tools/build/Makefile.feature +4 -3
@@ -121,8 +121,9 @@ define feature_print_text_code MSG = $(shell printf '...%30s: %s' $(1) $(2)) endef +FEATURE_DUMP_FILENAME = $(OUTPUT)FEATURE-DUMP$(FEATURE_USER) FEATURE_DUMP := $(foreach feat,$(FEATURE_DISPLAY),feature-$(feat)($(feature-$(feat)))) -FEATURE_DUMP_FILE := $(shell touch $(OUTPUT)FEATURE-DUMP; cat $(OUTPUT)FEATURE-DUMP) +FEATURE_DUMP_FILE := $(shell touch $(FEATURE_DUMP_FILENAME); cat $(FEATURE_DUMP_FILENAME)) ifeq ($(dwarf-post-unwind),1) FEATURE_DUMP += dwarf-post-unwind($(dwarf-post-unwind-text))
@@ -131,12 +132,12 @@ endif # The $(feature_display) controls the default detection message # output. It's set if: # - detected features differes from stored features from -# last build (in FEATURE-DUMP file) +# last build (in $(FEATURE_DUMP_FILENAME) file) # - one of the $(FEATURE_DISPLAY) is not detected # - VF is enabled ifneq ("$(FEATURE_DUMP)","$(FEATURE_DUMP_FILE)") - $(shell echo "$(FEATURE_DUMP)" > $(OUTPUT)FEATURE-DUMP) + $(shell echo "$(FEATURE_DUMP)" > $(FEATURE_DUMP_FILENAME)) feature_display := 1 endif
Signature · 1 line
2.1.0
Arnaldo Carvalho de Melo
maintainerPATCH 6/9 tools lib bpf: Use FEATURE_USER to allow building in the same dir as perf
In reply to Arnaldo Carvalho de MeloFrom: Arnaldo Carvalho de Melo <[email protected]>
When building tools/lib/bpf as part of the tools/perf/ build process, which will happend when we introduce a patch wiring that up, we end up stomping on the feature detection caching mechanism, that uses a file in the output directory (O=) that is shared by libbpf and perf to check if something changed from one build to another that requires redoing the feature detection process.
By using the recently introduced FEATURE_USER tools/build/ knob, we can avoid that:
Before, every make invokation would run the feature detection:
$ make O=/tmp/build/perf -C tools/perf make: Entering directory '/home/git/linux/tools/perf' Auto-detecting system features: ... dwarf: [ on ] ... glibc: [ on ] <SNIP> ... get_cpuid: [ on ] ... bpf: [ on ]
GEN perf-archive
GEN perf-with-kcore
Auto-detecting system features:
... libelf: [ on ]
... bpf: [ on ]
<SNIP>
After:
$ make O=/tmp/build/perf -C tools/perf
make: Entering directory '/home/git/linux/tools/perf'
BUILD: Doing 'make -j4' parallel build
make: Leaving directory '/home/git/linux/tools/perf'
$Because we now have two different feature detection state files:
$ ls -la /tmp/build/perf/FEATURE-DUMP* -rw-rw-r--. 1 acme acme 338 Sep 21 17:25 /tmp/build/perf/FEATURE-DUMP -rw-rw-r--. 1 acme acme 33 Sep 21 17:25 /tmp/build/perf/FEATURE-DUMP.libbpf $
--- tools/lib/bpf/Makefile | 1 + 1 file changed, 1 insertion(+)
tools/lib/bpf/Makefile +1 -0
@@ -64,6 +64,7 @@ srctree := $(patsubst %/,%,$(dir $(srctree))) #$(info Determined 'srctree' to be $(srctree)) endif +FEATURE_USER = .libbpf FEATURE_TESTS = libelf libelf-getphdrnum libelf-mmap bpf FEATURE_DISPLAY = libelf bpf
Signature · 1 line
2.1.0
Arnaldo Carvalho de Melo
maintainerPATCH 7/9 perf tools: Add include/err.h into MANIFEST
In reply to Arnaldo Carvalho de MeloFrom: Jiri Olsa <[email protected]>
Otherwise the tarpkg is incomplete (tarpkg tests fails).
--- tools/perf/MANIFEST | 1 + 1 file changed, 1 insertion(+)
tools/perf/MANIFEST +1 -0
@@ -50,6 +50,7 @@ tools/include/linux/poison.h tools/include/linux/rbtree.h tools/include/linux/rbtree_augmented.h tools/include/linux/types.h +tools/include/linux/err.h include/asm-generic/bitops/arch_hweight.h include/asm-generic/bitops/const_hweight.h include/asm-generic/bitops/fls64.h
Signature · 1 line
2.1.0
Arnaldo Carvalho de Melo
maintainerPATCH 8/9 tools vm: Fix build due to removal of tools/lib/api/fs/debugfs.h
In reply to Arnaldo Carvalho de MeloFrom: Arnaldo Carvalho de Melo <[email protected]>
There were some changes in how this debugfs mounting helper is implemented/exported and we forgot to check if there were other users besides perf, fix it.
Need to do a make -C tools/ everytime we do changes to tools/{lib,include} and other places where we're moving things from tools/perf/ to be used by other tools/ living code.
Fixed:
$ make -C tools/vm
make: Entering directory '/home/git/linux/tools/vm'
make -C ../lib/api
make[1]: Entering directory '/home/git/linux/tools/lib/api'
CC fd/array.o
LD fd/libapi-in.o
CC fs/fs.o
CC fs/tracing_path.o
LD fs/libapi-in.o
CC cpu.o
LD libapi-in.o
AR libapi.a
make[1]: Leaving directory '/home/git/linux/tools/lib/api'
gcc -Wall -Wextra -I../lib/ -o page-types page-types.c ../lib/api/libapi.a
make: Leaving directory '/home/git/linux/tools/vm'
$--- tools/vm/page-types.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
tools/vm/page-types.c +3 -3
@@ -42,7 +42,7 @@#include <sys/mman.h> #include "../../include/uapi/linux/magic.h" #include "../../include/uapi/linux/kernel-page-flags.h" -#include <api/fs/debugfs.h> +#include <api/fs/fs.h> #ifndef MAX_PATH # define MAX_PATH 256
@@ -188,7 +188,7 @@ static int kpageflags_fd;static int opt_hwpoison;static int opt_unpoison; -static char *hwpoison_debug_fs; +static const char *hwpoison_debug_fs;static int hwpoison_inject_fd;static int hwpoison_forget_fd;
@@ -487,7 +487,7 @@ static void prepare_hwpoison_fd(void) {char buf[MAX_PATH +1 ]; - hwpoison_debug_fs =debugfs_mount (NULL ); + hwpoison_debug_fs =debugfs__mount ();if (!hwpoison_debug_fs) {perror ("mount debugfs" );exit (EXIT_FAILURE );
Signature · 1 line
2.1.0
Arnaldo Carvalho de Melo
maintainerPATCH 9/9 perf record: Synthesize COMM event for a command line workload
In reply to Arnaldo Carvalho de MeloFrom: Namhyung Kim <[email protected]>
When perf creates a new child to profile, the events are enabled on exec(). And in this case, it doesn't synthesize any event for the child since they'll be generated during exec(). But there's an window between the enabling and the event generation.
It used to be overcome since samples are only in kernel (so we always have the map) and the comm is overridden by a later COMM event. However it won't work if events are processed and displayed before the COMM event overrides like in 'perf script'. This leads to those early samples (like native_write_msr_safe) not having a comm but pid (like ':15328').
So it needs to synthesize COMM event for the child explicitly before enabling so that it can have a correct comm. But at this time, the comm will be "perf" since it's not exec-ed yet.
Committer note:
Before this patch:
# perf record usleep 1
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.017 MB perf.data (7 samples) ]
# perf script --show-task-events
:4429 4429 27909.079372: 1 cycles: ffffffff8105f45a native_write_msr_safe (/lib/modules/4.
:4429 4429 27909.079375: 1 cycles: ffffffff8105f45a native_write_msr_safe (/lib/modules/4.
:4429 4429 27909.079376: 10 cycles: ffffffff8105f45a native_write_msr_safe (/lib/modules/4.
:4429 4429 27909.079377: 223 cycles: ffffffff8105f45a native_write_msr_safe (/lib/modules/4.
:4429 4429 27909.079378: 6571 cycles: ffffffff8105f45a native_write_msr_safe (/lib/modules/4.
usleep 4429 27909.079380: PERF_RECORD_COMM exec: usleep:4429/4429
usleep 4429 27909.079381: 185403 cycles: ffffffff810a72d3 flush_signal_handlers (/lib/modules/4.
usleep 4429 27909.079444: 2241110 cycles: 7fc575355be3 _dl_start (/usr/lib64/ld-2.20.so)
usleep 4429 27909.079875: PERF_RECORD_EXIT(4429:4429):(4429:4429)After:
# perf record usleep 1
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.017 MB perf.data (7 samples) ]
# perf script --show-task
perf 0 0.000000: PERF_RECORD_COMM: perf:8446/8446
perf 8446 30154.038944: 1 cycles: ffffffff8105f45a native_write_msr_safe (/lib/modules/4.
perf 8446 30154.038948: 1 cycles: ffffffff8105f45a native_write_msr_safe (/lib/modules/4.
perf 8446 30154.038949: 9 cycles: ffffffff8105f45a native_write_msr_safe (/lib/modules/4.
perf 8446 30154.038950: 230 cycles: ffffffff8105f45a native_write_msr_safe (/lib/modules/4.
perf 8446 30154.038951: 6772 cycles: ffffffff8105f45a native_write_msr_safe (/lib/modules/4.
usleep 8446 30154.038952: PERF_RECORD_COMM exec: usleep:8446/8446
usleep 8446 30154.038954: 196923 cycles: ffffffff81766440 _raw_spin_lock (/lib/modules/4.3.0-rc1
usleep 8446 30154.039021: 2292130 cycles: 7f609a173dc4 memcpy (/usr/lib64/ld-2.20.so)
usleep 8446 30154.039349: PERF_RECORD_EXIT(8446:8446):(8446:8446)
#--- tools/perf/builtin-record.c | 15 ++++++++++++++- tools/perf/util/event.c | 2 +- tools/perf/util/event.h | 5 +++++ 3 files changed, 20 insertions(+), 2 deletions(-)
tools/perf/builtin-record.c +14 -1
@@ -636,8 +636,21 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)/* * Let the child rip */ -if (forks) +if (forks) { +union perf_event event; +/* +* Some H/W events are generated before COMM event +* which is emitted during exec(), so perf script +* cannot see a correct process name for those events. +* Synthesize COMM event to prevent it. +*/ +perf_event__synthesize_comm (tool, &event, + rec->evlist->workload.pid, + process_synthesized_event, + machine); +perf_evlist__start_workload (rec->evlist); + }if (opts->initial_delay) {usleep (opts->initial_delay *1000 );
tools/perf/util/event.c +1 -1
@@ -167,7 +167,7 @@ static int perf_event__prepare_comm(union perf_event *event, pid_t pid,return 0 ; } -static pid_t perf_event__synthesize_comm (struct perf_tool *tool, +pid_t perf_event__synthesize_comm (struct perf_tool *tool,union perf_event *event,pid_t pid,perf_event__handler_t process,struct machine *machine)
tools/perf/util/event.h +5 -0
@@ -478,6 +478,11 @@ int perf_event__synthesize_sample(union perf_event *event, u64 type,const struct perf_sample *sample, bool swapped); +pid_t perf_event__synthesize_comm (struct perf_tool *tool, +union perf_event *event,pid_t pid, +perf_event__handler_t process, +struct machine *machine); + int perf_event__synthesize_mmap_events(struct perf_tool *tool, union perf_event *event, pid_t pid, pid_t tgid,
Signature · 1 line
2.1.0
Quoted 68 lines · Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit
96f3eda67fcf2598e9d2794398e0e7ab35138ea6:perf/x86/intel: Fix static checker warning in lbr enable (2015-09-18 09:24:57 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.gittags/perf-core-for-mingofor you to fetch changes up to
e803cf97a4f90d31bcc2c9a1ea20fe9cdc12b2f9:perf record: Synthesize COMM event for a command line workload (2015-09-22 22:43:12 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:User visible:
- Fix a segfault in 'perf probe' when removing uprobe events (Masami Hiramatsu)
- Synthesize COMM event for workloads started from the command line in 'perf record' so that we can have the
pid->commmapping before we get the realPERF_RECORD_COMMswitching from perf to the workload (Namhyung Kim)- Fix build
tools/vm/due to removal oftools/lib/api/fs/debugfs.h(Arnaldo Carvalho de Melo)Developer stuff:
- Fix the make tarball targets by including the recently added
err.hheader in the perf MANIFEST file (Jiri Olsa)- Don't assume that the event parser returns a non empty evlist (Wang Nan)
- Add way to disambiguate feature detection state files, needed to use
tools/buildfeature detection for multiple components in a single O= output dir, which will be the case withtools/perf/andtools/lib/bpf/(Arnaldo Carvalho de Melo)- Fixup FEATURE_{TESTS,DISPLAY} inversion in
tools/lib/bpf/(Arnaldo Carvalho de Melo)Signed-off-by Arnaldo Carvalho de Melo <[email protected]>----------------------------------------------------------------
Arnaldo Carvalho de Melo (5):
tools build: Fixup feature detection display function name tools lib bpf: Fix up FEATURE_{TESTS,DISPLAY} usage
tools build: Allow setting the feature detection user
tools lib bpf: UseFEATURE_USERto allow building in the same dir as perf tools vm: Fix build due to removal oftools/lib/api/fs/debugfs.hJiri Olsa (1):
perf tools: Addinclude/err.hinto MANIFESTMasami Hiramatsu (1):
perf probe: Fix a segfault when removing uprobe eventsNamhyung Kim (1):
perf record: Synthesize COMM event for a command line workloadWang Nan (1):
perf tools: Don't assume that the parser returns non empty evsel list
Quoted 10 lines
tools/build/Makefile.feature | 9 +++++---- tools/lib/bpf/Makefile | 5 +++-- tools/perf/MANIFEST | 1 + tools/perf/builtin-probe.c | 7 +++++-- tools/perf/builtin-record.c | 15 ++++++++++++++- tools/perf/util/event.c | 2 +- tools/perf/util/event.h | 5 +++++ tools/perf/util/parse-events.c | 16 ++++++++++++++++ tools/vm/page-types.c | 6 +++--- 9 files changed, 53 insertions(+), 13 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo