memcg: remove pcp_counter_lock
Subsystems (3)
PATCH 1/1 memcg: remove pcp_counter_lock
Commit 733a572e66d2 ("memcg: make mem_cgroup_read_{stat|event}() iterate possible cpus instead of online") removed the last use of the per memcg pcp_counter_lock but forgot to remove the variable.
Kill the vestigial variable.
Signed-off-by Greg Thelen <[email protected]>
--- include/linux/memcontrol.h | 1 - mm/memcontrol.c | 1 - 2 files changed, 2 deletions(-)
include/linux/memcontrol.h +0 -1
@@ -242,7 +242,6 @@ struct mem_cgroup {* percpu counter. */ struct mem_cgroup_stat_cpu __percpu *stat; -spinlock_t pcp_counter_lock;#if defined(CONFIG_MEMCG_KMEM ) && defined(CONFIG_INET )struct cg_proto tcp_mem;
mm/memcontrol.c +0 -1
@@ -4179,7 +4179,6 @@ static struct mem_cgroup *mem_cgroup_alloc(void)if (memcg_wb_domain_init (memcg,GFP_KERNEL )) goto out_free_stat; -spin_lock_init (&memcg->pcp_counter_lock);return memcg; out_free_stat:
Signature · 7 lines
2.6.0.rc0.131.gf624c3d -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 7 lines · Greg Thelen
Commit
733a572e66d2("memcg: make mem_cgroup_read_{stat|event}() iterate possible cpus instead of online") removed the last use of the per memcgpcp_counter_lockbut forgot to remove the variable.Kill the vestigial variable.
Signed-off-by Greg Thelen <[email protected]>
Quoted 31 lines
--- include/linux/memcontrol.h | 1 - mm/memcontrol.c | 1 - 2 files changed, 2 deletions(-)include/linux/memcontrol.h +0
-1@@ -242,7 +242,6 @@ struct mem_cgroup {* percpu counter. */ struct mem_cgroup_stat_cpu __percpu *stat; -spinlock_t pcp_counter_lock;#if defined(CONFIG_MEMCG_KMEM ) && defined(CONFIG_INET )struct cg_proto tcp_mem;mm/memcontrol.c +0
-1@@ -4179,7 +4179,6 @@ static struct mem_cgroup *mem_cgroup_alloc(void)if (memcg_wb_domain_init (memcg,GFP_KERNEL )) goto out_free_stat; -spin_lock_init (&memcg->pcp_counter_lock);return memcg; out_free_stat:Signature · 1 line
2.6.0.rc0.131.gf624c3d
Signature · 2 lines
Michal Hocko SUSE Labs
Quoted 7 lines · Greg Thelen
Commit
733a572e66d2("memcg: make mem_cgroup_read_{stat|event}() iterate possible cpus instead of online") removed the last use of the per memcgpcp_counter_lockbut forgot to remove the variable.Kill the vestigial variable.
Signed-off-by Greg Thelen <[email protected]>
Acked-by Johannes Weiner <[email protected]>