Skip to contentSkip to conversation

Patch "cxl: Allow release of contexts which have been OPENED but not STARTED" has been added to the 4.2-stable tree

PATCH [email protected] 1 participant 1 message Sep 23, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

cxl: Allow release of contexts which have been OPENED but not STARTED

to the 4.2-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
cxl-allow-release-of-contexts-which-have-been-opened-but-not-started.patch
and it can be found in the queue-4.2 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 7c26b9cf5347c24272152438cdd9675183804425 Mon Sep 17 00:00:00 2001

From: Andrew Donnellan <[email protected]>
Date: Wed, 19 Aug 2015 09:27:18 +1000
Subject: cxl: Allow release of contexts which have been OPENED but not STARTED

From: Andrew Donnellan <[email protected]>

commit 7c26b9cf5347c24272152438cdd9675183804425 upstream.

If we open a context but do not start it (either because we do not attempt to start it, or because it fails to start for some reason), we are left with a context in state OPENED. Previously, cxl_release_context() only allowed releasing contexts in state CLOSED, so attempting to release an OPENED context would fail.

In particular, this bug causes available contexts to run out after some EEH failures, where drivers attempt to release contexts that have failed to start.

Allow releasing contexts in any state with a value lower than STARTED, i.e. OPENED or CLOSED (we can't release a STARTED context as it's currently using the hardware, and we assume that contexts in any new states which may be added in future with a value higher than STARTED are also unsafe to release).

Fixes 6f7f0b3df6d4 ("cxl: Add AFU virtual PHB and kernel API")
---
 drivers/misc/cxl/api.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/cxl/api.c +1 -1
@@ -59,7 +59,7 @@ EXPORT_SYMBOL_GPL(cxl_get_phys_dev);
 
 int cxl_release_context(struct cxl_context *ctx)
 {
-	if (ctx->status != CLOSED)
+	if (ctx->status >= STARTED)
 		return -EBUSY;
 
 	put_device(&ctx->afu->dev);

Patches currently in stable-queue which might be from [email protected] are

queue-4.2/cxl-allow-release-of-contexts-which-have-been-opened-but-not-started.patch