Btrfs: end transaction if we abort when creating qgroup root
PATCH 1/1 Btrfs: end transaction if we abort when creating qgroup root
We still need to call btrfs_end_transaction if we call btrfs_abort_transaction, otherwise we hang and make me super grumpy. Thanks,
--- fs/btrfs/volumes.c | 1 + 1 file changed, 1 insertion(+)
fs/btrfs/volumes.c +1 -0
@@ -4028,6 +4028,7 @@ int btrfs_create_uuid_tree(struct btrfs_fs_info *fs_info)if (IS_ERR (uuid_root)) { ret =PTR_ERR (uuid_root);btrfs_abort_transaction (trans, tree_root, ret); +btrfs_end_transaction (trans, root);return ret; }
Signature · 1 line
1.8.3.1
PATCH v2 1/1 Btrfs: end transaction if we abort when creating qgroup root
We still need to call btrfs_end_transaction if we call btrfs_abort_transaction, otherwise we hang and make me super grumpy. Thanks,
---V1->V2: should have compiled before I hit send.
fs/btrfs/volumes.c | 1 + 1 file changed, 1 insertion(+)
fs/btrfs/volumes.c +1 -0
@@ -4028,6 +4028,7 @@ int btrfs_create_uuid_tree(struct btrfs_fs_info *fs_info)if (IS_ERR (uuid_root)) { ret =PTR_ERR (uuid_root);btrfs_abort_transaction (trans, tree_root, ret); +btrfs_end_transaction (trans, tree_root);return ret; }
Signature · 1 line
1.8.3.1
Quoted 2 lines · Josef Bacik
We still need to call
btrfs_end_transactionif we callbtrfs_abort_transaction, otherwise we hang and make me super grumpy. Thanks,
I made the same mistake in the free space tree, I'll fix that before I forget.
fs/btrfs/volumes.c int btrfs_create_uuid_tree(struct btrfs_fs_info *fs_info)
Quoted 12 lines
Signed-off-by Josef Bacik <[email protected]>---
V1->V2: should have compiled before I hit send.fs/btrfs/volumes.c | 1 + 1 file changed, 1 insertion(+)fs/btrfs/volumes.c +0
-0@@ -4028,6 +4028,7 @@ int btrfs_create_uuid_tree(struct btrfs_fs_info *fs_info)
The subject says the qgroup root but this is the uuid tree.
Quoted 9 lines
fs/btrfs/volumes.c +1
-0if (IS_ERR (uuid_root)) { ret =PTR_ERR (uuid_root);btrfs_abort_transaction (trans, tree_root, ret); +btrfs_end_transaction (trans, tree_root);return ret; }Signature · 1 line
1.8.3.1
Signature · 1 line
Omar