Skip to contentSkip to conversation

Staging: rtl8712: rtl871x_io.h: Coding style warning fix for block comments

PATCH In review Punit Vara 2 participants 3 messages Sep 23, 2015 – Sep 24, 2015 Staging

lore
Share & tools
lore

Punit Vara

author
#0 lore raw

PATCH 1/1 Staging: rtl8712: rtl871x_io.h: Coding style warning fix for block comments

This patch is to the rtl871x_io.h file that fixes up following warning reported by checkpatch.pl :

---
 drivers/staging/rtl8712/rtl871x_io.h | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)
drivers/staging/rtl8712/rtl871x_io.h +5 -10
index 070cc03..9313943 100644
@@ -48,10 +48,9 @@
 #define _IO_SYNC_		BIT(13)
 #define _IO_CMDMASK_	(0x1F80)
 
-/*
-	For prompt mode accessing, caller shall free io_req
-	Otherwise, io_handler will free io_req
-*/
+/* For prompt mode accessing, caller shall free io_req
+ * Otherwise, io_handler will free io_req
+ */
 /* IO STATUS TYPE */
 #define _IO_ERR_		BIT(2)
 #define _IO_SUCCESS_	BIT(1)
@@ -68,9 +67,7 @@
 #define IO_WR32_ASYNC	(_IO_WRITE_ | _IO_WORD_)
 #define IO_WR16_ASYNC	(_IO_WRITE_ | _IO_HW_)
 #define IO_WR8_ASYNC	(_IO_WRITE_ | _IO_BYTE_)
-/*
-	Only Sync. burst accessing is provided.
-*/
+/* Only Sync. burst accessing is provided.*/
 #define IO_WR_BURST(x)		(IO_WRITE_ | _IO_SYNC_ | _IO_BURST_ | \
 				((x) & _IOSZ_MASK_))
 #define IO_RD_BURST(x)		(_IO_SYNC_ | _IO_BURST_ | ((x) & _IOSZ_MASK_))
@@ -217,9 +214,7 @@ struct reg_protocol_wt {
 #endif
 };
 
-/*
-Below is the data structure used by _io_handler
-*/
+/* Below is the data structure used by _io_handler */
 
 struct io_queue {
 	spinlock_t lock;
Signature · 1 line
2.5.2
#1 lore raw
Quoted 5 lines · Punit Vara

This patch is to the rtl871x_io.h file that fixes up following warning reported by checkpatch.pl :

---

You missed copying the warning after mentioning "following warning" in your commit message.

regards
sudip

author
#2 lore raw
Quoted 11 lines · Sudip Mukherjee
Quoted 5 lines · Punit Vara

This patch is to the rtl871x_io.h file that fixes up following warning reported by checkpatch.pl :

---

You missed copying the warning after mentioning "following warning" in your commit message.

regards
sudip

Surely I will resend it .First let Greg say whether I have to send in series or is it okay as it is. This was first time I have tried to fix so many warnings in different problems. Whatever patch having issues I would be happy to resend.
Thank you for feedback and evaluation.