Skip to contentSkip to conversation

drm/gma500: Remove DP_LINK_STATUS_SIZE redefinition

PATCH Applied Thierry Reding 3 participants 3 messages Sep 24, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/gma500: Remove DP_LINK_STATUS_SIZE redefinition

From: Thierry Reding <[email protected]>

The DRM/DP helpers already contain a definition for this macro. Remove the duplicate in the GMA500 driver to avoid having to keep both updated synchronously.

Cc Patrik Jakobsson <[email protected]>
---
 drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/gma500/cdv_intel_dp.c +0 -1
index 0fafb8e2483a..17cea400ae32 100644
@@ -247,7 +247,6 @@ i2c_dp_aux_add_bus(struct i2c_adapter *adapter)
 
 #define wait_for(COND, MS) _wait_for(COND, MS, 1)
 
-#define DP_LINK_STATUS_SIZE	6
 #define DP_LINK_CHECK_TIMEOUT	(10 * 1000)
 
 #define DP_LINK_CONFIGURATION_SIZE	9
Signature · 6 lines
2.5.0

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Thierry Reding

From: Thierry Reding <[email protected]>

The DRM/DP helpers already contain a definition for this macro. Remove the duplicate in the GMA500 driver to avoid having to keep both updated synchronously.

Cc Patrik Jakobsson <[email protected]>
Quoted 17 lines
---
 drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/gma500/cdv_intel_dp.c +0 -2
index 0fafb8e2483a..17cea400ae32 100644
@@ -247,7 +247,6 @@ i2c_dp_aux_add_bus(struct i2c_adapter *adapter)
 
 #define wait_for(COND, MS) _wait_for(COND, MS, 1)
 
-#define DP_LINK_STATUS_SIZE    6
 #define DP_LINK_CHECK_TIMEOUT  (10 * 1000)
 
 #define DP_LINK_CONFIGURATION_SIZE     9
--
Quoted 2 lines

2.5.0

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#2 lore raw
Quoted 4 lines · Patrik Jakobsson
Quoted 2 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Quoted 8 lines
Quoted 6 lines

The DRM/DP helpers already contain a definition for this macro. Remove the duplicate in the GMA500 driver to avoid having to keep both updated synchronously.

Cc Patrik Jakobsson <[email protected]>

Applied to drm-misc, thanks.
-Daniel

Quoted 24 lines
Quoted 18 lines
---
 drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/gma500/cdv_intel_dp.c +0 -2
index 0fafb8e2483a..17cea400ae32 100644
@@ -247,7 +247,6 @@ i2c_dp_aux_add_bus(struct i2c_adapter *adapter)
 
 #define wait_for(COND, MS) _wait_for(COND, MS, 1)
 
-#define DP_LINK_STATUS_SIZE    6
 #define DP_LINK_CHECK_TIMEOUT  (10 * 1000)
 
 #define DP_LINK_CONFIGURATION_SIZE     9
--
Quoted 2 lines

2.5.0

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel