Skip to contentSkip to conversation

fsl: Add binding for RCPM

PATCH New Dongsheng Wang 4 participants 11 messages Sep 24, 2015 – Oct 8, 2015 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/2 fsl: Add binding for RCPM

From: Wang Dongsheng <[email protected]>

RCPM is the Run Control and Power Management module performs all device-level tasks associated with device run control and power management.

Add this for freescale powerpc platform and layerscape platform.

---
*v3*
- Add "fsl,#rcpm-wakeup-cells" for rcpm node. The number of cells correspond rcpm-wakeup property.
- Modify rcpm-wakeup property description.

*v2*
- Remove P4080 example.
- Modify rcpm-wakeup property description.

Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +63 -0
new file mode 100644
index 0000000..52110ec
@@ -0,0 +1,63 @@
+* Run Control and Power Management
+-------------------------------------------
+The RCPM performs all device-level tasks associated with device run control
+and power management.
+
+Required properites:
+  - reg : Offset and length of the register set of RCPM block.
+  - fsl,#rcpm-wakeup-cells : The number of cells in rcpm-wakeup property.
+  - compatible : Sould contain a chip-specific RCPM block compatible string
+	and (if applicable) may contain a chassis-version RCPM compatible
+	string. Chip-specific strings are of the form "fsl,<chip>-rcpm",
+	such as:
+	* "fsl,p2041-rcpm"
+	* "fsl,p3041-rcpm"
+	* "fsl,p4080-rcpm"
+	* "fsl,p5020-rcpm"
+	* "fsl,p5040-rcpm"
+	* "fsl,t4240-rcpm"
+	* "fsl,b4420-rcpm"
+	* "fsl,b4860-rcpm"
+
+	Chassis-version strings are of the form "fsl,qoriq-rcpm-<version>",
+	such as:
+	* "fsl,qoriq-rcpm-1.0": for chassis 1.0 rcpm
+	* "fsl,qoriq-rcpm-2.0": for chassis 2.0 rcpm
+	* "fsl,qoriq-rcpm-2.1": for chassis 2.1 rcpm
+
+All references to "1.0" and "2.0" refer to the QorIQ chassis version to
+which the chip complies.
+Chassis Version		Example Chips
+---------------		-------------------------------
+1.0				p4080, p5020, p5040, p2041, p3041
+2.0				t4240, b4860, b4420
+2.1				t1040, ls1021
+
+Example:
+The RCPM node for T4240:
+	rcpm: global-utilities at e2000 {
+		compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0";
+		reg = <0xe2000 0x1000>;
+		fsl,#rcpm-wakeup-cells = <2>;
+	};
+
+* Freescale RCPM Wakeup Source Device Tree Bindings
+-------------------------------------------
+Required rcpm-wakeup property should be added to a device node if the device
+can be used as a wakeup source.
+
+  - rcpm-wakeup: The value of the property consists of cells, the number of
+	cells defined in "fsl,#rcpm-wakeup-cells". The first cell is a pointer
+	to the rcpm node, the second cell is the bit mask that should be set
+	in IPPDEXPCR0, and the third cell is for IPPDEXPCR1, and so on.
+
+Example:
+	lpuart0: serial at 2950000 {
+		compatible = "fsl,ls1021a-lpuart";
+		reg = <0x0 0x2950000 0x0 0x1000>;
+		interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&sysclk>;
+		clock-names = "ipg";
+		rcpm-wakeup = <&rcpm 0x0 0x40000000>;
+		status = "disabled";
+	};
Signature · 1 line
2.1.0.27.g96db324
#1 lore raw

PATCH v3 2/2 arm/layerscape: add RCPM device tree support for ls1021a.

From: Wang Dongsheng <[email protected]>

---
*v3*: Add "fsl,#rcpm-wakeup-cells" for rcpm node.
*v2*: No changes.

arch/arm/boot/dts/ls1021a.dtsi +8 -0
index 973a496..ac5f9a2 100644
@@ -139,6 +139,7 @@
 			sdhci,auto-cmd12;
 			big-endian;
 			bus-width = <4>;
+			rcpm-wakeup = <&rcpm 0x00000080 0x0>;
 			status = "disabled";
 		};
 
@@ -186,6 +187,12 @@
 			};
 		};
 
+		rcpm: rcpm at 1ee2000 {
+			compatible = "fsl,ls1021a-rcpm", "fsl,qoriq-rcpm-2.1";
+			reg = <0x0 0x1ee2000 0x0 0x10000>;
+			fsl,#rcpm-wakeup-cells = <3>;
+		};
+
 		dspi0: dspi at 2100000 {
 			compatible = "fsl,ls1021a-v1.0-dspi";
 			#address-cells = <1>;
@@ -287,6 +294,7 @@
 			interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&sysclk>;
 			clock-names = "ipg";
+			rcpm-wakeup = <&rcpm 0x0 0x40000000>;
 			status = "disabled";
 		};
 
Signature · 1 line
2.1.0.27.g96db324
#2 lore raw

PATCH v3 1/2 fsl: Add binding for RCPM

In reply to Dongsheng Wang
Quoted 66 lines · Dongsheng Wang

From: Wang Dongsheng <[email protected]>

RCPM is the Run Control and Power Management module performs all device-level tasks associated with device run control and power management.

Add this for freescale powerpc platform and layerscape platform.

---
*v3*
- Add "fsl,#rcpm-wakeup-cells" for rcpm node. The number of cells correspond rcpm-wakeup property.
- Modify rcpm-wakeup property description.

*v2*
- Remove P4080 example.
- Modify rcpm-wakeup property description.

Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +39 -0
new file mode 100644
index 0000000..52110ec
@@ -0,0 +1,63 @@
+* Run Control and Power Management
+-------------------------------------------
+The RCPM performs all device-level tasks associated with device run control
+and power management.
+
+Required properites:
+  - reg : Offset and length of the register set of RCPM block.
+  - fsl,#rcpm-wakeup-cells : The number of cells in rcpm-wakeup property.
+  - compatible : Sould contain a chip-specific RCPM block compatible string
+	and (if applicable) may contain a chassis-version RCPM compatible
+	string. Chip-specific strings are of the form "fsl,<chip>-rcpm",
+	such as:
+	* "fsl,p2041-rcpm"
+	* "fsl,p3041-rcpm"
+	* "fsl,p4080-rcpm"
+	* "fsl,p5020-rcpm"
+	* "fsl,p5040-rcpm"
+	* "fsl,t4240-rcpm"
+	* "fsl,b4420-rcpm"
+	* "fsl,b4860-rcpm"
+
+	Chassis-version strings are of the form "fsl,qoriq-rcpm-<version>",
+	such as:
+	* "fsl,qoriq-rcpm-1.0": for chassis 1.0 rcpm
+	* "fsl,qoriq-rcpm-2.0": for chassis 2.0 rcpm
+	* "fsl,qoriq-rcpm-2.1": for chassis 2.1 rcpm
+
+All references to "1.0" and "2.0" refer to the QorIQ chassis version to
+which the chip complies.
+Chassis Version		Example Chips
+---------------		-------------------------------
+1.0				p4080, p5020, p5040, p2041, p3041
+2.0				t4240, b4860, b4420
+2.1				t1040, ls1021
+
+Example:
+The RCPM node for T4240:
+	rcpm: global-utilities at e2000 {
+		compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0";

Documentation/devicetree/bindings/soc/fsl/rcpm.txt line 49

Quoted 10 lines
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +10 -0
+		reg = <0xe2000 0x1000>;
+		fsl,#rcpm-wakeup-cells = <2>;
+	};
+
+* Freescale RCPM Wakeup Source Device Tree Bindings
+-------------------------------------------
+Required rcpm-wakeup property should be added to a device node if the device
+can be used as a wakeup source.
+
+  - rcpm-wakeup: The value of the property consists of cells, the number of

Shouldn't this vendor specific property be prefixed with 'fsl,' as well?

Documentation/devicetree/bindings/soc/fsl/rcpm.txt line 52

Quoted 3 lines
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +3 -0
+	cells defined in "fsl,#rcpm-wakeup-cells". The first cell is a pointer
+	to the rcpm node, the second cell is the bit mask that should be set
+	in IPPDEXPCR0, and the third cell is for IPPDEXPCR1, and so on.

I guess that IPPDEXPCR0 and IPPDEXPCR1 need some documentation too, or a pointer to hardware documents containing more detailed info about them.

Shawn

Quoted 19 lines
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +11 -0
+
+Example:
+	lpuart0: serial at 2950000 {
+		compatible = "fsl,ls1021a-lpuart";
+		reg = <0x0 0x2950000 0x0 0x1000>;
+		interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&sysclk>;
+		clock-names = "ipg";
+		rcpm-wakeup = <&rcpm 0x0 0x40000000>;
+		status = "disabled";
+	};
Signature · 7 lines
2.1.0.27.g96db324


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#3 lore raw

PATCH v3 1/2 fsl: Add binding for RCPM

Hi Shawn,

Thanks for your review.

Quoted 72 lines
Quoted 72 lines

From: Wang Dongsheng <[email protected]>

RCPM is the Run Control and Power Management module performs all device-level tasks associated with device run control and power management.

Add this for freescale powerpc platform and layerscape platform.

---
*v3*
- Add "fsl,#rcpm-wakeup-cells" for rcpm node. The number of cells correspond rcpm-wakeup property.
- Modify rcpm-wakeup property description.

*v2*
- Remove P4080 example.
- Modify rcpm-wakeup property description.

Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +44 -0
new file mode 100644
index 0000000..52110ec
@@ -0,0 +1,63 @@
+* Run Control and Power Management
+-------------------------------------------
+The RCPM performs all device-level tasks associated with device run
+control and power management.
+
+Required properites:
+  - reg : Offset and length of the register set of RCPM block.
+  - fsl,#rcpm-wakeup-cells : The number of cells in rcpm-wakeup property.
+  - compatible : Sould contain a chip-specific RCPM block compatible string
+	and (if applicable) may contain a chassis-version RCPM compatible
+	string. Chip-specific strings are of the form "fsl,<chip>-rcpm",
+	such as:
+	* "fsl,p2041-rcpm"
+	* "fsl,p3041-rcpm"
+	* "fsl,p4080-rcpm"
+	* "fsl,p5020-rcpm"
+	* "fsl,p5040-rcpm"
+	* "fsl,t4240-rcpm"
+	* "fsl,b4420-rcpm"
+	* "fsl,b4860-rcpm"
+
+	Chassis-version strings are of the form "fsl,qoriq-rcpm-<version>",
+	such as:
+	* "fsl,qoriq-rcpm-1.0": for chassis 1.0 rcpm
+	* "fsl,qoriq-rcpm-2.0": for chassis 2.0 rcpm
+	* "fsl,qoriq-rcpm-2.1": for chassis 2.1 rcpm
+
+All references to "1.0" and "2.0" refer to the QorIQ chassis version
+to which the chip complies.
+Chassis Version		Example Chips
+---------------		-------------------------------
+1.0				p4080, p5020, p5040, p2041, p3041
+2.0				t4240, b4860, b4420
+2.1				t1040, ls1021
+
+Example:
+The RCPM node for T4240:
+	rcpm: global-utilities at e2000 {
+		compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0";
+		reg = <0xe2000 0x1000>;
+		fsl,#rcpm-wakeup-cells = <2>;
+	};
+
+* Freescale RCPM Wakeup Source Device Tree Bindings
Quoted 9 lines

Documentation/devicetree/bindings/soc/fsl/rcpm.txt line 50

Quoted 6 lines
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +6 -0
+-------------------------------------------
+Required rcpm-wakeup property should be added to a device node if the
+device can be used as a wakeup source.
+
+  - rcpm-wakeup: The value of the property consists of cells, the
+ number of

Shouldn't this vendor specific property be prefixed with 'fsl,' as well?

Okay.

Quoted 7 lines

Documentation/devicetree/bindings/soc/fsl/rcpm.txt line 52

Quoted 3 lines
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +3 -0
+	cells defined in "fsl,#rcpm-wakeup-cells". The first cell is a pointer
+	to the rcpm node, the second cell is the bit mask that should be set
+	in IPPDEXPCR0, and the third cell is for IPPDEXPCR1, and so on.

I guess that IPPDEXPCR0 and IPPDEXPCR1 need some documentation too, or a pointer to hardware documents containing more detailed info about them.

Following the "rcpm-wakeup" documents put a "Note" to describe IPPDEXPCRx registers?

Regards,
-Dongsheng

#4 lore raw

PATCH v3 1/2 fsl: Add binding for RCPM

In reply to Dongsheng Wang

Documentation/devicetree/bindings/soc/fsl/rcpm.txt line 52

Quoted 10 lines · Dongsheng Wang
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +3 -0
+* Freescale RCPM Wakeup Source Device Tree Bindings
+-------------------------------------------
+Required rcpm-wakeup property should be added to a device node if the 

device

Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +6 -0
+can be used as a wakeup source.
+
+  - rcpm-wakeup: The value of the property consists of cells, the number of
+     cells defined in "fsl,#rcpm-wakeup-cells". The first cell is a pointer
+     to the rcpm node, the second cell is the bit mask that should be set
+     in IPPDEXPCR0, and the third cell is for IPPDEXPCR1, and so on.

The phandle should not be included in the cell count.

-Scott

#5 lore raw

PATCH v3 1/2 fsl: Add binding for RCPM

Quoted 4 lines
Quoted 4 lines
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +3 -0
+* Freescale RCPM Wakeup Source Device Tree Bindings
+-------------------------------------------
+Required rcpm-wakeup property should be added to a device node if the

device

Quoted 9 lines

Documentation/devicetree/bindings/soc/fsl/rcpm.txt line 52

Quoted 6 lines
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +6 -0
+can be used as a wakeup source.
+
+  - rcpm-wakeup: The value of the property consists of cells, the number of
+     cells defined in "fsl,#rcpm-wakeup-cells". The first cell is a pointer
+     to the rcpm node, the second cell is the bit mask that should be set
+     in IPPDEXPCR0, and the third cell is for IPPDEXPCR1, and so on.

The phandle should not be included in the cell count.

Yes, the first cell "&rcpm" should be in the cell count, right?

Regards,
-Dongsheng

#6 lore raw

PATCH v3 1/2 fsl: Add binding for RCPM

Quoted 17 lines · On Thu, 2015-09-24 at 21:38 -0500, Wang Dongsheng-B40534 wrote:
Quoted 7 lines
Quoted 7 lines
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +3 -0
+* Freescale RCPM Wakeup Source Device Tree Bindings
+-------------------------------------------
+Required rcpm-wakeup property should be added to a device node if the

device

Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +3 -0
+can be used as a wakeup source.
+
+  - rcpm-wakeup: The value of the property consists of cells, the 
Quoted 9 lines
Quoted 6 lines

number of
+ cells defined in "fsl,#rcpm-wakeup-cells". The first cell is a
pointer
+ to the rcpm node, the second cell is the bit mask that should be
set
+ in IPPDEXPCR0, and the third cell is for IPPDEXPCR1, and so on.

The phandle should not be included in the cell count.

Quoted 1 line

Yes, the first cell "&rcpm" should be in the cell count, right?

No. None of the other #foo-cells work that way.

-Scott

#7 lore raw

PATCH v3 1/2 fsl: Add binding for RCPM

Quoted 18 lines · On Thu, 2015-09-24 at 21:38 -0500, Wang Dongsheng-B40534 wrote:
Quoted 17 lines
Quoted 16 lines
Quoted 7 lines
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +3 -0
+* Freescale RCPM Wakeup Source Device Tree Bindings
+-------------------------------------------
+Required rcpm-wakeup property should be added to a device node if the

device

Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +3 -0
+can be used as a wakeup source.
+
+  - rcpm-wakeup: The value of the property consists of cells, the
Quoted 6 lines

number of
+ cells defined in "fsl,#rcpm-wakeup-cells". The first cell is a
pointer
+ to the rcpm node, the second cell is the bit mask that should be
set
+ in IPPDEXPCR0, and the third cell is for IPPDEXPCR1, and so on.

The phandle should not be included in the cell count.

Quoted 4 lines
Quoted 1 line

Yes, the first cell "&rcpm" should be in the cell count, right?

No. None of the other #foo-cells work that way.

Sorry a type wrong. I means the first cell "&rcpm" should *NOT* be in the cell count.

Regards,
-Dongsheng

A message that is not in the archive (sent off-list or not yet received): CALRxmdDwGgxCG5SfSOaEXK8_fJcG4UUw_9D2=NA7nQhikDyb+A@mail.gmail.com

#9 lore raw

PATCH v3 1/2 fsl: Add binding for RCPM

Documentation/devicetree/bindings/soc/fsl/rcpm.txt line 7

Quoted 9 lines

+++ b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt

Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +7 -0
@@ -0,0 +1,63 @@
+* Run Control and Power Management
+-------------------------------------------
+The RCPM performs all device-level tasks associated with device run control
+and power management.
+
+Required properites:
+  - reg : Offset and length of the register set of RCPM block.

s/RCPM block/the RCPM block/

Documentation/devicetree/bindings/soc/fsl/rcpm.txt line 8

Quoted 1 line
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +1 -0
+  - fsl,#rcpm-wakeup-cells : The number of cells in rcpm-wakeup property.

s/rcpm-wakeup-property/the rcpm-wakeup-property/

Documentation/devicetree/bindings/soc/fsl/rcpm.txt line 9

Quoted 1 line
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +1 -0
+  - compatible : Sould contain a chip-specific RCPM block compatible string

s/Sould/Should

"Should" means it is recommended, but does not mean "must". Is it really optional?

Documentation/devicetree/bindings/soc/fsl/rcpm.txt line 20

Quoted 11 lines
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +11 -0
+       and (if applicable) may contain a chassis-version RCPM compatible
+       string. Chip-specific strings are of the form "fsl,<chip>-rcpm",
+       such as:
+       * "fsl,p2041-rcpm"
+       * "fsl,p3041-rcpm"
+       * "fsl,p4080-rcpm"
+       * "fsl,p5020-rcpm"
+       * "fsl,p5040-rcpm"
+       * "fsl,t4240-rcpm"
+       * "fsl,b4420-rcpm"
+       * "fsl,b4860-rcpm"

2 or 3 examples is enough.

Documentation/devicetree/bindings/soc/fsl/rcpm.txt line 34

Quoted 13 lines
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +13 -0
+       Chassis-version strings are of the form "fsl,qoriq-rcpm-<version>",
+       such as:
+       * "fsl,qoriq-rcpm-1.0": for chassis 1.0 rcpm
+       * "fsl,qoriq-rcpm-2.0": for chassis 2.0 rcpm
+       * "fsl,qoriq-rcpm-2.1": for chassis 2.1 rcpm
+
+All references to "1.0" and "2.0" refer to the QorIQ chassis version to
+which the chip complies.
+Chassis Version                Example Chips
+---------------                -------------------------------
+1.0                            p4080, p5020, p5040, p2041, p3041
+2.0                            t4240, b4860, b4420
+2.1                            t1040, ls1021

Not sure this binding is the place to maintain a table of chassis versions to SoCs.

Thanks,
Stuart

#10 lore raw

PATCH v3 1/2 fsl: Add binding for RCPM

Quoted 48 lines · On Thu, 2015-10-01 at 12:05 -0500, Yoder Stuart-B08248 wrote:

Documentation/devicetree/bindings/soc/fsl/rcpm.txt line 7

Quoted 10 lines

+++ b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt

Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +3 -0
@@ -0,0 +1,63 @@
+* Run Control and Power Management
+-------------------------------------------
+The RCPM performs all device-level tasks associated with device run 

control

Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +4 -0
+and power management.
+
+Required properites:
+  - reg : Offset and length of the register set of RCPM block.

s/RCPM block/the RCPM block/

Quoted 1 line

+ - fsl,#rcpm-wakeup-cells : The number of cells in rcpm-wakeup property.

s/rcpm-wakeup-property/the rcpm-wakeup-property/

Quoted 2 lines

+ - compatible : Sould contain a chip-specific RCPM block compatible string

s/Sould/Should

"Should" means it is recommended, but does not mean "must". Is it really optional?

Documentation/devicetree/bindings/soc/fsl/rcpm.txt line 20

Quoted 11 lines
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +11 -0
+       and (if applicable) may contain a chassis-version RCPM compatible
+       string. Chip-specific strings are of the form "fsl,<chip>-rcpm",
+       such as:
+       * "fsl,p2041-rcpm"
+       * "fsl,p3041-rcpm"
+       * "fsl,p4080-rcpm"
+       * "fsl,p5020-rcpm"
+       * "fsl,p5040-rcpm"
+       * "fsl,t4240-rcpm"
+       * "fsl,b4420-rcpm"
+       * "fsl,b4860-rcpm"

2 or 3 examples is enough.

Quoted 9 lines

+ Chassis-version strings are of the form "fsl,qoriq-rcpm-
<version>",

Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +7 -0
+       such as:
+       * "fsl,qoriq-rcpm-1.0": for chassis 1.0 rcpm
+       * "fsl,qoriq-rcpm-2.0": for chassis 2.0 rcpm
+       * "fsl,qoriq-rcpm-2.1": for chassis 2.1 rcpm
+
+All references to "1.0" and "2.0" refer to the QorIQ chassis version to
+which the chip complies.
Quoted 8 lines
Quoted 5 lines
+Chassis Version                Example Chips
+---------------                -------------------------------
+1.0                            p4080, p5020, p5040, p2041, p3041
+2.0                            t4240, b4860, b4420
+2.1                            t1040, ls1021

Not sure this binding is the place to maintain a table of chassis versions to SoCs.

This is something I've been encouraging, given that the block versions are not publicly documented. It lets people find a manual that describes the advertised programming interface.

-Scott

#11 lore raw

PATCH v3 1/2 fsl: Add binding for RCPM

In reply to Stuart Yoder
Quoted 16 lines

Documentation/devicetree/bindings/soc/fsl/rcpm.txt line 7

Quoted 9 lines

+++ b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt

Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +7 -0
@@ -0,0 +1,63 @@
+* Run Control and Power Management
+-------------------------------------------
+The RCPM performs all device-level tasks associated with device run
+control and power management.
+
+Required properites:
+  - reg : Offset and length of the register set of RCPM block.

s/RCPM block/the RCPM block/

Documentation/devicetree/bindings/soc/fsl/rcpm.txt line 8

Quoted 1 line
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +1 -0
+  - fsl,#rcpm-wakeup-cells : The number of cells in rcpm-wakeup property.

s/rcpm-wakeup-property/the rcpm-wakeup-property/

Quoted 8 lines

Review line 10

Quoted 2 lines
(quoted diff) +2 -0
+  - compatible : Sould contain a chip-specific RCPM block compatible
+ string

s/Sould/Should

"Should" means it is recommended, but does not mean "must". Is it really optional?

Thanks for your patient explain, change to "must".

Regards,
-Dongsheng

Quoted 33 lines

Documentation/devicetree/bindings/soc/fsl/rcpm.txt line 20

Quoted 11 lines
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +11 -0
+       and (if applicable) may contain a chassis-version RCPM compatible
+       string. Chip-specific strings are of the form "fsl,<chip>-rcpm",
+       such as:
+       * "fsl,p2041-rcpm"
+       * "fsl,p3041-rcpm"
+       * "fsl,p4080-rcpm"
+       * "fsl,p5020-rcpm"
+       * "fsl,p5040-rcpm"
+       * "fsl,t4240-rcpm"
+       * "fsl,b4420-rcpm"
+       * "fsl,b4860-rcpm"

2 or 3 examples is enough.

Documentation/devicetree/bindings/soc/fsl/rcpm.txt line 34

Quoted 13 lines
Documentation/devicetree/bindings/soc/fsl/rcpm.txt new file +13 -0
+       Chassis-version strings are of the form "fsl,qoriq-rcpm-<version>",
+       such as:
+       * "fsl,qoriq-rcpm-1.0": for chassis 1.0 rcpm
+       * "fsl,qoriq-rcpm-2.0": for chassis 2.0 rcpm
+       * "fsl,qoriq-rcpm-2.1": for chassis 2.1 rcpm
+
+All references to "1.0" and "2.0" refer to the QorIQ chassis version
+to which the chip complies.
+Chassis Version                Example Chips
+---------------                -------------------------------
+1.0                            p4080, p5020, p5040, p2041, p3041
+2.0                            t4240, b4860, b4420
+2.1                            t1040, ls1021

Not sure this binding is the place to maintain a table of chassis versions to SoCs.

Thanks,
Stuart