Skip to contentSkip to conversation

Patch "bridge: mdb: fix double add notification" has been added to the 3.10-stable tree

PATCH [email protected] 1 participant 1 message Sep 26, 2015

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

bridge: mdb: fix double add notification

to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
bridge-mdb-fix-double-add-notification.patch
and it can be found in the queue-3.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Sat Sep 26 11:20:32 PDT 2015

From: Nikolay Aleksandrov <[email protected]>
Date: Mon, 13 Jul 2015 06:36:19 -0700
Subject: bridge: mdb: fix double add notification

From: Nikolay Aleksandrov <[email protected]>

[ Upstream commit 5ebc784625ea68a9570d1f70557e7932988cd1b4 ]

Since the mdb add/del code was introduced there have been 2 br_mdb_notify calls when doing br_mdb_add() resulting in 2 notifications on each add.

Example:
Command: bridge mdb add dev br0 port eth1 grp 239.0.0.1 permanent Before patch:

 root@debian:~# bridge monitor all
 [MDB]dev br0 port eth1 grp 239.0.0.1 permanent
 [MDB]dev br0 port eth1 grp 239.0.0.1 permanent

After patch:

 root@debian:~# bridge monitor all
 [MDB]dev br0 port eth1 grp 239.0.0.1 permanent
Fixes cfd567543590 ("bridge: add support of adding and deleting mdb entries")
---
 net/bridge/br_mdb.c |    1 -
 1 file changed, 1 deletion(-)
net/bridge/br_mdb.c +0 -1
@@ -345,7 +345,6 @@ static int br_mdb_add_group(struct net_b
 		return -ENOMEM;
 	rcu_assign_pointer(*pp, p);
 
-	br_mdb_notify(br->dev, port, group, RTM_NEWMDB);
 	return 0;
 }
 

Patches currently in stable-queue which might be from [email protected] are

queue-3.10/bonding-correct-the-mac-address-for-follow-fail_over_mac-policy.patch queue-3.10/bridge-mdb-fix-double-add-notification.patch queue-3.10/bonding-fix-destruction-of-bond-with-devices-different-from-arphrd_ether.patch