Skip to contentSkip to conversation

HID: multitouch: Add suffix for HID_DG_TOUCHPAD

PATCH Applied Mika Westerberg 4 participants 4 messages Sep 28, 2015 – Sep 29, 2015 HID

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HID: multitouch: Add suffix for HID_DG_TOUCHPAD

Instead of printing "UNKNOWN" as device suffix for HID_DG_TOUCHPAD call the device as "Touchpad".

---
 drivers/hid/hid-multitouch.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/hid/hid-multitouch.c +3 -0
index 426b2f1a3450..661b4fce1a5d 100644
@@ -968,6 +968,9 @@ static void mt_input_configured(struct hid_device *hdev, struct hid_input *hi)
 		case HID_DG_TOUCHSCREEN:
 			/* we do not set suffix = "Touchscreen" */
 			break;
+		case HID_DG_TOUCHPAD:
+			suffix = "Touchpad";
+			break;
 		case HID_GD_SYSTEM_CONTROL:
 			suffix = "System Control";
 			break;
Signature · 1 line
2.5.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 13 lines · Mika Westerberg

Instead of printing "UNKNOWN" as device suffix for HID_DG_TOUCHPAD call the device as "Touchpad".

---
 drivers/hid/hid-multitouch.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/hid/hid-multitouch.c +0 -0
index 426b2f1a3450..661b4fce1a5d 100644

drivers/hid/hid-multitouch.c static void mt_input_configured(struct hid_device *hdev, struct hid_input *hi)

Quoted 10 lines
drivers/hid/hid-multitouch.c +3 -1
@@ -968,6 +968,9 @@ static void mt_input_configured(struct hid_device *hdev, struct hid_input *hi)
                case HID_DG_TOUCHSCREEN:
                        /* we do not set suffix = "Touchscreen" */
                        break;
+               case HID_DG_TOUCHPAD:
+                       suffix = "Touchpad";
+                       break;
                case HID_GD_SYSTEM_CONTROL:
                        suffix = "System Control";
                        break;
--

I will drop my locally pending patch for this. ;)

Acked-by on v1 1/1
#2 lore raw
In reply to Mika Westerberg
Quoted 5 lines · Mika Westerberg

Instead of printing "UNKNOWN" as device suffix for HID_DG_TOUCHPAD call the device as "Touchpad".

---

Cheers,
Benjamin

Quoted 20 lines
 drivers/hid/hid-multitouch.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/hid/hid-multitouch.c +3 -0
index 426b2f1a3450..661b4fce1a5d 100644
@@ -968,6 +968,9 @@ static void mt_input_configured(struct hid_device *hdev, struct hid_input *hi)
 		case HID_DG_TOUCHSCREEN:
 			/* we do not set suffix = "Touchscreen" */
 			break;
+		case HID_DG_TOUCHPAD:
+			suffix = "Touchpad";
+			break;
 		case HID_GD_SYSTEM_CONTROL:
 			suffix = "System Control";
 			break;
Signature · 1 line
2.5.1