Skip to contentSkip to conversation

nouveau: arm: Add MODULE_FIRMWARE for gk20a

PATCH New Nicolas Chauvet 3 participants 4 messages Sep 28, 2015 – Nov 12, 2015 1 message not in the archive

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 nouveau: arm: Add MODULE_FIRMWARE for gk20a

This patch is needed by initramfs tools to detect
the required firmware files for the module.

This patch tests for either TEGRA_124_SOC or TEGRA_132_SOC for the firmwares related to the Tegra K1 generation.

v2: move the MODULE_FIRMWARE to the nvidia_platform.c file.
This will avoid to test for NOUVEAU_PLATFORM_DRIVER

---
 drivers/gpu/drm/nouveau/nouveau_platform.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
drivers/gpu/drm/nouveau/nouveau_platform.c +11 -0
index 3eb6654..9013141 100644
@@ -65,3 +65,14 @@ struct platform_driver nouveau_platform_driver = {
 	.probe = nouveau_platform_probe,
 	.remove = nouveau_platform_remove,
 };
+
+#if IS_ENABLED(CONFIG_ARCH_TEGRA_124_SOC) || IS_ENABLED(CONFIG_ARCH_TEGRA_132_SOC)
+MODULE_FIRMWARE("nvidia/gk20a/fecs_data.bin");
+MODULE_FIRMWARE("nvidia/gk20a/fecs_inst.bin");
+MODULE_FIRMWARE("nvidia/gk20a/gpccs_data.bin");
+MODULE_FIRMWARE("nvidia/gk20a/gpccs_inst.bin");
+MODULE_FIRMWARE("nvidia/gk20a/sw_bundle_init.bin");
+MODULE_FIRMWARE("nvidia/gk20a/sw_ctx.bin");
+MODULE_FIRMWARE("nvidia/gk20a/sw_method_init.bin");
+MODULE_FIRMWARE("nvidia/gk20a/sw_nonctx.bin");
+#endif
Signature · 1 line
2.4.3
#1 lore raw

PATCH v2 1/1 nouveau: arm: Add MODULE_FIRMWARE for gk20a

Quoted 8 lines · Nicolas Chauvet

This patch is needed by initramfs tools to detect
the required firmware files for the module.

This patch tests for either TEGRA_124_SOC or TEGRA_132_SOC for the firmwares related to the Tegra K1 generation.

v2: move the MODULE_FIRMWARE to the nvidia_platform.c file.
This will avoid to test for NOUVEAU_PLATFORM_DRIVER

Nice, thanks for doing this change!

A message that is not in the archive (sent off-list or not yet received): CAAVeFuJLJO4LvLqq2w9gMe6V6L3VDi+Gz59GvwKF2v8OWTWgBQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#3 lore raw

2015-09-30 6:57 GMT+02:00 Alexandre Courbot <[email protected]>:

Quoted 8 lines
Quoted 6 lines · Nicolas Chauvet

This patch is needed by initramfs tools to detect
the required firmware files for the module.

This patch tests for either TEGRA_124_SOC or TEGRA_132_SOC for the firmwares related to the Tegra K1 generation.

Quoted 7 lines
Quoted 2 lines

v2: move the MODULE_FIRMWARE to the nvidia_platform.c file.
This will avoid to test for NOUVEAU_PLATFORM_DRIVER

Nice, thanks for doing this change!

Thx for the review.
FYI I've tested the patch on top of 4.3+ kernels, and the initramfs generated with dracut works as expected.

Is there any other concern with this patch ?

It's certainly late for 4.4,I would expect it to hit kernel 4.3 at some point, but I don't think everything is wired from userspace(Xorg/Wayland) wrt dGPU support.
So It could also wait for 4.5.
What do you think ?

Thx

Signature · 3 lines
-

Nicolas (kwizart)

_______________________________________________
Nouveau mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/nouveau

#4 lore raw

PATCH v2 1/1 nouveau: arm: Add MODULE_FIRMWARE for gk20a

Quoted 22 lines · Nicolas Chauvet

2015-09-30 6:57 GMT+02:00 Alexandre Courbot <[email protected]>:

Quoted 9 lines
Quoted 6 lines · Nicolas Chauvet

This patch is needed by initramfs tools to detect
the required firmware files for the module.

This patch tests for either TEGRA_124_SOC or TEGRA_132_SOC for the firmwares related to the Tegra K1 generation.

Quoted 6 lines
Quoted 2 lines

v2: move the MODULE_FIRMWARE to the nvidia_platform.c file.
This will avoid to test for NOUVEAU_PLATFORM_DRIVER

Nice, thanks for doing this change!

Thx for the review.
FYI I've tested the patch on top of 4.3+ kernels, and the initramfs generated with dracut works as expected.

Quoted 7 lines

Is there any other concern with this patch ?

It's certainly late for 4.4,I would expect it to hit kernel 4.3 at some point, but I don't think everything is wired from userspace(Xorg/Wayland) wrt dGPU support.
So It could also wait for 4.5.
What do you think ?

I don't see a particular reason to hurry, however this patch has been sitting around for one month now - Ben, is there any particular reason for not merging it?