ARM: imx6: set ahb-burst-config as 0 for USB
Subsystems (2)
PATCH RESEND v2 1/2 ARM: imx6: set ahb-burst-config as 0 for USB
After setting ahb burst configuration as 0, we can increase tx/rx burst size, it will improve the USB performance
---
Changes for v2:
- Applies changes for imx6ul
arch/arm/boot/dts/imx6qdl.dtsi | 4 ++++ arch/arm/boot/dts/imx6sl.dtsi | 3 +++ arch/arm/boot/dts/imx6sx.dtsi | 3 +++ arch/arm/boot/dts/imx6ul.dtsi | 2 ++ 4 files changed, 12 insertions(+)
arch/arm/boot/dts/imx6qdl.dtsi +4 -0
@@ -906,6 +906,7 @@ clocks = <&clks IMX6QDL_CLK_USBOH3>; fsl,usbphy = <&usbphy1>; fsl,usbmisc = <&usbmisc 0>; + ahb-burst-config = <0x0>; status = "disabled"; };
@@ -917,6 +918,7 @@ fsl,usbphy = <&usbphy2>; fsl,usbmisc = <&usbmisc 1>; dr_mode = "host"; + ahb-burst-config = <0x0>; status = "disabled"; };
@@ -927,6 +929,7 @@ clocks = <&clks IMX6QDL_CLK_USBOH3>; fsl,usbmisc = <&usbmisc 2>; dr_mode = "host"; + ahb-burst-config = <0x0>; status = "disabled"; };
@@ -937,6 +940,7 @@ clocks = <&clks IMX6QDL_CLK_USBOH3>; fsl,usbmisc = <&usbmisc 3>; dr_mode = "host"; + ahb-burst-config = <0x0>; status = "disabled"; };
arch/arm/boot/dts/imx6sl.dtsi +3 -0
@@ -689,6 +689,7 @@ clocks = <&clks IMX6SL_CLK_USBOH3>; fsl,usbphy = <&usbphy1>; fsl,usbmisc = <&usbmisc 0>; + ahb-burst-config = <0x0>; status = "disabled"; };
@@ -699,6 +700,7 @@ clocks = <&clks IMX6SL_CLK_USBOH3>; fsl,usbphy = <&usbphy2>; fsl,usbmisc = <&usbmisc 1>; + ahb-burst-config = <0x0>; status = "disabled"; };
@@ -709,6 +711,7 @@ clocks = <&clks IMX6SL_CLK_USBOH3>; fsl,usbmisc = <&usbmisc 2>; dr_mode = "host"; + ahb-burst-config = <0x0>; status = "disabled"; };
arch/arm/boot/dts/imx6sx.dtsi +3 -0
@@ -783,6 +783,7 @@ fsl,usbphy = <&usbphy1>; fsl,usbmisc = <&usbmisc 0>; fsl,anatop = <&anatop>; + ahb-burst-config = <0x0>; status = "disabled"; };
@@ -793,6 +794,7 @@ clocks = <&clks IMX6SX_CLK_USBOH3>; fsl,usbphy = <&usbphy2>; fsl,usbmisc = <&usbmisc 1>; + ahb-burst-config = <0x0>; status = "disabled"; };
@@ -805,6 +807,7 @@ phy_type = "hsic"; fsl,anatop = <&anatop>; dr_mode = "host"; + ahb-burst-config = <0x0>; status = "disabled"; };
arch/arm/boot/dts/imx6ul.dtsi +2 -0
@@ -535,6 +535,7 @@ fsl,usbphy = <&usbphy1>; fsl,usbmisc = <&usbmisc 0>; fsl,anatop = <&anatop>; + ahb-burst-config = <0x0>; status = "disabled"; };
@@ -545,6 +546,7 @@ clocks = <&clks IMX6UL_CLK_USBOH3>; fsl,usbphy = <&usbphy2>; fsl,usbmisc = <&usbmisc 1>; + ahb-burst-config = <0x0>; status = "disabled"; };
Signature · 1 line
1.9.1
PATCH RESEND v2 2/2 ARM: imx6: change default burst size for USB
It can improve the USB performance when choosing larger burst size at some systems (bus size is larger), there is no side effect if this burst size is larger than bus size.
---
Changes for v2:
- Applies changes for imx6ul
arch/arm/boot/dts/imx6qdl.dtsi | 8 ++++++++ arch/arm/boot/dts/imx6sl.dtsi | 6 ++++++ arch/arm/boot/dts/imx6sx.dtsi | 6 ++++++ arch/arm/boot/dts/imx6ul.dtsi | 4 ++++ 4 files changed, 24 insertions(+)
arch/arm/boot/dts/imx6qdl.dtsi +8 -0
@@ -907,6 +907,8 @@ fsl,usbphy = <&usbphy1>; fsl,usbmisc = <&usbmisc 0>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };
@@ -919,6 +921,8 @@ fsl,usbmisc = <&usbmisc 1>; dr_mode = "host"; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };
@@ -930,6 +934,8 @@ fsl,usbmisc = <&usbmisc 2>; dr_mode = "host"; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };
@@ -941,6 +947,8 @@ fsl,usbmisc = <&usbmisc 3>; dr_mode = "host"; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };
arch/arm/boot/dts/imx6sl.dtsi +6 -0
@@ -690,6 +690,8 @@ fsl,usbphy = <&usbphy1>; fsl,usbmisc = <&usbmisc 0>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };
@@ -701,6 +703,8 @@ fsl,usbphy = <&usbphy2>; fsl,usbmisc = <&usbmisc 1>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };
@@ -712,6 +716,8 @@ fsl,usbmisc = <&usbmisc 2>; dr_mode = "host"; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };
arch/arm/boot/dts/imx6sx.dtsi +6 -0
@@ -784,6 +784,8 @@ fsl,usbmisc = <&usbmisc 0>; fsl,anatop = <&anatop>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };
@@ -795,6 +797,8 @@ fsl,usbphy = <&usbphy2>; fsl,usbmisc = <&usbmisc 1>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };
@@ -808,6 +812,8 @@ fsl,anatop = <&anatop>; dr_mode = "host"; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };
arch/arm/boot/dts/imx6ul.dtsi +4 -0
@@ -536,6 +536,8 @@ fsl,usbmisc = <&usbmisc 0>; fsl,anatop = <&anatop>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };
@@ -547,6 +549,8 @@ fsl,usbphy = <&usbphy2>; fsl,usbmisc = <&usbmisc 1>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };
Signature · 1 line
1.9.1
PATCH RESEND v2 2/2 ARM: imx6: change default burst size for USB
Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen:
Quoted 4 lines
It can improve the USB performance when choosing larger burst size at some systems (bus size is larger), there is no side effect if this burst size is larger than bus size.
Just for the record, as it seems too late to stop the train now:
I am _NOT_ happy that the extended binding has been accepted into the USB tree despite outstanding review comments from me not being addressed or even answered.
Quoted 136 lines
Signed-off-by Peter Chen <[email protected]>---
Changes for v2:
- Applies changes for imx6ularch/arm/boot/dts/imx6qdl.dtsi | 8 ++++++++ arch/arm/boot/dts/imx6sl.dtsi | 6 ++++++ arch/arm/boot/dts/imx6sx.dtsi | 6 ++++++ arch/arm/boot/dts/imx6ul.dtsi | 4 ++++ 4 files changed, 24 insertions(+)arch/arm/boot/dts/imx6qdl.dtsi +8
-0@@ -907,6 +907,8 @@ fsl,usbphy = <&usbphy1>; fsl,usbmisc = <&usbmisc 0>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };@@ -919,6 +921,8 @@ fsl,usbmisc = <&usbmisc 1>; dr_mode = "host"; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };@@ -930,6 +934,8 @@ fsl,usbmisc = <&usbmisc 2>; dr_mode = "host"; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };@@ -941,6 +947,8 @@ fsl,usbmisc = <&usbmisc 3>; dr_mode = "host"; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };arch/arm/boot/dts/imx6sl.dtsi +6
-0@@ -690,6 +690,8 @@ fsl,usbphy = <&usbphy1>; fsl,usbmisc = <&usbmisc 0>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };@@ -701,6 +703,8 @@ fsl,usbphy = <&usbphy2>; fsl,usbmisc = <&usbmisc 1>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };@@ -712,6 +716,8 @@ fsl,usbmisc = <&usbmisc 2>; dr_mode = "host"; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };arch/arm/boot/dts/imx6sx.dtsi +6
-0@@ -784,6 +784,8 @@ fsl,usbmisc = <&usbmisc 0>; fsl,anatop = <&anatop>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };@@ -795,6 +797,8 @@ fsl,usbphy = <&usbphy2>; fsl,usbmisc = <&usbmisc 1>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };@@ -808,6 +812,8 @@ fsl,anatop = <&anatop>; dr_mode = "host"; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };arch/arm/boot/dts/imx6ul.dtsi +4
-0@@ -536,6 +536,8 @@ fsl,usbmisc = <&usbmisc 0>; fsl,anatop = <&anatop>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };@@ -547,6 +549,8 @@ fsl,usbphy = <&usbphy2>; fsl,usbmisc = <&usbmisc 1>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };
Signature · 2 lines
Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH RESEND v2 2/2 ARM: imx6: change default burst size for USB
Quoted 10 lines · Lucas Stach
Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen:
Quoted 4 lines
It can improve the USB performance when choosing larger burst size at some systems (bus size is larger), there is no side effect if this burst size is larger than bus size.
Just for the record, as it seems too late to stop the train now:
I am _NOT_ happy that the extended binding has been accepted into the USB tree despite outstanding review comments from me not being addressed or even answered.
Okay. I'm not aware of this. I'm dropping the patches until everyone agrees with it.
Shawn
PATCH RESEND v2 2/2 ARM: imx6: change default burst size for USB
Quoted 6 lines · Shawn Guo
Quoted 5 lines · Lucas Stach
Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen:
Quoted 4 lines
It can improve the USB performance when choosing larger burst size at some systems (bus size is larger), there is no side effect if this burst size is larger than bus size.
Quoted 9 lines
Quoted 5 lines
Just for the record, as it seems too late to stop the train now:
I am _NOT_ happy that the extended binding has been accepted into the USB tree despite outstanding review comments from me not being addressed or even answered.
Okay. I'm not aware of this. I'm dropping the patches until everyone agrees with it.
Hi Shawn & Lucas, I sent the improvement patch for dt description following Lucas's comment one week ago at below:
https://www.spinics.net/lists/linux-usb/msg131150.html
If no more comments, queue my dts patches please.
Signature · 2 lines
Best Regards, Peter Chen
PATCH RESEND v2 2/2 ARM: imx6: change default burst size for USB
Hi Shawn,
Am Dienstag, den 20.10.2015, 15:07 +0800 schrieb Peter Chen:
Quoted 17 lines · Shawn Guo
Quoted 6 lines · Lucas Stach
Quoted 5 lines
Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen:
Quoted 4 lines
It can improve the USB performance when choosing larger burst size at some systems (bus size is larger), there is no side effect if this burst size is larger than bus size.
Quoted 9 lines
Quoted 5 lines
Just for the record, as it seems too late to stop the train now:
I am _NOT_ happy that the extended binding has been accepted into the USB tree despite outstanding review comments from me not being addressed or even answered.
Okay. I'm not aware of this. I'm dropping the patches until everyone agrees with it.
Quoted 7 lines
Hi Shawn & Lucas, I sent the improvement patch for dt description following Lucas's comment one week ago at below:
https://www.spinics.net/lists/linux-usb/msg131150.html
If no more comments, queue my dts patches please.
While the binding hasn't received a good review in time it is already in a released kernel and I'm not going to argue to change it now after the fact (violating the DT stability rules) just to satisfy my rather minor comments. I want to make clear that I was not happy by how this stuff has been handled with the USB tree and it is my hope that this can be improved for future binding changes.
But please don't hold those DTS patches any longer. The binding is in, there is no point in not applying the corresponding patches.
Regards,
Lucas
Signature · 2 lines
Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH RESEND v2 2/2 ARM: imx6: change default burst size for USB
Quoted 34 lines · Lucas Stach
Hi Shawn,
Am Dienstag, den 20.10.2015, 15:07 +0800 schrieb Peter Chen:
Quoted 17 lines · Shawn Guo
Quoted 6 lines · Lucas Stach
Quoted 5 lines
Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen:
Quoted 4 lines
It can improve the USB performance when choosing larger burst size at some systems (bus size is larger), there is no side effect if this burst size is larger than bus size.
Quoted 9 lines
Quoted 5 lines
Just for the record, as it seems too late to stop the train now:
I am _NOT_ happy that the extended binding has been accepted into the USB tree despite outstanding review comments from me not being addressed or even answered.
Okay. I'm not aware of this. I'm dropping the patches until everyone agrees with it.
Quoted 7 lines
Hi Shawn & Lucas, I sent the improvement patch for dt description following Lucas's comment one week ago at below:
https://www.spinics.net/lists/linux-usb/msg131150.html
If no more comments, queue my dts patches please.
While the binding hasn't received a good review in time it is already in a released kernel and I'm not going to argue to change it now after the fact (violating the DT stability rules) just to satisfy my rather minor comments. I want to make clear that I was not happy by how this stuff has been handled with the USB tree and it is my hope that this can be improved for future binding changes.
Quoted 6 lines
But please don't hold those DTS patches any longer. The binding is in, there is no point in not applying the corresponding patches.
Regards,
Lucas
Ping...
Shawn, I still not see these dt changes in your tree
Signature · 2 lines
Best Regards, Peter Chen
PATCH RESEND v2 2/2 ARM: imx6: change default burst size for USB
In reply to Lucas StachQuoted 11 lines · Lucas Stach
Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen:
Quoted 4 lines
It can improve the USB performance when choosing larger burst size at some systems (bus size is larger), there is no side effect if this burst size is larger than bus size.
Just for the record, as it seems too late to stop the train now:
I am _NOT_ happy that the extended binding has been accepted into the USB tree despite outstanding review comments from me not being addressed or even answered.
I sent patch for review at Aug 7th, queued this patches at Aug 13th [1], and sent pull
request at Aug 14th, I am curious why you did not give comments between this period utill
I complained one ethernet patch breaks i.mx ethernet function for v4.2 tree [2] at Aug 14th.
I will consider your comments, and send patch for improving it if possible.
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-August/364352.html
[2] http://marc.info/?l=linux-netdev&m=143954500409636&w=2
Quoted 146 lines
Quoted 128 lines
Signed-off-by Peter Chen <[email protected]>---
Changes for v2:
- Applies changes for imx6ularch/arm/boot/dts/imx6qdl.dtsi | 8 ++++++++ arch/arm/boot/dts/imx6sl.dtsi | 6 ++++++ arch/arm/boot/dts/imx6sx.dtsi | 6 ++++++ arch/arm/boot/dts/imx6ul.dtsi | 4 ++++ 4 files changed, 24 insertions(+)arch/arm/boot/dts/imx6qdl.dtsi +8
-0@@ -907,6 +907,8 @@ fsl,usbphy = <&usbphy1>; fsl,usbmisc = <&usbmisc 0>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };@@ -919,6 +921,8 @@ fsl,usbmisc = <&usbmisc 1>; dr_mode = "host"; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };@@ -930,6 +934,8 @@ fsl,usbmisc = <&usbmisc 2>; dr_mode = "host"; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };@@ -941,6 +947,8 @@ fsl,usbmisc = <&usbmisc 3>; dr_mode = "host"; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };arch/arm/boot/dts/imx6sl.dtsi +6
-0@@ -690,6 +690,8 @@ fsl,usbphy = <&usbphy1>; fsl,usbmisc = <&usbmisc 0>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };@@ -701,6 +703,8 @@ fsl,usbphy = <&usbphy2>; fsl,usbmisc = <&usbmisc 1>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };@@ -712,6 +716,8 @@ fsl,usbmisc = <&usbmisc 2>; dr_mode = "host"; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };arch/arm/boot/dts/imx6sx.dtsi +6
-0@@ -784,6 +784,8 @@ fsl,usbmisc = <&usbmisc 0>; fsl,anatop = <&anatop>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };@@ -795,6 +797,8 @@ fsl,usbphy = <&usbphy2>; fsl,usbmisc = <&usbmisc 1>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };@@ -808,6 +812,8 @@ fsl,anatop = <&anatop>; dr_mode = "host"; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };arch/arm/boot/dts/imx6ul.dtsi +2
-0@@ -536,6 +536,8 @@ fsl,usbmisc = <&usbmisc 0>; fsl,anatop = <&anatop>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };arch/arm/boot/dts/imx6ul.dtsi line 556
Quoted 8 lines
arch/arm/boot/dts/imx6ul.dtsi +2
-0@@ -547,6 +549,8 @@ fsl,usbphy = <&usbphy2>; fsl,usbmisc = <&usbmisc 1>; ahb-burst-config = <0x0>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; status = "disabled"; };--
Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ |_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 2 lines
BR, Peter Chen
PATCH RESEND v2 2/2 ARM: imx6: change default burst size for USB
Am Donnerstag, den 01.10.2015, 16:13 +0800 schrieb Peter Chen:
Quoted 13 lines · Lucas Stach
Quoted 11 lines
Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen:
Quoted 4 lines
It can improve the USB performance when choosing larger burst size at some systems (bus size is larger), there is no side effect if this burst size is larger than bus size.
Just for the record, as it seems too late to stop the train now:
I am _NOT_ happy that the extended binding has been accepted into the USB tree despite outstanding review comments from me not being addressed or even answered.
Quoted 7 lines
I sent patch for review at Aug 7th, queued this patches at Aug 13th [1], and sent pull
request at Aug 14th, I am curious why you did not give comments between this period utill
I complained one ethernet patch breaks i.mx ethernet function for v4.2 tree [2] at Aug 14th.
What do the USB changes have to do with any ethernet changes?
The comments I'm referring to are from Aug 14th
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-August/364396.html
So you are telling me that giving reviewers not even a week before sending the pull request is appropriate? And that sending the pull despite there being open review comments is ok? Think again.
Quoted 2 lines
I will consider your comments, and send patch for improving it if possible.
As I said it may be too late now. By sending the pull request including the binding change you forced everyone to now either accept the (in my opinion not really perfect) binding, or hurry to change it in the current RC phase, something which I'm not comfortable with. The damage has been done.
Quoted 3 lines
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-August/364352.html
[2] http://marc.info/?l=linux-netdev&m=143954500409636&w=2
Signature · 2 lines
Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH RESEND v2 2/2 ARM: imx6: change default burst size for USB
Quoted 21 lines · Lucas Stach
Am Donnerstag, den 01.10.2015, 16:13 +0800 schrieb Peter Chen:
Quoted 13 lines · Lucas Stach
Quoted 11 lines
Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen:
Quoted 4 lines
It can improve the USB performance when choosing larger burst size at some systems (bus size is larger), there is no side effect if this burst size is larger than bus size.
Just for the record, as it seems too late to stop the train now:
I am _NOT_ happy that the extended binding has been accepted into the USB tree despite outstanding review comments from me not being addressed or even answered.
Quoted 7 lines
I sent patch for review at Aug 7th, queued this patches at Aug 13th [1], and sent pull
request at Aug 14th, I am curious why you did not give comments between this period utill
I complained one ethernet patch breaks i.mx ethernet function for v4.2 tree [2] at Aug 14th.
Quoted 9 lines
What do the USB changes have to do with any ethernet changes?
The comments I'm referring to are from Aug 14th
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-August/364396.htmlSo you are telling me that giving reviewers not even a week before sending the pull request is appropriate? And that sending the pull despite there being open review comments is ok? Think again.
Comments are welcome at anytime, but why you are __NOT__ happy it was accepted and your comments were delayed. If you think this binding description is not ok, patch is welcome.
Quoted 8 lines
Quoted 2 lines
I will consider your comments, and send patch for improving it if possible.
As I said it may be too late now. By sending the pull request including the binding change you forced everyone to now either accept the (in my opinion not really perfect) binding, or hurry to change it in the current RC phase, something which I'm not comfortable with. The damage has been done.
Again, I waited one week, and your comments were late. I do not want to dispute more at our holidays. Let's stop here.
Signature · 2 lines
BR, Peter Chen
Shawn Guo
AppliedPATCH RESEND v2 1/2 ARM: imx6: set ahb-burst-config as 0 for USB
In reply to Peter ChenQuoted 4 lines · Peter Chen
After setting ahb burst configuration as 0, we can increase tx/rx burst size, it will improve the USB performance
Signed-off-by Peter Chen <[email protected]>
Applied both, thanks.
PATCH RESEND v2 1/2 ARM: imx6: set ahb-burst-config as 0 for USB
In reply to Peter ChenQuoted 4 lines · Peter Chen
After setting ahb burst configuration as 0, we can increase tx/rx burst size, it will improve the USB performance
Signed-off-by Peter Chen <[email protected]>
Should I queue these patches for v4.4-rc as fixes or v4.5-rc1 as improvement?
Shawn
PATCH RESEND v2 1/2 ARM: imx6: set ahb-burst-config as 0 for USB
Quoted 9 lines · Shawn Guo
Quoted 4 lines · Peter Chen
After setting ahb burst configuration as 0, we can increase tx/rx burst size, it will improve the USB performance
Signed-off-by Peter Chen <[email protected]>Should I queue these patches for v4.4-rc as fixes or v4.5-rc1 as improvement?
Queue them for v4.5-rc1 please.
Signature · 2 lines
Best Regards, Peter Chen
Shawn Guo
AppliedPATCH RESEND v2 1/2 ARM: imx6: set ahb-burst-config as 0 for USB
Quoted 5 lines · Peter Chen
Quoted 4 lines · Shawn Guo
Quoted 3 lines · Peter Chen
After setting ahb burst configuration as 0, we can increase tx/rx burst size, it will improve the USB performance
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Peter Chen <[email protected]>Should I queue these patches for v4.4-rc as fixes or v4.5-rc1 as improvement?
Queue them for v4.5-rc1 please.
Applied, thanks.