Patch "bridge: fix igmpv3 / mldv2 report parsing" has been added to the 4.2-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
bridge: fix igmpv3 / mldv2 report parsing
to the 4.2-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
bridge-fix-igmpv3-mldv2-report-parsing.patch
and it can be found in the queue-4.2 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Wed Sep 30 05:25:07 CEST 2015
From: =?UTF-8?q?Linus=20L=C3=BCssing?= <[email protected]>
Date: Fri, 11 Sep 2015 18:39:48 +0200
Subject: bridge: fix igmpv3 / mldv2 report parsing
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: =?UTF-8?q?Linus=20L=C3=BCssing?= <[email protected]>
[ Upstream commit c2d4fbd2163e607915cc05798ce7fb7f31117cc1 ]
With the newly introduced helper functions the skb pulling is hidden in the checksumming function - and undone before returning to the caller.
The IGMPv3 and MLDv2 report parsing functions in the bridge still assumed that the skb is pointing to the beginning of the IGMP/MLD message while it is now kept at the beginning of the IPv4/6 header, breaking the message parsing and creating packet loss.
Fixing this by taking the offset between IP and IGMP/MLD header into account, too.
--- net/bridge/br_multicast.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
net/bridge/br_multicast.c +2 -2
@@ -991,7 +991,7 @@ static int br_ip4_multicast_igmp3_report ih =igmpv3_report_hdr (skb); num =ntohs (ih->ngrec); - len =sizeof (*ih); + len =skb_transport_offset (skb) +sizeof (*ih);for (i =0 ; i < num; i++) { len +=sizeof (*grec);
@@ -1052,7 +1052,7 @@ static int br_ip6_multicast_mld2_report( icmp6h =icmp6_hdr (skb); num =ntohs (icmp6h->icmp6_dataun.un_data16[1 ]); - len =sizeof (*icmp6h); + len =skb_transport_offset (skb) +sizeof (*icmp6h);for (i =0 ; i < num; i++) {__be16 *nsrcs, _nsrcs;
Patches currently in stable-queue which might be from [email protected] are
queue-4.2/bridge-fix-igmpv3-mldv2-report-parsing.patch