Skip to contentSkip to conversation

watchdog: imx2_wdt: Use register definition in regmap_write()

PATCH In review Fabio Estevam 2 participants 2 messages Oct 2, 2015

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 watchdog: imx2_wdt: Use register definition in regmap_write()

From: Fabio Estevam <[email protected]>

In order to improve readability it is better to pass the register name definition rather than to pass its hardcoded offset.

---
 drivers/watchdog/imx2_wdt.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/watchdog/imx2_wdt.c +3 -3
index 0bb1a1d..29ef719 100644
@@ -91,7 +91,7 @@ static int imx2_restart_handler(struct notifier_block *this, unsigned long mode,
 						    struct imx2_wdt_device,
 						    restart_handler);
 	/* Assert SRS signal */
-	regmap_write(wdev->regmap, 0, wcr_enable);
+	regmap_write(wdev->regmap, IMX2_WDT_WCR, wcr_enable);
 	/*
 	 * Due to imx6q errata ERR004346 (WDOG: WDOG SRS bit requires to be
 	 * written twice), we add another two writes to ensure there must be at
@@ -99,8 +99,8 @@ static int imx2_restart_handler(struct notifier_block *this, unsigned long mode,
 	 * the target check here, since the writes shouldn't be a huge burden
 	 * for other platforms.
 	 */
-	regmap_write(wdev->regmap, 0, wcr_enable);
-	regmap_write(wdev->regmap, 0, wcr_enable);
+	regmap_write(wdev->regmap, IMX2_WDT_WCR, wcr_enable);
+	regmap_write(wdev->regmap, IMX2_WDT_WCR, wcr_enable);
 
 	/* wait for reset to assert... */
 	mdelay(500);
Signature · 1 line
1.9.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

In order to improve readability it is better to pass the register name definition rather than to pass its hardcoded offset.

Quoted 29 lines
---
  drivers/watchdog/imx2_wdt.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
drivers/watchdog/imx2_wdt.c +3 -3
index 0bb1a1d..29ef719 100644
@@ -91,7 +91,7 @@ static int imx2_restart_handler(struct notifier_block *this, unsigned long mode,
  						    struct imx2_wdt_device,
  						    restart_handler);
  	/* Assert SRS signal */
-	regmap_write(wdev->regmap, 0, wcr_enable);
+	regmap_write(wdev->regmap, IMX2_WDT_WCR, wcr_enable);
  	/*
  	 * Due to imx6q errata ERR004346 (WDOG: WDOG SRS bit requires to be
  	 * written twice), we add another two writes to ensure there must be at
@@ -99,8 +99,8 @@ static int imx2_restart_handler(struct notifier_block *this, unsigned long mode,
  	 * the target check here, since the writes shouldn't be a huge burden
  	 * for other platforms.
  	 */
-	regmap_write(wdev->regmap, 0, wcr_enable);
-	regmap_write(wdev->regmap, 0, wcr_enable);
+	regmap_write(wdev->regmap, IMX2_WDT_WCR, wcr_enable);
+	regmap_write(wdev->regmap, IMX2_WDT_WCR, wcr_enable);
 
  	/* wait for reset to assert... */
  	mdelay(500);