watchdog: imx2_wdt: Use register definition in regmap_write()
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/1 watchdog: imx2_wdt: Use register definition in regmap_write()
From: Fabio Estevam <[email protected]>
In order to improve readability it is better to pass the register name definition rather than to pass its hardcoded offset.
Signed-off-by Fabio Estevam <[email protected]>
--- drivers/watchdog/imx2_wdt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/watchdog/imx2_wdt.c +3 -3
@@ -91,7 +91,7 @@ static int imx2_restart_handler(struct notifier_block *this, unsigned long mode, struct imx2_wdt_device, restart_handler);/* Assert SRS signal */ -regmap_write (wdev->regmap,0 , wcr_enable); +regmap_write (wdev->regmap,IMX2_WDT_WCR , wcr_enable);/* * Due to imx6q errata ERR004346 (WDOG: WDOG SRS bit requires to be * written twice), we add another two writes to ensure there must be at
@@ -99,8 +99,8 @@ static int imx2_restart_handler(struct notifier_block *this, unsigned long mode,* the target check here, since the writes shouldn't be a huge burden * for other platforms. */ -regmap_write (wdev->regmap,0 , wcr_enable); -regmap_write (wdev->regmap,0 , wcr_enable); +regmap_write (wdev->regmap,IMX2_WDT_WCR , wcr_enable); +regmap_write (wdev->regmap,IMX2_WDT_WCR , wcr_enable);/* wait for reset to assert... */ mdelay (500 );
Signature · 1 line
1.9.1
Quoted 6 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
In order to improve readability it is better to pass the register name definition rather than to pass its hardcoded offset.
Signed-off-by Fabio Estevam <[email protected]>
Reviewed-by Guenter Roeck <[email protected]>
Quoted 29 lines
--- drivers/watchdog/imx2_wdt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/watchdog/imx2_wdt.c +3
-3@@ -91,7 +91,7 @@ static int imx2_restart_handler(struct notifier_block *this, unsigned long mode, struct imx2_wdt_device, restart_handler);/* Assert SRS signal */ -regmap_write (wdev->regmap,0 , wcr_enable); +regmap_write (wdev->regmap,IMX2_WDT_WCR , wcr_enable);/* * Due to imx6q errata ERR004346 (WDOG: WDOG SRS bit requires to be * written twice), we add another two writes to ensure there must be at @@ -99,8 +99,8 @@ static int imx2_restart_handler(struct notifier_block *this, unsigned long mode,* the target check here, since the writes shouldn't be a huge burden * for other platforms. */ -regmap_write (wdev->regmap,0 , wcr_enable); -regmap_write (wdev->regmap,0 , wcr_enable); +regmap_write (wdev->regmap,IMX2_WDT_WCR , wcr_enable); +regmap_write (wdev->regmap,IMX2_WDT_WCR , wcr_enable);/* wait for reset to assert... */ mdelay (500 );