Skip to contentSkip to conversation

PCI: keystone: Fix definition of LTSSM_STATE_MASK

RFC NAK Fabio Estevam 2 participants 3 messages Oct 5, 2015 – Oct 15, 2015 PCI

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

RFC v2 1/1 PCI: keystone: Fix definition of LTSSM_STATE_MASK

From: Fabio Estevam <[email protected]>

Designware PCI block uses 0x3f for the LTSSM_STATE_MASK.

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Fix Subject

Murali,

I am doing some consolidation on the PCI DW drivers and I noticed that keystone uses a different LTSSM_STATE_MASK definition.

Could you please double check it?

 drivers/pci/host/pci-keystone-dw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/host/pci-keystone-dw.c +1 -1
index 3cf55cd..78320e4 100644
@@ -25,7 +25,7 @@
 
 /* Application register defines */
 #define LTSSM_EN_VAL		        1
-#define LTSSM_STATE_MASK		0x1f
+#define LTSSM_STATE_MASK		0x3f
 #define LTSSM_STATE_L0			0x11
 #define DBI_CS2_EN_VAL			0x20
 #define OB_XLAT_EN_VAL		        2
Signature · 1 line
1.9.1
NAK
#1 lore raw
Quoted 24 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Designware PCI block uses 0x3f for the LTSSM_STATE_MASK.

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Fix Subject

Murali,

I am doing some consolidation on the PCI DW drivers and I noticed that keystone uses a different LTSSM_STATE_MASK definition.

Could you please double check it?

  drivers/pci/host/pci-keystone-dw.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/host/pci-keystone-dw.c +0 -0
index 3cf55cd..78320e4 100644

drivers/pci/host/pci-keystone-dw.c line 28

Quoted 5 lines
drivers/pci/host/pci-keystone-dw.c +1 -1
@@ -25,7 +25,7 @@
 
  /* Application register defines */
  #define LTSSM_EN_VAL		        1
-#define LTSSM_STATE_MASK		0x1f
+#define LTSSM_STATE_MASK		0x3f

NACK

The mask should be 0x1f as was originally as per document

4-0 LTSSM_STATE
LTSSM current state. Please see Appendix
A.1 for the names of the LTSSM states corresponding to the encoded values.

refer the document at http://www.ti.com/lit/ug/sprugs6d/sprugs6d.pdf

Murali

Quoted 4 lines
drivers/pci/host/pci-keystone-dw.c +0 -0
  #define LTSSM_STATE_L0			0x11
  #define DBI_CS2_EN_VAL			0x20
  #define OB_XLAT_EN_VAL		        2
Signature · 2 lines
Murali Karicheri
Linux Kernel, Keystone
author
#2 lore raw
Quoted 11 lines · Murali Karicheri

NACK

The mask should be 0x1f as was originally as per document

4-0 LTSSM_STATE LTSSM current state. Please see
Appendix
A.1 for the names of the LTSSM states corresponding to the encoded values.

refer the document at http://www.ti.com/lit/ug/sprugs6d/sprugs6d.pdf

Yes, in the last version of the patch I use the 0x1f mask for all Designware PCI drivers.