Skip to contentSkip to conversation

zlib : Fix usage example of zlib_adler32()

PATCH RESEND In review Anish Bhatt 2 participants 3 messages Oct 5, 2015

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 zlib : Fix usage example of zlib_adler32()

alder32 was renamed to zlib_adler32 since before 2.6.11, update the example accordingly. This code does not seem to have an assigned maintainer.

---
 include/linux/zutil.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/zutil.h +2 -2
index 6adfa9a..6636895 100644
@@ -68,10 +68,10 @@ typedef uLong (*check_func) (uLong check, const Byte *buf,
    An Adler-32 checksum is almost as reliable as a CRC32 but can be computed
    much faster. Usage example:
 
-     uLong adler = adler32(0L, NULL, 0);
+     uLong adler = zlib_adler32(0L, NULL, 0);
 
      while (read_buffer(buffer, length) != EOF) {
-       adler = adler32(adler, buffer, length);
+       adler = zlib_adler32(adler, buffer, length);
      }
      if (adler != original_adler) error();
 */
Signature · 1 line
1.9.1
#1 lore raw
Quoted 11 lines · On Mon, 5 Oct 2015 13:23:58 -0700 Anish Bhatt <[email protected]> wrote:

alder32 was renamed to zlib_adler32 since before 2.6.11, update the example accordingly. This code does not seem to have an assigned maintainer.

...

include/linux/zutil.h +0 -0
@@ -68,10 +68,10 @@ typedef uLong (*check_func) (uLong check, const Byte *buf,
    An Adler-32 checksum is almost as reliable as a CRC32 but can be computed
    much faster. Usage example:

include/linux/zutil.h typedef uLong (*check_func) (uLong check, const Byte *buf, · line 77

Quoted 10 lines
include/linux/zutil.h +2 -2
 
-     uLong adler = adler32(0L, NULL, 0);
+     uLong adler = zlib_adler32(0L, NULL, 0);
 
      while (read_buffer(buffer, length) != EOF) {
-       adler = adler32(adler, buffer, length);
+       adler = zlib_adler32(adler, buffer, length);
      }
      if (adler != original_adler) error();
 */

I applied this September 15. You should have received the commit email on that date. I'm not a spammer, honest.

#2 lore raw
Quoted 17 lines · Andrew Morton
Quoted 15 lines · On Mon, 5 Oct 2015 13:23:58 -0700 Anish Bhatt <[email protected]> wrote:

alder32 was renamed to zlib_adler32 since before 2.6.11, update the example accordingly. This code does not seem to have an assigned maintainer.

...

include/linux/zutil.h +1 -1
@@ -68,10 +68,10 @@ typedef uLong (*check_func) (uLong check, const Byte *buf,
    An Adler-32 checksum is almost as reliable as a CRC32 but can be computed
    much faster. Usage example:
 
-     uLong adler = adler32(0L, NULL, 0);
+     uLong adler = zlib_adler32(0L, NULL, 0);
 
Quoted 9 lines

include/linux/zutil.h typedef uLong (*check_func) (uLong check, const Byte *buf, · line 77

Quoted 6 lines
include/linux/zutil.h +1 -1
      while (read_buffer(buffer, length) != EOF) {
-       adler = adler32(adler, buffer, length);
+       adler = zlib_adler32(adler, buffer, length);
      }
      if (adler != original_adler) error();
 */

I applied this September 15. You should have received the commit email on that date. I'm not a spammer, honest.

That is weird, I don't see a notification in the spam folder either, but I do see that the code has changed. Sorry about the noise.

-Anish