NFS: Fix a tracepoint NULL-pointer dereference
Subsystems (2)
PATCH 1/1 NFS: Fix a tracepoint NULL-pointer dereference
Running xfstest generic/013 with the tracepoint nfs:nfs4_open_file enabled produces a NULL-pointer dereference when calculating fileid and filehandle of the opened file. Fix this by checking if state is NULL before trying to use the inode pointer.
Reported-by Olga Kornievskaia <[email protected]>
Signed-off-by Anna Schumaker <[email protected]>
--- fs/nfs/nfs4trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfs/nfs4trace.h +1 -1
@@ -409,7 +409,7 @@ DECLARE_EVENT_CLASS(nfs4_open_event, __entry->flags = flags; __entry->fmode = (__force unsigned int )ctx->mode; __entry->dev = ctx->dentry->d_sb->s_dev; -if (!IS_ERR (state)) +if (!IS_ERR_OR_NULL (state)) inode = state->inode;if (inode !=NULL ) { __entry->fileid =NFS_FILEID (inode);
Signature · 1 line
2.6.0