Skip to contentSkip to conversation

wdt: intel-mid: add Magic Closure flag

PATCH In review David Cohen 2 participants 2 messages Oct 5, 2015 – Oct 6, 2015

Subsystems (2)
Watchdog device drivers Intel MID (Mobile Internet Device) platform
lore
Share & tools
lore

David Cohen

author
#0 lore raw

PATCH 1/1 wdt: intel-mid: add Magic Closure flag

Adding WDIOF_MAGICCLOSE to Intel MID watchdog driver. Once the watchdog is opened, it makes sense to disable watchdog only if it was gracefully released.

Signed-off-by David Cohen <[email protected]>
---
 drivers/watchdog/intel-mid_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/intel-mid_wdt.c +1 -1
index 0a436b5d1e84..db36d12e2b52 100644
@@ -101,7 +101,7 @@ static irqreturn_t mid_wdt_irq(int irq, void *dev_id)
 
 static const struct watchdog_info mid_wdt_info = {
 	.identity = "Intel MID SCU watchdog",
-	.options = WDIOF_KEEPALIVEPING | WDIOF_SETTIMEOUT,
+	.options = WDIOF_KEEPALIVEPING | WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE,
 };
 
 static const struct watchdog_ops mid_wdt_ops = {
Signature · 1 line
2.1.4
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · David Cohen

Adding WDIOF_MAGICCLOSE to Intel MID watchdog driver. Once the watchdog is opened, it makes sense to disable watchdog only if it was gracefully released.

Signed-off-by David Cohen <[email protected]>

Makes sense.

Reviewed-by Guenter Roeck <[email protected]>
Quoted 18 lines
---
  drivers/watchdog/intel-mid_wdt.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/intel-mid_wdt.c +1 -1
index 0a436b5d1e84..db36d12e2b52 100644
@@ -101,7 +101,7 @@ static irqreturn_t mid_wdt_irq(int irq, void *dev_id)
 
  static const struct watchdog_info mid_wdt_info = {
  	.identity = "Intel MID SCU watchdog",
-	.options = WDIOF_KEEPALIVEPING | WDIOF_SETTIMEOUT,
+	.options = WDIOF_KEEPALIVEPING | WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE,
  };
 
  static const struct watchdog_ops mid_wdt_ops = {