Skip to contentSkip to conversation

h8300: Fix build error due to missing word-at-a-time.h

PATCH In review Guenter Roeck 3 participants 6 messages Oct 6, 2015 – Oct 8, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 h8300: Fix build error due to missing word-at-a-time.h

h8300 builds fail with

lib/string.c:31:32: fatal error: asm/word-at-a-time.h: No such file or directory

Fixes 30035e45753b ("string: provide strscpy()")
Cc Chris Metcalf <[email protected]>
---
 arch/h8300/include/asm/Kbuild | 1 +
 1 file changed, 1 insertion(+)
arch/h8300/include/asm/Kbuild +1 -0
index 70e6ae1e7006..373cb23301e3 100644
@@ -73,4 +73,5 @@ generic-y += uaccess.h
 generic-y += ucontext.h
 generic-y += unaligned.h
 generic-y += vga.h
+generic-y += word-at-a-time.h
 generic-y += xor.h
Signature · 1 line
2.1.4
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Guenter Roeck

h8300 builds fail with

lib/string.c:31:32: fatal error: asm/word-at-a-time.h: No such file or directory

Fixes 30035e45753b ("string: provide strscpy()")
Cc Chris Metcalf <[email protected]>
---
  arch/h8300/include/asm/Kbuild | 1 +
  1 file changed, 1 insertion(+)
Signature · 2 lines
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com
#2 lore raw
Quoted 5 lines · Chris Metcalf
Quoted 4 lines · Guenter Roeck

h8300 builds fail with

lib/string.c:31:32: fatal error: asm/word-at-a-time.h: No such file or directory

Quoted 9 lines
Quoted 6 lines
Fixes 30035e45753b ("string: provide strscpy()")
Cc Chris Metcalf <[email protected]>
---
  arch/h8300/include/asm/Kbuild | 1 +
  1 file changed, 1 insertion(+)

lib/string.c: In function 'strscpy':
lib/string.c:209:4: error: implicit declaration of function 'zero_bytemask' [-Werror=implicit-function-declaration]

    *(unsigned long *)(dest+res) = c & zero_bytemask(data);

Now seen upstream for all powerpc builds. Seems to be due to 'strscpy: zero any trailing garbage bytes in the destination'.

Guenter

#3 lore raw
Quoted 6 lines · Guenter Roeck

lib/string.c: In function 'strscpy':
lib/string.c:209:4: error: implicit declaration of function 'zero_bytemask' [-Werror=implicit-function-declaration]

    *(unsigned long *)(dest+res) = c & zero_bytemask(data);

Now seen upstream for all powerpc builds. Seems to be due to 'strscpy: zero any trailing garbage bytes in the destination'.

See:

http://lkml.kernel.org/r/[email protected]

Signature · 2 lines
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com
#4 lore raw
In reply to Guenter Roeck
Quoted 25 lines · Guenter Roeck

h8300 builds fail with

lib/string.c:31:32: fatal error: asm/word-at-a-time.h: No such file or directory

Fixes 30035e45753b ("string: provide strscpy()")
Cc Chris Metcalf <[email protected]>
---
 arch/h8300/include/asm/Kbuild | 1 +
 1 file changed, 1 insertion(+)
arch/h8300/include/asm/Kbuild +1 -0
index 70e6ae1e7006..373cb23301e3 100644
@@ -73,4 +73,5 @@ generic-y += uaccess.h
 generic-y += ucontext.h
 generic-y += unaligned.h
 generic-y += vga.h
+generic-y += word-at-a-time.h
 generic-y += xor.h
Signature · 1 line
2.1.4

Merged in my tree.
Thanks.

Signature · 2 lines
Yoshinori Sato
<[email protected]>
#5 lore raw
Quoted 14 lines · Yoshinori Sato
Quoted 12 lines · Guenter Roeck

h8300 builds fail with

lib/string.c:31:32: fatal error: asm/word-at-a-time.h: No such file or directory

Fixes 30035e45753b ("string: provide strscpy()")
Cc Chris Metcalf <[email protected]>
---
  arch/h8300/include/asm/Kbuild | 1 +
  1 file changed, 1 insertion(+)
Quoted 17 lines
Quoted 11 lines
arch/h8300/include/asm/Kbuild +1 -1
index 70e6ae1e7006..373cb23301e3 100644
@@ -73,4 +73,5 @@ generic-y += uaccess.h
  generic-y += ucontext.h
  generic-y += unaligned.h
  generic-y += vga.h
+generic-y += word-at-a-time.h
  generic-y += xor.h
--
Quoted 2 lines

2.1.4

Merged in my tree.
Thanks.

Chris already applied and pushed a different patch.

Guenter