Skip to contentSkip to conversation

ASoC: ad193x-spi: Fixup ad193x_spi_id table

PATCH In review Axel Lin 3 participants 3 messages Oct 6, 2015 – Oct 7, 2015

Subsystems (3)
Sound ASoC Analog devices inc ASoC codec drivers
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 ASoC: ad193x-spi: Fixup ad193x_spi_id table

AD1939 is missed from the table, so add it.
AD1936 and AD1937 are controlled by I2C interface, so remove them.

Fixes e5224f58e3ef ("ASoC: ad193x: add support to ad1934")
Signed-off-by Axel Lin <[email protected]>
---
 sound/soc/codecs/ad193x-spi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
sound/soc/codecs/ad193x-spi.c +1 -2
index 364e8211..b55055a 100644
@@ -39,9 +39,8 @@ static const struct spi_device_id ad193x_spi_id[] = {
 	{ "ad193x", AD193X },
 	{ "ad1933", AD1933 },
 	{ "ad1934", AD1934 },
-	{ "ad1936", AD193X },
-	{ "ad1937", AD193X },
 	{ "ad1938", AD193X },
+	{ "ad1939", AD193X },
 	{ }
 };
 MODULE_DEVICE_TABLE(spi, ad193x_spi_id);
Signature · 1 line
2.1.4
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Axel Lin

AD1939 is missed from the table, so add it.
AD1936 and AD1937 are controlled by I2C interface, so remove them.

Fixes e5224f58e3ef ("ASoC: ad193x: add support to ad1934")
Signed-off-by Axel Lin <[email protected]>

Thanks for catching that.

Acked-by Lars-Peter Clausen <[email protected]>
Quoted 9 lines
---
 sound/soc/codecs/ad193x-spi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
sound/soc/codecs/ad193x-spi.c +0 -0
index 364e8211..b55055a 100644

sound/soc/codecs/ad193x-spi.c static const struct spi_device_id ad193x_spi_id[] = { · line 43

Quoted 7 lines
sound/soc/codecs/ad193x-spi.c +1 -2
@@ -39,9 +39,8 @@ static const struct spi_device_id ad193x_spi_id[] = {
 	{ "ad193x", AD193X },
 	{ "ad1933", AD1933 },
 	{ "ad1934", AD1934 },
-	{ "ad1936", AD193X },
-	{ "ad1937", AD193X },
 	{ "ad1938", AD193X },
+	{ "ad1939", AD193X },

The adau1328 is actually also support by this driver, though I had send a patch for this a while ago, but I guess I didn't. But we can add that later in a separate patch.

Quoted 4 lines
sound/soc/codecs/ad193x-spi.c +0 -0
 	{ }
 };
 MODULE_DEVICE_TABLE(spi, ad193x_spi_id);
maintainer
#2 lore raw

Applied "ASoC: ad193x-spi: Fixup ad193x_spi_id table" to the asoc tree

In reply to Axel Lin

The patch

ASoC: ad193x-spi: Fixup ad193x_spi_id table

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From d46183efe3b57d06461c9bea35e1a0262391fe77 Mon Sep 17 00:00:00 2001

From: Axel Lin <[email protected]>
Date: Tue, 6 Oct 2015 17:26:36 +0800
Subject: [PATCH] ASoC: ad193x-spi: Fixup ad193x_spi_id table

AD1939 is missed from the table, so add it.
AD1936 and AD1937 are controlled by I2C interface, so remove them.

Fixes e5224f58e3ef ("ASoC: ad193x: add support to ad1934")
Signed-off-by Axel Lin <[email protected]>
Acked-by Lars-Peter Clausen <[email protected]>
Signed-off-by Mark Brown <[email protected]>
---
 sound/soc/codecs/ad193x-spi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
sound/soc/codecs/ad193x-spi.c +1 -2
index 364e8211..b55055a 100644
@@ -39,9 +39,8 @@ static const struct spi_device_id ad193x_spi_id[] = {
 	{ "ad193x", AD193X },
 	{ "ad1933", AD1933 },
 	{ "ad1934", AD1934 },
-	{ "ad1936", AD193X },
-	{ "ad1937", AD193X },
 	{ "ad1938", AD193X },
+	{ "ad1939", AD193X },
 	{ }
 };
 MODULE_DEVICE_TABLE(spi, ad193x_spi_id);
Signature · 1 line
2.5.0